Commit graph

39240 commits

Author SHA1 Message Date
William Wilgus
239ba599fd [Bugfix] FS#13908 hotkeys not saved when language is changed
Lang IDs get localized, if using them in a setting they should be
converted to english

adds lang_id_to_english() which walks the core builtins to return the lang id in english

Change-Id: Iced0d70be1318e512a8f3756e2bef1102dc511d8
2026-05-26 01:28:19 -04:00
William Wilgus
e471fe4115 [FixRed] Tree Hotkey on devices without HAVE_HOTKEY
Change-Id: I36f2fd8fc5edb2ac019a176cb9d3a3d014f1970d
2026-05-25 15:04:22 -04:00
William Wilgus
21e9d3f449 Hotkey Tree share code with WPS Context / Hotkey Wps
Change-Id: I0d81601bdb8279e845a874486ac4c1516b9d7dfc
2026-05-25 14:50:33 -04:00
Solomon Peachy
ff3155be9a lcd: Fix possible unset-before-use variable in 4bit alpha blending
Change-Id: I39e779e9452239b00731f31f55225cd979afe911
2026-05-25 13:05:49 -04:00
Solomon Peachy
c2344070ac xworld: Fix set-but-unused variable warning with GCC16
Change-Id: I5e20a32d84ebc7ca56278988b8add9ee644138ba
2026-05-25 13:00:30 -04:00
William Wilgus
bf0fa29a30 WPS Context Menu configurable entry
Allow setting context menu items

reuses WPS hotkey items

Runs the item
displays the item

Open plugin shows the item name

Pitch shows the pitch speed amount

add 'Show In Files' hotkey item

devices without a hotkey get an extra item

added Manual entries

Change-Id: I427e70e1cad15364ac5d2a7114032e97cc9eee1a
2026-05-25 11:07:59 -04:00
Solomon Peachy
9a142ee02d checkwps: Fix warning uncovered with GCC16
/home/rbbuild/rockbox/tools/checkwps/checkwps.c: In function 'main':
/home/rbbuild/rockbox/tools/checkwps/checkwps.c:329:21: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
329 | char *ext = strrchr(name, '.');
| ^~~~~~~

Change-Id: I0c62600f269456cb81d0e3eaf77839c9103f2e41
2026-05-25 09:10:08 -04:00
mojyack
44e8d8226a configure: switch from -std=gnu99 to -std=gnu11
which is required for u"" unicode string literals used in the USB stack.
gcc allows this even in gnu99, but clang does not.

Change-Id: I1700fe503f20f31ba4704f8bef1ccca45f822620
2026-05-25 08:47:51 -04:00
mojyack
2291aa24f2 usb: refactor control request handling
this commit is a combination of the following changes, which
significantly refactors usb core and class drivers.

1. unify usb buffers of each class driver to reduce iram usage
currently, many class drivers allocate their own buffer to receive
control out data, which is a waste of iram.
share one common buffer for that usage to address the issue.

2. simplify control request handling by implicitly receiving write
   request data packets
change 1 above fixed the data destination. therefore, having the core
receive the data allows us to reduce the class driver's work and
simplifies the api.

3. enhance usb core's control request handling and unify the legacy
   driver api
in order to implement change 2, both the legacy and new driver apis
should be supported. so that, using the designware driver as a
reference, the new driver api functionality is move into usb core.
this simplifies the usb device drivers by requiring them to implement
only the functionalities equivalent to the legacy api.

tested with ipodvideo(arc) and erosqnative(designware)

Change-Id: I3627daa90278751f599e2108ec150ec3f8f6c524
2026-05-25 12:42:36 +01:00
mojyack
64b1f09e06 usb: designware: cleanup irq handler
Change-Id: Ic1926a8277d32721e3c736472dfc41a57ba0d433
2026-05-25 07:38:37 -04:00
Christian Soffke
edecad823e gui: list-skinned: fix scrollbar lag
The skin engine is responsible for drawing custom
scroll bars, but isn't kept in sync with list redraws.

Change-Id: Ieb457a4eb8442d4521c67a46a94c4d2132814c64
2026-05-25 07:33:57 -04:00
Christian Soffke
c0a8303a9c gui: simplify screen updates
Eliminate the somewhat circuitous skin_defer_rendering
and skin_render_deferred functions introduced in commit
c145d19e85.

skin_render (and thus skin_update and sb_skin_update),
along with skinlist_draw, list_draw (and thus
gui_synclist_draw), and quickscreen_draw, will never
update the screen anymore. Instead, the skin is only
marked as dirty now.

GUI_EVENT_ACTIONUPDATE redraws the skin as necessary,
and updates the screen afterwards, if the skin is dirty.
This event is sent from get_action, just like before.

A new event, GUI_EVENT_ACTIONREDRAW allows you to redraw
the skin without causing an immediate update at the same
time.

Change-Id: Ib20644853ead901e32f639000f044d6935135bae
2026-05-25 07:33:53 -04:00
Christian Soffke
727cb798e1 usb: disable status event debouncing
commit 3307b04 didn't fully get rid of the PANICs observed on the
Fiio M3K after adding a debounce interval for USB status by event
in e75a3fb, so this reverts to the previous behavior

Change-Id: I42b45a545eb1e26fa3ae3150504712079678f96e
2026-05-25 07:01:49 -04:00
Christian Soffke
04e557898f playlist: delay loading splash when adding indices
For playlists whose indices can be quickly added,
we should not be showing a splash.

Change-Id: Ib58fe8e28201f519e410fa99b2cb19e7e9a70fc9
2026-05-24 22:21:45 -04:00
Christian Soffke
ae17d606be playlist_viewer: provide UI feedback when loading is delayed
If Playlist Viewer can't open instantaneously due
to the retrieval of metadata, or on devices with disk
storage, make sure the UI doesn't feel unresponsive

Change-Id: Ib7a837515b4fb89ee0ee34ec04541200248b1d6f
2026-05-24 22:21:38 -04:00
Solomon Peachy
cfbbf5b488 pdbox: Fix up a pile of set-but-unused variable warnings with GCC16
Change-Id: I8de93d879ade61251fdde205353120a8e583b157
2026-05-23 21:31:25 -04:00
Solomon Peachy
95df5fdec0 doom: Fix set-but-unused warnings with GCC16
Change-Id: Iecd8ea9f5dc95f37955bed5e4892a90a93472cc6
2026-05-23 21:22:52 -04:00
Solomon Peachy
eb6746c1d6 albumart: fix warning with GCC16
apps/recorder/albumart.c:68:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
68 | sep = strrchr(fullpath, '/');
| ^

Change-Id: Ifd25623c8fa649302e44421316671aec2de9f037
2026-05-23 21:11:40 -04:00
William Wilgus
4ffd098ac9 [bugfix] text_viewer plugin, wonky word wrap, line pos buffer overflow
IpodVT reported odd word wrapping in the case of a perfectly fitting line on a space
which carried over to the next line

in the process I got a ASAN overflow on the line buffer due to
the possibility that lines_per_page - 1 might be -1 and then
reading off in space for an offset into the file
not sure that this would really cause an issue since it would presumably
be bounded within the boundries of the file anyway

Change-Id: Ib5b2c5a30b58faf8bda653f9b9d8d7f76cfb8069
2026-05-23 18:24:01 -04:00
Skye
557694a07f libc: add sscanf to core
Change-Id: Ia4162132a500e4d06305eab724250b7714091b9e
2026-05-23 08:03:09 -04:00
Christian Soffke
6a252576f5 bookmark: stop scrolling list item for skinned context menu
Lists with a selection size of >1 aren't skinned, so we
we have to manually take care of calling scroll_stop on
the un-skinned bookmark list before displaying the
(skinned) context menu.

Change-Id: Ie7ce627b5ea073be03304b7c676403cdfb4d3243
2026-05-23 12:05:07 +02:00
William Wilgus
f456dbfa52 [Bugfix] FS#13902 lua strfrtime wrong month field, did not add one to month
posix month field is called mon not month
mon goes from 0-11 so strfrtime needs to add 1 to the number for %m
day of week goes 0-6 where 0 = sunday
day of year goes 0-365 (365 on a leap year)

according to lua everything starts at 1
so month is 1-12
day of week goes 1-7 1 = sunday
day of year is 1-365 (366 on a leap year)

added some fields in the time_date example

Change-Id: Icd502b172285d23133488aa3456786d756667bfa
2026-05-22 18:10:36 -04:00
Skye
b5597a1c38 erosqnative: add HW4 BT pins
Change-Id: I2569f4db70261b454a1e1444ec529f8e714adc80
2026-05-20 10:24:12 -04:00
Solomon Peachy
bf8328fbe0 rbcodec: Fix build failure with DEBUG but without LOGF
Regression from 39497d1c74

Change-Id: I09ae974b56cd94753caa8bd4630d7ffcfe057846
2026-05-19 19:48:41 -04:00
Christian Soffke
1c39495ec2 playlist_viewer: simplify format_line
Reduces GNU Complexity score from 33 to 2.

Additionally:

- Allocate MAX_PATH, instead of MAX_PATH+1,
  for formatted id3 info (NULL terminator is
  already included)

- Ensure minimum name buffer size of 2*MAX_PATH,
  instead of MAX_PATH+1, so that there is space for
  both the formatted track name and, if enabled, the
  id3 info of a single track

Change-Id: Ie60590f6c0da4fe3a515b5643494a29cfc56de50
2026-05-19 19:37:29 -04:00
Christian Soffke
0492021247 fix yellow in commit 13a0e58b1c
Change-Id: Id2ec3d0ace5aab9d67aeda54f4cef52d0d111b01
2026-05-19 23:23:39 +02:00
Christian Soffke
13a0e58b1c gui: usb_screen: drawing adjustments
- Eliminate separate display update for USB screen UI vp;
  wait for skin_render instead

- Eliminate outer loop around handle_usb_events

- Use handle_usb_events in Simulator as well.
  Fixes USB screen being dismissed by any button presses,
  or by system events.

- When USB keypad mode is changed, only redraw the title viewport

- Delete unused MODE_NAME_LEN #define

- Hide "USB keypad mode:" prefix. Only display current mode setting,
  which requires less scrolling and ensures that the new setting
  is always visible immediately after it has been changed

- Change comment from:

  /* Don't return until we get SYS_USB_DISCONNECTED or SYS_TIMEOUT */
  to: /* Don't return until we get SYS_USB_DISCONNECTED */

  which reflects existing behavior (comment may have been
  copy-pasted from usb_wait_for_disconnect_w_tmo)

- Don't scroll USB keypad mode unless UI vp's width is > 1, since
  some themes try to hide the USB viewport and display a custom UI
  instead

Change-Id: I9b9703025b00ad807920ee60a843f269f414f6f9
2026-05-19 17:06:47 -04:00
Roman Artiukhin
69b6c97e58 Codecs: mp4: Improve support for long files
Load stts (time to sample) table on demand if it doesn't fit in RAM.

Fixes FS#13889 (in most cases I've seen files with single element in this table and problematic one has 111200 elements)

Change-Id: I719f92a4512a45472739587e81861b9bc545f349
2026-05-19 16:28:50 -04:00
Christian Soffke
aae46a822a simulator: support usb_inserted %bu tag (FS#13843)
Change-Id: Ia236c51f338bd333795f17991eb9e3659e722c6c
2026-05-19 13:37:28 -04:00
Christian Soffke
29d62e933f plugins: text_editor: fix list items that continue to scroll (FS#13900)
When using a theme with custom skinned lists
(e.g. Themify 2), a line in Text Editor will
continue to scroll after opening the context
menu, because you're switching from an un-
skinned list to a skinned list, which means
that list-skinned.c/list_draw isn't calling
scroll_stop_viewport for the list_text_vp,
as would be the case for un-skinned lists.

Change-Id: I952937166d8f17c9d57f4d93e715de970c49e5e8
2026-05-19 12:20:11 -04:00
Christian Soffke
1a8efac956 manual: fix skinned list tag mixup (FS#13895)
Change-Id: I890fe8800aa6e8640f445cd79ee3fa192398ad0c
2026-05-19 17:11:42 +02:00
William Wilgus
58f75311d8 merge font_getstringnsize and font_measurestring
measure string just needed a bit more to be a replacement

Change-Id: I25c760df5edd7224b50c0522b4e44b1f9b574c51
2026-05-18 01:36:50 -04:00
William Wilgus
6e27ba80e4 [bugfix] splash.c /t as last char should not add extra spaces
small bug, /t as the last character should left justify without
adding spaces to the end of string
/t also added too many spaces to the end of tabbed lines

adds info comment for new usage

ifdef removes some functionality for the bootloader

Change-Id: Ia4ba80f631f8bac3a13441912a8560616fa2c784
2026-05-18 00:12:18 -04:00
Solomon Peachy
d97e4425c6 playlist_viewer: Use 'NULL' instead of '0' when calling playlist_viewer_init
For some reason this resolves an apparently-unrelated warning about a const
violation inside playlist_viewer_init().

Change-Id: Ifd4eb008335876707abe64da04a3afd0d1c46633
2026-05-17 16:45:47 -04:00
Solomon Peachy
39497d1c74 build: Silence a pile of set-but-not-used warnings in codecs
GCC16 is stricter about reporting these, and while we can rely on
the compiler to optimize away dead stores, we're better off eliminating
them from the source code.

Change-Id: I14570a986811a77ca656c60d792593ff8c458571
2026-05-17 16:39:06 -04:00
Christian Soffke
8abc859c32 fix regression in cae4336
Change-Id: I026fe919401bbe13cef161a6eb6ce44e5fbbbb6f
2026-05-17 14:49:46 +02:00
Solomon Peachy
cae433608f build: Silence a pile of set-but-not-used warnings with GCC16 in apps/
The compiler is smart enough to optimize away dead stores but let's
just get rid of them in the first place

Change-Id: I5c85d7c05ef03b084205356a21248f7b049296b0
2026-05-17 08:03:44 -04:00
mojyack
2c0381a34e plugins: mpegplayer: libmpeg2: idct_armv6.S: use explicit register pair for ldrd
Change-Id: I65c7516f500cfe9f2b4990f769e9d85708f7fc62
2026-05-17 07:36:11 -04:00
mojyack
a446c06b21 recorder: jpeg_idct_arm.S: use explicit register pair for ldrd
Change-Id: Ic76b4ed4d2a3bea16937a5880502f0a57dd4e556
2026-05-17 07:35:00 -04:00
William Wilgus
d8db60b34a [bugfix] splash goes into infinite loop when vp is too small
chris_s reported that a vp width of 1 wpuld cause the trxt reflow to go into an endless loop

check for this and skip displaying the splash
add a warning to the sim for catching unintentional cases of this

Change-Id: I9e1c561f745b5bcf113d0a6cdff57a00cd190fd4
2026-05-16 17:33:20 -04:00
William Wilgus
7c2e84ad2f FS#13898 expand date_time.lua example
os.date(*t) did not return table when *t supplied because
require("strfrtime.lua") was not loaded

Change-Id: I89b02adad633dca0106b571bdb4b10ffb39cbcf6
2026-05-16 15:54:42 -04:00
William Wilgus
17d28b96b6 lua rocklib.c add splash_progress function
Change-Id: I864a301368c3144a7808ecfa9644e679af2ac727
2026-05-16 14:56:51 -04:00
mojyack
b350d6e066 target: arm: s5l8702: crt0.S: use APSR_nzcv instead of r15 in mrc operand
Change-Id: I7e0cf0325407cade9d95d73af6f8dceb92bf3155
2026-05-16 12:02:32 -04:00
mojyack
c4abbdd718 target: arm: mmu-arm.S: use APSR_nzcv instead of r15 in mrc operand
Change-Id: Ie27d323ac497fe8d63cee89d2c0722caa293cd25
2026-05-16 12:02:11 -04:00
mojyack
127428e32d bootloader: ipodnano2g: fix mcr/mrc usage for clang
Change-Id: I0e328c2d0d4243783cbede843a6451c45f5ba914
2026-05-16 12:01:36 -04:00
mojyack
6fc41c7cdf target: arm: s5l8700: fix mcr/mrc usage in crt0.S for lld
Change-Id: I6d25e4759e1d86f8de3047d10f5fcac8030afc6e
2026-05-16 12:00:45 -04:00
William Wilgus
21fe45caad [Bugfix] splash adjust string split logic, tab justify
only split a long word across lines if it is larger than screen width
also consider \0 as a valid place to split so we still run through the space finding loop

make /t left justify the splash window (in RTL langs it right justifies)

Change-Id: Id2955878a178c66cb0a1c644e62f943247666d8b
2026-05-16 11:51:53 -04:00
Solomon Peachy
1beafb9290 FS#13891 - Updated Romanian and Moldavian translations (Mihai Alexandru Vasiliu)
Change-Id: Ida441f2324fad443c89da82a9d4d58fcbb9e2f6f
2026-05-16 07:37:40 -04:00
Solomon Peachy
6ee85ce61a imx233: Increase the memory region reserved for loading firmware
The imx233 bootloader reserves the first 1MB of DRAM for loading the
main firmware, but the recent utf8proc changes means we now exceed that
size on most imx233 targets.  Bump this up to 1.5MB to give us more headroom

Change-Id: I1b8bede85d06d40338ea6e3d9abb4e5da34423be
2026-05-15 11:41:23 -04:00
William Wilgus
b4c308d698 splash, rework word wrap, support some escape characters
Fixes issues with multiple spaces
adds support for \n and multiple \n
adds support for \t (only at start of line)

adds utf8 aware string splitting

locks to max width/height

adds \f to reset min width / height

larger buffer for units with ram > 8mb

make splash buffer static

Needs testing
Change-Id: I46915043719dce0d696c5ab0da3ed92e4755829c
2026-05-15 11:13:12 -04:00