Adds 'Add Current to Shortcuts' for settings alowing you to save
the current value and restore it with a shortcut
Change-Id: I0d5c5da9553248a70fd46d5553486ebf7865a20a
maxlen is set to MAX_FILENAME by all callers so lets just make that part of the deal
check the file exists before we set it
Change-Id: I3074f3164fcd4b8873b69612d5c1a51a39de4baf
the fmr file wasn't being detected on multivolume targets
the global preset list couldn't be cleared once set
empty global preset file wasn't detected properly either
Change-Id: I9c4b40ed0b6f3dbb0d38eb668fc74a512ea34062
rockpaint is the only plugin doing anything dit setting the dirfilter pointer
it appears to restore it but this is cheap insurance on weird crashes
that result..
Change-Id: I70c826d6ec4c9cb6e1539ab23f1de82ca3e67ad1
rockbox_browse() set its own *dirfilter and then may neglect to restore it
set_current_file_ex()
can take a unified path and file or separate path and file
only issue is when you send a folder and don't have the final slash
its then interpreted as a file and current file is set to it
meanwhile path is split and you end up in the parent dir
instead if filename is null check if path points to a directory
if dir_exists(path) then we will use it as is and set filename to ""
Change-Id: I6beaa91141c1a4025cdfac5d6ba426137146c212
Also adds the ability to supply a directory without the final slash
you then are take to the directory but have the ability to travel
up one level above before exiting
when you hit cancel
Change-Id: I1091fbe496e2c7c34ecb2113ab1cd31b0c678d9d
Stops “Error accessing playlist control file” message
after returning from USB mode, due to control file
fd being closed
Change-Id: Ic4ecb276ef32f8dc24fe7e540742161b50934c73
remove nvram and use the existing settings framework for it
add a crc check to the user_settings data to see if we need to save
the user setting file or if we can just save the status file (resume.cfg)
move volume to the system_status struct so we don't write the whole settings file
over volume changes
allow user to still export volume with save sound settings
allow the user to also export pitch and speed
name the file .resume.cfg
Rename all the SYSTEM_STATUS save file variables to TLAs to save space and
discourage tinkering
Cleanup DEBUG_AVAIL_SETTINGS output
when saving user_settings it calls status_save as well this cause the resume
file to be written twice. instead remove the callback for status_save
when setting_save is called
remove header text when saving .resume.cfg
convert status_save() to status_save(bool force)
add SYSTEM_STATUS_UPDATE_TICKS
for ATA device set this to 5 minutes
since we arlready wait for the disk to be up before saving
we don't want to miss our window
for all other every 15 minutes
that way if the battery is too low by the time shutdown comes around you
don't lose much progress
Change-Id: I27214ffd6e5d5494ee5ca83b14f04a41ba426ad7
by tying initial to NVRAM_BLOCK_SIZE we get automatic invalidation when the
system_status struct changes
Change-Id: Icd8fad14bdd31dddd609833830c939d5560feeb1
Revisit this after discussion with chris_s on IRC and forum
Pitch menu now changes icon when pitch has been changed
uses NVRAM to save the pitch settings unconditionally
Manual updated
Change-Id: Idcb4c2b7fe42f7a203dc4bfc46285657f370d0fd
check file_exist(PITCH_CFG_FILE)
close fd when finished
If you already have a setting saved and you reenter the pitch plugin
with differing pitch settings you will be asked to restore your
default settings
update manual entry to be a clearer
Change-Id: Iaaaf08983a355f9848412d1c6b0bba25d6ea8f39
if you run yesno screens back to back or another screen with
wait_for_release you may never see the release
instead clear anything in the queue but release events
Change-Id: I1b1e42cbb44f2fdfed441ab1f217b6ea4fe07492
In 2c4c1b9, I missed the fact that we still need these,
so that slashes in names aren't interpreted as a path
separator.
Change-Id: I2df0745669c4673497a506a99e754c63dcba045e
Instead of responding with a "Nothing to resume"
message when user tries to resume a playlist that's
finished playing, offer to start from the beginning
again.
Change-Id: Icc4894d4e2d2e29beb1c7646462f9af69e5733aa
Displaying large embedded album art in the
image viewer requires playback to be stopped,
which is pretty disruptive, so respecting the
system setting here may make sense
Change-Id: I479466bf26d85c3305d6c81e2c1818b2c2b2cbdb
With no control file present, the message
"Error accessing playlist control file"
was displayed, due to playlist_resume being
called from gui_usb_screen_run.
You were likely to only run into this after a clean
install, if you hadn't listened to any music yet.
It probably makes sense to move the check for the
existence of the control file into playlist_resume,
and not even have it show a separate access error
message when the file doesn't exist.
Change-Id: Ib3a643c43d3d4d499fa5a13c01955779d69cd357
Unless you had manually resumed the playlist, you
didn't get any warning after Rockbox rebooted, when
replacing a modified current playlist.
Change-Id: Ibc83e3db4e6ee51e94204ac7732760894d2fb602
to check for against /.rockbox/viewers (VIEWERS_DIR) on multivolume you
need to strip all the prefix junk of volume and potentially strip the
redirect directory
Change-Id: I8e24c43d84c3b90ffb4bbf62d4287620a5890ade
ask th user if they want to add a parameter when a viewer is set to an
open plugin entry (wps hotkey, start screen, etc)
Change-Id: I403ac79af15162aeecabb3607923113e27496e4f
skinlist_draw stores a pointer to the list supplied
if this pointer goes out of scope we may try to access it
toggle_theme has a path to handle this but if you move to a a item with the
theme enabled it doesn't release the pointer
later the pointer will be referenced long after it has gone out of scope
limiting this to do_menu() if other areas are problematic the previous
version of this patch applies it system-wide
Change-Id: I57c73d789856cb1a660fb704f02ca55c8978a4d0
rather than going through the whole file each time we can just walk
through the remainder speeds up duplicate removal by quite a bit
check timestamp of tracks to not remove multiple plays of the same song
at different times, unless back to back (then its probably a resume after
shutdown)
devices without RTC use current_tick but thats in centiseconds
convert to milliseconds so we can use the timestamp in the above calculations
my fix to the scrobbler_viewer makes the include menus disappear as
soon as you hide columns so explicitly mark if we are
dealing with a scrobbler log at load
Change-Id: I11bbebe9af45945a7e1326a5e419290086b05aaa
the scrobbler viewer will view any .log file but search and include
column only works with defined headers
it ends up showing a blank result so block this menu for non scrobbler logs
Change-Id: Ifc04dcab52d4416271388bee7d0cb10a144636a4
printcell_set_columns() can take a NULL pointer for the *pcs
it then uses default settings but those were contained within
the scope of the if(NULL) check.
Change-Id: I3147d1f4e3954fdcdb3adb74713f4c8a9a2c08ec
people don't like having to remember to run the TSR plugin so
lets meet them halfway
all tracks are added with timestamp, elapsed, length, trackname
added buffering for ATA devices
still needed:
-Done -- a plugin that parses for duplicates and reads the track info
to create the actual scrobbler log
(log can be truncated once dumped)
this should allow you to run the plugin at leisure
later I'd like to expand this logging to allow
track culling based on skipped songs..
remove the TSR plugin as hard disk no longer need to use it
Change-Id: Ib0b74b4c868fecb3e4941a8f4b9de7bd8728fe3e
- After rebooting, unless the current playlist
had been manually resumed already, the "Save
Current Playlist" option in the root menu's/
playlist catalogue's context menu failed to work.
- Eliminate error message attempting to view current
playlist when no control file present.
Change-Id: I58f1d3dc6f256fcee106ff5a17f69fa46d67b2e4
When playback was stopped (not paused), deleting
the first track of the current playlist started
playback.
Change-Id: I0bd09e1254399d003109215e4e8363a0cd045ac0
