devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Playlist Viewer: fix: deleting track starts playback

Browse source 
When playback was stopped (not paused), deleting
the first track of the current playlist started
playback.

Change-Id: I0bd09e1254399d003109215e4e8363a0cd045ac0
This commit is contained in:
Christian Soffke 2025-01-08 12:32:52 +01:00
parent e4fb35f173
commit 897a96996b
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
apps/playlist_viewer.c
View file

@ -372,7 +372,7 @@ static bool playlist_viewer_init(struct playlist_viewer * viewer,
{
char *buffer, *index_buffer = NULL;
size_t buffer_size, index_buffer_size = 0;
bool is_playing = audio_status() & (AUDIO_STATUS_PLAY | AUDIO_STATUS_PAUSE);
bool is_playing = audio_status() & AUDIO_STATUS_PLAY; /* playing or paused */
/* FIXME: On devices with a plugin buffer smaller than 512 KiB, the index buffer
is shared with the current playlist when playback is stopped, to enable
@ -731,7 +731,8 @@ static enum pv_context_result context_menu(int index)
{
struct playlist_entry *current_track = playlist_buffer_get_track(&viewer.buffer,
index);
bool current_was_playing = (current_track->index == viewer.current_playing_track);
bool current_was_playing = (audio_status() & AUDIO_STATUS_PLAY) && /* or paused */
(current_track->index == viewer.current_playing_track);
MENUITEM_STRINGLIST(menu_items, ID2P(LANG_PLAYLIST), NULL,
ID2P(LANG_PLAYING_NEXT), ID2P(LANG_ADD_TO_PL),