- Skip superfluous "Wait" splash before displaying
index progress
- Display current step that the progress bar pertains to
- Exiting the "Confirm Quit" screen in order to continue
indexing was *extremely* fiddly because of picked-up
button events that would often immediately return you
to the same screen instead of getting you out of it.
This should behave more sanely now. Plus, you should
only see the Quit confirmation screen as a result of
pressing Menu or Cancel now (instead of touching the
scroll wheel for example).
- PictureFlow was unresponsive while removing duplicates
- A Cancel action initiated by the user isn't treated
as an error anymore, nor is a message displayed after
user has already confirmed their intention to quit.
- The plugin doesn't return errors anymore if the user
has already been presented with an error message, to
eliminate redundant splashes, delays, and an unwanted
return to the main menu
Change-Id: I255b8f760ccb0acdfddcacbc7d8a1b17b063e53e
Make the suggested playlist filename for special
entries such as "[Random]" or "[All Tracks]" a
bit more descriptive, by mentioning the current
table as well, e.g.:
"The Beatles [All Tracks].m3u8", instead of just
"[All Tracks].m3u8"
Change-Id: I43d9386c06081540cdcae715afc0b0351857633d
moves shutoff and disk safe to end of file
add warning
comment out shutoff and disksafe level as further protection
Change-Id: I1723b2ae6b2bd7fd359dc7dfcc8f1958d97673fc
when battery_bench is run
exports a file in the rockbox directory called 'battery_levels.default'
if the user wants their own levels they can rename the file battery_levels.cfg
and it will be loaded at boot
some minimal error checking is performed prior to using the values
added manual entry
Change-Id: Ia0126faced0c7229fcf8385a1bcb584b5a9dc378
consolidate the logic for PERCENT tags to a single function
is_default() check is redundant in parse_albumart_load()
static bool isdefault(struct skin_tag_parameter *param)
{
return param->type == DEFAULT;
}
Change-Id: I7391224499624db7a95a2630f96e33827d1e7542
Investigating this issue I found that when
SBS and WPS share the same fonts the refcount prevents
the soon to be unused font from unloading
by the time the fnt is unloaded its already too late because the WPS
load failed.
What appears to work is freeing the fonts used by the skin items ahead
of time via skin_reset_buffers() in a separate loop instead of in the
loop used to load the skin files
Change-Id: Ib118163185d48b67b7c96e436bfb6fab8db546a9
make the plugin context aware to allow user to one
click export from a shortcut, basically it checks if its running in the
file browser if elsewhere does auto export
use a buffer for the fixed portion of the scrobble data
add timed_yield to long running operations
add progress bars and messages as scanning for duplicates takes a while
speed up duplicate scanning 4x
1000 tracks processing took ~2 minutes with duplicate scanning down from ~5
previous patch makes playback logging create a new file after 512k
old files renamed playback_0001.log
make scrobbler able to parse these log files
add ability to skip tracks without metadata and count them
Remove duplicates only for resume or remove all duplicates
allow skipping tracks without metadata or save only filename
update manual
Change-Id: I115bcfd3381f5a978252aac1cdfcc080f0797dda
renames to playback_nnnn.log
you won't get the message when first enabling logging since it
happens at start-up..
Change-Id: I58ca65a48deff7c5bb1f93c3d86d9ee9e19f3f2e
when calling splash, splash_progress repeatedly text rearranges and
the width changes leaving artifacts on the screen from the previously
displayed prompt
save the max width seen between calls to ensure the splash
prompt is never more narrow.
Height could be stored in a
similar manner but I deemed it unnecessary as typically the
text gets longer and the prompt increases in height
while the reflow causes the prompt to get more narrow.
keep track of the current activity and reset the max_width
when activities change (except bootloader)
Change-Id: I3303bd9135ab1d7bcf28bd5c28d0ab5346bf2697
Discovered this in the sim with car adapter mode: on
when charger gets disconnected the device is paused
if you have a different screen up the scrolling elems
get redrawn incorrectly over the current screen
to fix check the activity is the WPS, FM, or RECORDING before allowing redraw
Change-Id: Ie3618347fde446fe0b78b9d3c67261ca63ffee1c
We've been limited to level 7 since approximately forever, so
there's no point in wasting translation strings on anything higher.
Change-Id: Idee0f1f0aa1b99d9efdcaa34d0d3130a54e1628e
F_CUSTOM_SETTING write to the cfg file they do not however
have a value in the settings struct to check against for the CRC
at best you get the is_changed value but as Chris_S pointed out this
works the first time BUT unless you are changing from DEFAULT to
'is_changed' or back there is nothing different in the CRC and thus
further changes to custom settings do not get saved unless other
settings change the CRC.
Instead we will ask each of the custom settings to write their output
and run the CRC on those values as well and allowing us to check for changes
Change-Id: Ib3e7b621d676be5eb5ddc9eea00c4805292773fb
can't have it both ways blocking directories from filename
makes shortcut folders browse into the folder but blocks
the folder when the file browser loads it causing you
to be in the wrong folder upon resume
I wanted a way for the user to be able to leave the slash off
so ensure shortcut folders have a trailing slash (on load)
Change-Id: I9ea173a90a8c12291a159e7d30ee1076e0ca5d3e
The main usecase of this is so the morse cheat sheet does not look broken (with cut characters) when we are using a different/larger sysfont. All is adjusted automatically thanks to the SYSFONT_WIDTH and SYSFONT_HEIGHT constants.
Long pushs are now represented as vertical long bars, while short pushs are represented into short bars (centered in the middle). The long pushs bars are not larger anymore, so spacing is consistent everytime for all long+short order different combos thus looking cleaner and more readable.
The code was also a bit refactored to be more easily understandable in the future by using clear variable names to describe the magic values.
- Tested with mini2g: no regression, can still show all characters no problem within the limited screen space that is available on this device
- Tested with ipod6g by configuring the same default font as erosq (14-Rockboxmix) which is larger than the default sysfont: looks really good ! Way more readable than before
- Tested with 4gmono: no regression
Change-Id: Ida8b37ac7bd0bb5f0d314b5dea7657aa41bf2650
Accidentally put one too many zeroes in the address, placing it into
(real) IRAM instead of just past the edge of DRAM.
This didn't affect the s3c2440 and imx31, as they didn't have anything
in that typo'd location.
Change-Id: I2a2e3e3e0d1222ccd04901f8a85790cf21f0aac9
optimize the index search loop using mod()
instead of checking index and then scanning we can start at index
and roll over saving a compare in the process
Change-Id: Ie54fbf1ca0131db8914985b654248eeb8d725a82
Wrong title is due to the VIRT_PTR being 0 so when a NULL
string is passed through P2STR() you get langid(0)
that was 'Yes' now it will be 'Rockbox'
the crashing menu was due to a call to retrieve entries that wasn't guarded
against getting called on a menu with no entries
g#5911 introduced this path to call custom_action for shuffled track adding
Change-Id: I3918debbe2e79dfc9595df56b05b1ae59ba94317
while its not a particularly hot path it still gets called upwards
of 1000x on startup
with a little pre processing we can make it faster than even the
prior version
check first letter before calling function
move strlen check to after the case match
Change-Id: I0108aaf9828501b57b0950fbc24cd478a9eeacc1
this is not a hot path only runs at start-up and tagnav reload
so speed is not so much of a concern
we can split the data into two separate tables to
remove the padding and allow symbols to be stored in uint8
(highest symbol <128) and do strlen at TOU
use uint16_t for get_clause()
Change-Id: I0f8663d0de9cac102f1d58b43bf200272754c466
- The "Special character" entry will show all special characters (non numerical + non letters)
- The numerical entry was bug, and could show some special characters from the ASCII table. It is now fixed.
Change-Id: I001fb322fab81918996e15e4d0ca6b7c9e5160af
Add a new entry, it is useful to go this way for large libraries rather than scrolling manually through the whole list
Change-Id: Ia54b613b4a5fa40863ebb176a549287d3a765a56
* All tagnavi.config entries pulled into language files
* Database viewer looks up LANG_IDs from the entries
* If we find a match, we can translate and voice these entries
* Add (disabled) mechanism to allow voicing database metadata
Original patch by Paul Sauro
Modifications by William Wingus
Further modifications by Solomon Peachy
Todo/Problems:
* Current Tagnavi headers are rather awkward in English
* Can't voice the "By first letter" alphabetic entries
* No mechanism for generating talk clips for DB metadata
Change-Id: Ic276ccda1bd8aae550d38be852bae4c6f697cd47
