len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

FS#13938 - Line disappears after %Vf tag and %Vb tag

Browse source 
As far as I can tell this was indtroduced during this commit
32ff4e93bd
basically they added a NOBREAK flag
to all the commands that had '\n'
where as
    { SKIN_TOKEN_VIEWPORT_FGCOLOUR,       "Vf" , "S"},
    { SKIN_TOKEN_VIEWPORT_BGCOLOUR,       "Vb" , "S"},
do not have \n yet they were changed to have the NOBREAK flag applied
    { SKIN_TOKEN_VIEWPORT_FGCOLOUR,       "Vf" , "S", NOBREAK },
    { SKIN_TOKEN_VIEWPORT_BGCOLOUR,       "Vb" , "S", NOBREAK },
this causes anything after the command to be ignored

-- Note added to manual this will be a won't fix
due to the possibility of breaking existing themes

Change-Id: I0135f04c344bf817c104f951a657e2690f2d36bb
This commit is contained in:
William Wilgus 2026-06-30 12:11:09 -04:00
parent d87755c535
commit acff6143c4
3 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
manual/advanced_topics/viewports/colour-vp-syntax.tex
View file

@ -18,6 +18,9 @@
\note{The correct number of commas with hyphens in
blank fields are still needed.}
\note{Any text or tags after \%Vf() or \%Vb() may or may not display depending
on context thus text or tags following on the same line should be avoided,
this behavior preserves backward compatibility.}
\begin{example}
%V(12,20,-,-,1) %Vf(000000) %Vb(FFFFFF) %Vg(FFC0CB, FF0000, FFFF00)

3
manual/advanced_topics/viewports/grayscale-vp-syntax.tex
View file

@ -16,6 +16,9 @@
\note{The correct number of commas with hyphens in
blank fields are still needed.}
\note{Any text or tags after \%Vf() or \%Vb() may or may not display depending
on context thus text or tags following on the same line should be avoided,
this behavior preserves backward compatibility.}
\begin{example}
%V(12,20,-,-,1) %Vf(0) %Vb(3)

8
manual/appendix/wps_tags.tex
View file

@ -62,14 +62,18 @@ show the information for the next song to be played.
\config{\%V(x,y,[width],\tabnlindent[height],[font])}\newline
\config{\%Vf([fgshade])}\newline
\config{\%Vb([bgshade])}
& See section \ref{ref:Viewports}\\}}
& See section \ref{ref:Viewports}\newline
\note{Any text or tags after \%Vf() or \%Vb() may result in
unexpected behavior and should be avoided.}\\}}
\opt{lcd_color}{%
\config{\%V(x,y,[width],\tabnlindent[height],[font])}\newline
\config{\%Vf([fgcolour])}\newline
\config{\%Vb([bgcolour])}\newline
\config{\%Vg(start,end \tabnlindent[,text])}
& See section \ref{ref:Viewports}\\}
& See section \ref{ref:Viewports}\newline
\note{Any text or tags after \%Vf() or \%Vb() may result in
unexpected behavior and should be avoided.}\\}
\opt{lcd_non-mono}{%
\config{\%Vs(mode[,param])}