From acff6143c41515090086b27744dd31088ee74fb8 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Tue, 30 Jun 2026 12:11:09 -0400 Subject: [PATCH] FS#13938 - Line disappears after %Vf tag and %Vb tag As far as I can tell this was indtroduced during this commit 32ff4e93bdc15a21faf23e46bd2e0eb659bf8f31 basically they added a NOBREAK flag to all the commands that had '\n' where as { SKIN_TOKEN_VIEWPORT_FGCOLOUR, "Vf" , "S"}, { SKIN_TOKEN_VIEWPORT_BGCOLOUR, "Vb" , "S"}, do not have \n yet they were changed to have the NOBREAK flag applied { SKIN_TOKEN_VIEWPORT_FGCOLOUR, "Vf" , "S", NOBREAK }, { SKIN_TOKEN_VIEWPORT_BGCOLOUR, "Vb" , "S", NOBREAK }, this causes anything after the command to be ignored -- Note added to manual this will be a won't fix due to the possibility of breaking existing themes Change-Id: I0135f04c344bf817c104f951a657e2690f2d36bb --- manual/advanced_topics/viewports/colour-vp-syntax.tex | 3 +++ manual/advanced_topics/viewports/grayscale-vp-syntax.tex | 3 +++ manual/appendix/wps_tags.tex | 8 ++++++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/manual/advanced_topics/viewports/colour-vp-syntax.tex b/manual/advanced_topics/viewports/colour-vp-syntax.tex index d027c3b757..cd72363ac2 100644 --- a/manual/advanced_topics/viewports/colour-vp-syntax.tex +++ b/manual/advanced_topics/viewports/colour-vp-syntax.tex @@ -18,6 +18,9 @@ \note{The correct number of commas with hyphens in blank fields are still needed.} +\note{Any text or tags after \%Vf() or \%Vb() may or may not display depending + on context thus text or tags following on the same line should be avoided, + this behavior preserves backward compatibility.} \begin{example} %V(12,20,-,-,1) %Vf(000000) %Vb(FFFFFF) %Vg(FFC0CB, FF0000, FFFF00) diff --git a/manual/advanced_topics/viewports/grayscale-vp-syntax.tex b/manual/advanced_topics/viewports/grayscale-vp-syntax.tex index 2bced327d8..76966406f2 100644 --- a/manual/advanced_topics/viewports/grayscale-vp-syntax.tex +++ b/manual/advanced_topics/viewports/grayscale-vp-syntax.tex @@ -16,6 +16,9 @@ \note{The correct number of commas with hyphens in blank fields are still needed.} +\note{Any text or tags after \%Vf() or \%Vb() may or may not display depending + on context thus text or tags following on the same line should be avoided, + this behavior preserves backward compatibility.} \begin{example} %V(12,20,-,-,1) %Vf(0) %Vb(3) diff --git a/manual/appendix/wps_tags.tex b/manual/appendix/wps_tags.tex index bb27840f41..7c6dbe713a 100644 --- a/manual/appendix/wps_tags.tex +++ b/manual/appendix/wps_tags.tex @@ -62,14 +62,18 @@ show the information for the next song to be played. \config{\%V(x,y,[width],\tabnlindent[height],[font])}\newline \config{\%Vf([fgshade])}\newline \config{\%Vb([bgshade])} - & See section \ref{ref:Viewports}\\}} + & See section \ref{ref:Viewports}\newline + \note{Any text or tags after \%Vf() or \%Vb() may result in + unexpected behavior and should be avoided.}\\}} \opt{lcd_color}{% \config{\%V(x,y,[width],\tabnlindent[height],[font])}\newline \config{\%Vf([fgcolour])}\newline \config{\%Vb([bgcolour])}\newline \config{\%Vg(start,end \tabnlindent[,text])} - & See section \ref{ref:Viewports}\\} + & See section \ref{ref:Viewports}\newline + \note{Any text or tags after \%Vf() or \%Vb() may result in + unexpected behavior and should be avoided.}\\} \opt{lcd_non-mono}{% \config{\%Vs(mode[,param])}