len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

rbutil: Use 'English' as the default voice in the selection box

Browse source 
Instead of the first one on the (alphabetically sorted) list, currently
Bulgarian.

Ideally we'd try to discern this from the current system/UI language

Change-Id: I82a14716afb484fbaea22f78fe4dd7f00c24252e
This commit is contained in:
Solomon Peachy 2026-07-04 09:33:27 -04:00
parent 6351b64fff
commit 55d15b17b7
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
utils/CMakeLists.txt
View file

@ -91,7 +91,7 @@ if(QuaZip-Qt${QT_VERSION_MAJOR}_FOUND)
message("-- Found QuaZip")
set(QUAZIP_LIBRARY QuaZip::QuaZip)
else()
message("-- Could not find system QuaZip, uisng our own copy.")
message("-- Could not find system QuaZip, using our own copy.")
# TODO: Upstream has cmake support, use that instead.
add_library(quazip
${CMAKE_CURRENT_LIST_DIR}/rbutilqt/quazip/ioapi.h

5
utils/rbutilqt/gui/selectiveinstallwidget.cpp
View file

@ -187,14 +187,15 @@ void SelectiveInstallWidget::updateVoiceLangs()
ui.voiceCombobox->addItem(it.value().toString(), it.key());
LOG_INFO() << "available voices: adding" << it.key();
}
}
// try to select the previously selected one again (if still present)
// TODO: Fall back to system language if not found, or english.
int sel = ui.voiceCombobox->findData(current);
if(sel >= 0)
ui.voiceCombobox->setCurrentIndex(sel);
else
ui.voiceCombobox->setCurrentIndex(ui.voiceCombobox->findData("english"));
// TODO: Fall back to system language before the final "english" fallback.
}