From 55d15b17b7e46d1a78665dfdb98413ad422068e7 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Sat, 4 Jul 2026 09:33:27 -0400 Subject: [PATCH] rbutil: Use 'English' as the default voice in the selection box Instead of the first one on the (alphabetically sorted) list, currently Bulgarian. Ideally we'd try to discern this from the current system/UI language Change-Id: I82a14716afb484fbaea22f78fe4dd7f00c24252e --- utils/CMakeLists.txt | 2 +- utils/rbutilqt/gui/selectiveinstallwidget.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/utils/CMakeLists.txt b/utils/CMakeLists.txt index 3dc1d005d1..022b4c2455 100644 --- a/utils/CMakeLists.txt +++ b/utils/CMakeLists.txt @@ -91,7 +91,7 @@ if(QuaZip-Qt${QT_VERSION_MAJOR}_FOUND) message("-- Found QuaZip") set(QUAZIP_LIBRARY QuaZip::QuaZip) else() - message("-- Could not find system QuaZip, uisng our own copy.") + message("-- Could not find system QuaZip, using our own copy.") # TODO: Upstream has cmake support, use that instead. add_library(quazip ${CMAKE_CURRENT_LIST_DIR}/rbutilqt/quazip/ioapi.h diff --git a/utils/rbutilqt/gui/selectiveinstallwidget.cpp b/utils/rbutilqt/gui/selectiveinstallwidget.cpp index 811a7eeacf..1a81ae3d8f 100644 --- a/utils/rbutilqt/gui/selectiveinstallwidget.cpp +++ b/utils/rbutilqt/gui/selectiveinstallwidget.cpp @@ -187,14 +187,15 @@ void SelectiveInstallWidget::updateVoiceLangs() ui.voiceCombobox->addItem(it.value().toString(), it.key()); LOG_INFO() << "available voices: adding" << it.key(); } - } // try to select the previously selected one again (if still present) - // TODO: Fall back to system language if not found, or english. int sel = ui.voiceCombobox->findData(current); if(sel >= 0) ui.voiceCombobox->setCurrentIndex(sel); + else + ui.voiceCombobox->setCurrentIndex(ui.voiceCombobox->findData("english")); + // TODO: Fall back to system language before the final "english" fallback. }