len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 21:22:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ata: Ensure that the bounce buffer is minimum 32-bit aligned

Browse source 
Basically, if STORAGE_ALIGN_ATTR isn't defined, define it to be
sizeof(uint32_t) in the ATA code.

Change-Id: I13de61788cb71e3e8d3a956ab5f2e251471ce76d
This commit is contained in:
Solomon Peachy 2024-11-09 16:36:06 -05:00
parent d36ef610c2
commit 120906dc8b
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/drivers/ata-common.c
View file

@ -28,6 +28,10 @@
#define __MAX_VARIABLE_LOG_SECTOR SECTOR_SIZE #define __MAX_VARIABLE_LOG_SECTOR SECTOR_SIZE
#endif #endif
#ifndef STORAGE_ALIGN_ATTR
#define STORAGE_ALIGN_ATTR __attribute__((aligned(sizeof(uint32_t))))
#endif
struct sector_cache_entry { struct sector_cache_entry {
unsigned char data[MAX_PHYS_SECTOR_SIZE]; unsigned char data[MAX_PHYS_SECTOR_SIZE];
sector_t sectornum; /* logical sector */ sector_t sectornum; /* logical sector */

3
firmware/export/config/ipod6g.h
View file

@ -203,9 +203,6 @@
/* define this if we want to support 512n and 4Kn drives */ /* define this if we want to support 512n and 4Kn drives */
//#define MAX_VARIABLE_LOG_SECTOR 4096 //#define MAX_VARIABLE_LOG_SECTOR 4096
//#define STORAGE_NEEDS_BOUNCE_BUFFER
#define STORAGE_WANTS_ALIGN
#define HAVE_HARDWARE_CLICK #define HAVE_HARDWARE_CLICK
/* Define this if you have adjustable CPU frequency */ /* Define this if you have adjustable CPU frequency */

5
firmware/export/system.h
View file

@ -335,6 +335,11 @@ static inline void cpu_boost_unlock(void)
#define MEM_ALIGN_DOWN(x) \ #define MEM_ALIGN_DOWN(x) \
((typeof (x))ALIGN_DOWN((uintptr_t)(x), MEM_ALIGN_SIZE)) ((typeof (x))ALIGN_DOWN((uintptr_t)(x), MEM_ALIGN_SIZE))
/* Bounce buffers may have alignment requirments */
#if defined(MAX_PHYS_SECTOR_SIZE) && !defined(STORAGE_WANTS_ALIGN)
#define STORAGE_WANTS_ALIGN
#endif
#ifdef STORAGE_WANTS_ALIGN #ifdef STORAGE_WANTS_ALIGN
#define STORAGE_ALIGN_ATTR __attribute__((aligned(CACHEALIGN_SIZE))) #define STORAGE_ALIGN_ATTR __attribute__((aligned(CACHEALIGN_SIZE)))
#define STORAGE_ALIGN_DOWN(x) \ #define STORAGE_ALIGN_DOWN(x) \