devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
24308 commits 1 branch 143 tags 210 MiB
Commit graph

1153 commits

Author SHA1 Message Date
Jonathan Gordon
466e5d9aa4 2 new tags for the base skin. 
%Lt - the title text for the current list
%Li - the icon number. Same order as the CustomIcons list, except the first icon is the "no icon" icon.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24917 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 03:45:41 +00:00
Teruaki Kawashima
51bc09e88e Quickscreen: add more check for case that qs item is not set. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24901 a1c6a512-1295-4272-9138-f99709370657
 2010-02-25 06:01:53 +00:00
Jonathan Gordon
31fb4f6ff6 Change how touchscreen regions work slightly... "It modifies the behaviour of touch buttons to be more similar to the way gui buttons operate in desktop applications. Upon a touch press event, the button at the touch position is armed. Upon a touch repeat or release, the button at the touch position is triggered only if it is armed. Upon release (and wps entry), all buttons are disarmed. E.g. when you touch press on an empty area, then while pressing drag your finger on a button, then release the button, the button is not triggered." 
Author: Jens Theeß 
Flyspray: FS#10982


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24876 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 06:19:25 +00:00
Jonathan Gordon
6c4b80c67b make the parser spit out filenames of images it cant load 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24875 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 06:15:55 +00:00
Jonathan Gordon
0acb38b61c some minor changes to checkwps, shouldn't change anything 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24874 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 05:58:16 +00:00
Tomer Shalev
9d268d796c Quickscreen: Hande case where not all quick settings are defines 
This happens in Archos Recorder, see quick_screen_f3(), which caused crash
(FS#11037), due to top item not defined.
The commit explicitly sets items[QUICKSCREEN_TOP] to NULL, and also draws an
arrow only if the item is defined.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24871 a1c6a512-1295-4272-9138-f99709370657
 2010-02-23 21:30:16 +00:00
Teruaki Kawashima
d151371836 correct checking size in function get_image_filename. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24844 a1c6a512-1295-4272-9138-f99709370657
 2010-02-22 06:00:49 +00:00
Frank Gevaerts
84a4a1d5cc statusbar_position should also return enum statusbar_values if it's a macro 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24833 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 22:05:32 +00:00
Thomas Martitz
a31624e76e Fix the mechanism to fail to parse skins if images fail to load and fix having no backdrop at all (neither %X nor backdrop setting, DancePuffDuo was broken). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24814 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 19:29:33 +00:00
Jonathan Gordon
f85103e8f2 remote multifont fixes. it shoud be working again (blame AlexP! he made me break it last week!) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24812 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 19:10:09 +00:00
Teruaki Kawashima
dafcd1470a remove unused fields from struct gui_synclist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24807 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 13:32:52 +00:00
Jonathan Gordon
eca85ac327 make sure font fd's get closed when a new skin is loaded 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24803 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 02:53:50 +00:00
Thomas Martitz
c19e53654b Playlist Viewer Changes to bring consistency: 
- combine its two context menus to one and
- make the ACTION_STD_MENU go to the main menu as it does in all other screens
- call playlist_viewer() via root_menu to reduce call depth and to be consistent with other screens (and for the above changes to be more flexible w.r.t to the following screen)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24791 a1c6a512-1295-4272-9138-f99709370657
 2010-02-20 19:06:39 +00:00
Tomer Shalev
516d1264f8 WPS: Use helper local variable instead of its value (no functional change) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24789 a1c6a512-1295-4272-9138-f99709370657
 2010-02-20 13:26:50 +00:00
Jonathan Gordon
ccd50dd2d7 and actually fix multifont on remote lcd targets also 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24780 a1c6a512-1295-4272-9138-f99709370657
 2010-02-19 23:54:36 +00:00
Jonathan Gordon
90d9e66920 fix possible out-of-bounds error on remote lcd targets if they try loading a font to id==2 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24779 a1c6a512-1295-4272-9138-f99709370657
 2010-02-19 23:49:17 +00:00
Jonathan Gordon
45a181d8fc allow integer sound settings (bass, volume, etc) to be used with conditional %St. "%?St|name|<min|min+1|...|max-1|max>" 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24745 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 07:04:16 +00:00
Jonathan Gordon
7dfd594cca fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24741 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 02:37:58 +00:00
Jonathan Gordon
3cb735ef39 basic alignment support (%a|l|c|r|L|R) in the playlist viewer. no sublines so the whole line will either be left, right or centered. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24740 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 01:52:13 +00:00
Jonathan Gordon
f7ba156b27 change the %St tag so it only shows the filename of file settings, not the full path (i.e cabbiev2 instead of /.rockbox/wps/cabbiev2.wps) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24717 a1c6a512-1295-4272-9138-f99709370657
 2010-02-17 07:17:06 +00:00
Teruaki Kawashima
13035a48af scrollbar.c: Simplify code a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24694 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 13:38:30 +00:00
Teruaki Kawashima
d50c78c238 * surround member only used by charcells with #ifdef HAVE_LCD_CHARCELLS in struct scrollinfo in scroll_engine.h. 
* remove function prototypes which are not actualy defined.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24693 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 11:59:37 +00:00
Jonathan Gordon
877d378710 Reuse the backdrop buffers if 2 skins use the same backdrop (on the same screen of course) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24690 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 05:24:27 +00:00
Maurus Cuelenaere
5ea32cf05a WPS volume touchregion: fix reverse Y coordinate in portrait mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24649 a1c6a512-1295-4272-9138-f99709370657
 2010-02-14 15:31:19 +00:00
Jonathan Gordon
1c2aa35371 FS#10984 - multifont! 2 major additions: 
1) seperate UI font for the remote and main displays
2) allow individual skins to load additional fonts for use in the skin (Uo to 7 extra in this first version) see CustomWPS for info on how to load a font in the skins.

Code should always use FONT_UI+screen_number to get the correct user font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24644 a1c6a512-1295-4272-9138-f99709370657
 2010-02-14 06:26:16 +00:00
Maurus Cuelenaere
9ec0c1669c Touchscreen: fix scrollbar handling when it's on the right 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24635 a1c6a512-1295-4272-9138-f99709370657
 2010-02-13 15:53:10 +00:00
Teruaki Kawashima
1549b19d9e color_picker: a bit of rework for color_picker. 
* don't call display->getcharheight() so often, store the value to char_height and use it instead.
* replay title_height by char_height, they should be the same.
* fix spaces.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24595 a1c6a512-1295-4272-9138-f99709370657
 2010-02-11 14:18:31 +00:00
Teruaki Kawashima
93f9e7cbfb fix text scrolling handling in do_menu, set_time_screen and time_screen. 
Don't scroll text in time_screen(). the lines will be redrawn before scrolling statrs, so they don't scroll anyway.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24591 a1c6a512-1295-4272-9138-f99709370657
 2010-02-11 10:41:06 +00:00
Jonathan Gordon
f8aa88ba50 OK, this is hopefully the last sbs related fix. This one will fix the backdrop going garbage, and add a missing else which kugel spotted 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24579 a1c6a512-1295-4272-9138-f99709370657
 2010-02-10 04:53:04 +00:00
Jonathan Gordon
fd2fdc2d75 Fix FS#10983 - r24568 was just moronic. Sorry 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24578 a1c6a512-1295-4272-9138-f99709370657
 2010-02-10 04:19:50 +00:00
Alex Parker
3e4e67b408 Fix WPS backdrop drawing, as instructed by JdGordon. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24571 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 22:34:04 +00:00
Jonathan Gordon
9955e9a7df unconditioannly show the main/base skins backdrop when enabling the theme so plugins show the correct backdrop in menus 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24568 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 17:19:15 +00:00
Jonathan Gordon
54ca765769 fix red. these long #if's need to be changed to a single #define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24566 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 09:47:08 +00:00
Jonathan Gordon
7e6f124d4e revert r24478 and make the backdrop behaviour the same as it used to be (so when in the wps the sbs' backdrop will be fully disabled). Also changes the API back to having to manually set the current backdrop. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24565 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 09:38:03 +00:00
Jonathan Gordon
dc3f746af2 fix FS#10957 - the wps backdrop is always shown in the "create bookmark?" ask screen (Actual fix is to always enable the theme in the yesno screen) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24560 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 05:11:32 +00:00
Jonathan Gordon
5513c30e34 make all the RTC tokens in the skins be useable in conditionals (I dare anyone to use %cY though :D ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24526 a1c6a512-1295-4272-9138-f99709370657
 2010-02-05 23:58:53 +00:00
Jonathan Gordon
0a16a99a69 fix a bug where the backdrop from the sbs is displayed on scrolling lines in the wps when the %wd tag is not used. 
I'm not crazy about this commit and maybe a better solution would be to outright disable the sbs backdrop when in any skinned screen. This then means backdrops go back to needing special handling (i.e they arnt "free")



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24478 a1c6a512-1295-4272-9138-f99709370657
 2010-02-03 07:03:48 +00:00
Jonathan Gordon
bb86299b81 make sure skins always draw with their backdrop, otherwise the backdrop only changes on a full redraw which usually ends up being in the wrong order 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24435 a1c6a512-1295-4272-9138-f99709370657
 2010-02-01 04:47:19 +00:00
Jonathan Gordon
c0e2d9fe1b Fix RTL list handing when not loading a custom base skin. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24401 a1c6a512-1295-4272-9138-f99709370657
 2010-01-31 03:08:44 +00:00
Jonathan Gordon
4c514b9d94 really the last of the red this time 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24370 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:39:08 +00:00
Jonathan Gordon
03ab592c9c bugger, too tired, didnt mean to commit this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24369 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:26:14 +00:00
Jonathan Gordon
ae91e8b693 fix the last of the red... note to self, fix backdrop.h! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24368 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:25:24 +00:00
Jonathan Gordon
349bf08ed1 fix reds 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24367 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:13:40 +00:00
Jonathan Gordon
eee5423fe1 skin rework (FS#10922) notable changes: 
- simplify the setting/skin relationship. settings are used as the fallback if it's not specified in the skin
- backdrop buffers are now in the skin buffer (which has also increased slightly to accomodate 1 backdrop for each skin and 2 full colour screens for bmps (up for 1.5))
- if no %X is specified in a skin then the backdrop setting will be used. use %Xd to explicitly disable a skin from displaying a backdrop
- the base skin can now specify a backdrop.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24366 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 07:52:13 +00:00
Jonathan Gordon
6f0f98da1d Fix remote backdrop crashes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24357 a1c6a512-1295-4272-9138-f99709370657
 2010-01-28 06:54:37 +00:00
Thomas Martitz
e18e806930 Fix yellows 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24352 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 20:45:42 +00:00
Thomas Martitz
feb3a261c7 Fix multiscreen handling of the viewportmanager. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24351 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 20:34:51 +00:00
Jonathan Gordon
2565389402 futile attempt to keep the ondioSP rombox working. This will almost certainly be the last release with it. (The backdrop API is chaning very soon after release so this is no big deal) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24340 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 06:47:56 +00:00
Thomas Martitz
e8ae70a382 Fix wps showing parts of the main backdrop in some circumstances. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24336 a1c6a512-1295-4272-9138-f99709370657
 2010-01-26 21:29:08 +00:00
Thomas Martitz
5629d551d7 Accept the last patch FS#10797 with a few changes by me (fixing side effects and adding the new backdrop_hide() to the multi screen api). It changes the hide_bars parameter to mean hide_theme. 
This makes plugins show the menu backdrop in their backdrop so that they don't look like crap if you have an sbs and look more integrated. I've test about all plugins and all work fine.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24335 a1c6a512-1295-4272-9138-f99709370657
 2010-01-26 20:14:42 +00:00