Elements from the SBS would disappear after
softlock, for a WPS that displayed an SBS,
if lock notifications were enabled.
If SBS isn't used, the request doesn't
result in any immediate action.
Change-Id: I7f5e8874f4eade6f504b6b3748c9644529587bb2
Prevents flashing an outdated backdrop when moving
from WPS to SBS, if both were using the extra
frame buffer (i.e. both used background viewports),
without having to update the SBS first. I think,
this is actually what we want, rather than commit
c1222d65e2, which attempted the same thing.
Change-Id: Iffc7fe2d351ebdf21a4e7629aba93641c0d30b50
The backdrop layer for the WPS was redrawn
before returning to the SBS, resulting in
unsightly visual effects such as album art
(drawn on the backdrop) losing a frame that
was drawn in the foreground.
Change-Id: If5bb1ba83d79d6d1f637e06f9cc5eab3b97d5906
This mirrors the behavior of idle poweroff,
which inhibits shutdown as long as a charger
is plugged in, even if a device is capable
of powering off while charging.
Since usb_inserted() already checks for USB_POWERED,
certain devices with the ability to power off while
charging, already exhibit this behavior when using
the sleep timer anyway.
Change-Id: I35ed4b542a8a4df06a34395c85f4d37fc1d2ce53
Trying to save a current playlist associated with a
file that doesn't exist anymore, is likely to result
in a panic.
+return to keyboard picker after
complaining about missing dir.
Change-Id: I00ea0b08521d4a4503243d636af01252119939bc
Previously logging just showed that the file was
passed to the function without any indication that
the parsing failed
Adds status strings to record failure to open, missing parser, parser error
Change-Id: I5234153464bab9a5f9fb765d5e1cfa59dfe0ebfe
by checking string len we can cache the USB hid mode strings
I guess if the user doesn't have enough glyphs they might still
might not get the whole thing but this appears to work with
50 glyphs and the referenced russian language selected
remove call to GUI_EVENT_ACTIONUPDATE it is now counterproductive
Change-Id: Ica96ed39c7d002fde2d1888e78d2ea18e7c1d61a
- Reverse order of prev/next buttons in html manual
- Rename "Playlist Catalogue" to "Playlists"
- Update order of menu items in "Playlists" context menu section
- Add "View Album Art" to "WPS Context Menu" section
- Adjust wording in "Playlists", "Basic Controls/Concepts" and
"Database" section
- Fix: Playlists are saved to root directory (not cwd) if no path
provided
- Fix: "Recursively Insert Directories" applies to all playlists,
not just the current one
- Fix: Update description of "Create Playlist" option
- Generally refer to "current playlist" instead of
"dynamic playlist" and remove reference to "on-the-fly playlist"
Change-Id: I200d19c5fb10f1f0ddb7d993827c90be4a7402b9
Present user with a prompt, so that they don't
have to manually execute "Update cache" from
the settings menu after a database update
Change-Id: Ie2157f04329e8ffc10afbeb047486fe4b0b70bcf
mikmod uses WPS_VOLUP and WPS_VOLDOWN to scroll down and up
respectively, which works for the ipod clickwheel, but results in
inverted scrolling for everyone else. Correct this for all non-ipods
and correct the manul (which actually didn't report this either)
Change-Id: I5a84512dfbf068ca5c4206f4362185d4d7e5c9fc
Attempting to save a playlist to a dir that does
not exist would make playlist_save panic.
https://forums.rockbox.org/index.php/topic,55241
Change-Id: Ibf55255949782315e997733b519c590ac53221a2
try #2 at this
if there isn't enough data remaining to fill the columns
then don't read any more data
looking at the blame for this driver it had similar logic originally
But really on native this is just extra overhead so..
Ifdef out for native
Change-Id: I105dea1f7adc0448f345b268fcfa8574333132a9
When the 'List bookmarks' button or hotkey was
pressed, while a dynamic playlist was playing,
bookmarks from the root dir were displayed, if
any existed.
Change-Id: If104ad4b717fd188174069457deb27d21399b9bb
1-bit vertical displays overread the buffer due to the way the
packing works, this isn't the hottest path anyway but
we can check if height <= 8 and make stride 0 so the dummy data
gets the beginning of the data instead
Change-Id: I88ab4dc37bfd2d680d125f964beafe0ddfb00645
Matches 'Playlists' context menu, by
putting "Save Current Playlist" next
to "View Current Playlist"
Change-Id: Ie1d7a6bf8d5acdb830db44a2c4d3ed2adc17b878
Make "View Current Playlist" option more
accessible by moving it into the spot of
the 'Create Playlist' option, which
currently appears first in the context
menu, and is thus automatically selected
Change-Id: I28de5d7ad5be9bee79578ea7255a96aa72fafd2f
Put Sort command as first entry into main menu,
and immediately exit menu after sorting has changed,
to allow quicker adjustments than before.
Move commands to update or rebuild the cache from
Settings into main menu for improved discoverability,
and since they aren't really proper settings anyway.
Add 'Display' submenu to Settings which now houses the
following more 'esoteric' options that are likely to
need only infrequent adjustments:
- Backlight
- Display FPS
- Spacing
- Center Margin
- Number of Slides
- Zoom
- Resize Covers
Change-Id: I5bb3ee922cb870f9b6db9bd6ac9480d49f5decf3
You were asked to restart the plugin, before
PictureFlow would rebuild the cache after
selecting the menu option for it. This patch
eliminates the need for leaving the plugin, and
PictureFlow will rebuild its cache immediately.
Change-Id: I47ec78339fdc91efd42cd7850829256417682eae
When the Playlist Catalogue first appeared in the main menu
in 2011 (FS#11808), the 'Playlists' menu item was renamed
to 'Playlist Catalogue' which seems more verbose than is
necessary these days.
Since we don't have a 'Playlist Catalogue' menu item in the
onplay menu anymore, either, LANG_CATALOG can be eliminated.
Change-Id: I7f38b0847e9b982506371f4a4b473d1fb2551ad0
When a line is over a selected length bi-directional scrolling
is disabled.
In non bidir scrolling the string is copied to a buffer twice with
a space between "scroll text" + " " + "scroll text"
this is to allow scrolling the line in the forward direction
with minimal extra logic
Note: that is the ONLY direction it is equiped to handle
In the USB screen I observed while switching through the different modes
that sometimes the text was corrupted
turns out you can still have scroll->backwards set to true
which causes offset to go negatve but we never check if offset < 0
in non bidir scrolling mode and happily continue with ever more negative offsets
Change-Id: I210f7880be953d3cc42469828a7ca5fc2b2ab96f
- Skip superfluous "Wait" splash before displaying
index progress
- Display current step that the progress bar pertains to
- Exiting the "Confirm Quit" screen in order to continue
indexing was *extremely* fiddly because of picked-up
button events that would often immediately return you
to the same screen instead of getting you out of it.
This should behave more sanely now. Plus, you should
only see the Quit confirmation screen as a result of
pressing Menu or Cancel now (instead of touching the
scroll wheel for example).
- PictureFlow was unresponsive while removing duplicates
- A Cancel action initiated by the user isn't treated
as an error anymore, nor is a message displayed after
user has already confirmed their intention to quit.
- The plugin doesn't return errors anymore if the user
has already been presented with an error message, to
eliminate redundant splashes, delays, and an unwanted
return to the main menu
Change-Id: I255b8f760ccb0acdfddcacbc7d8a1b17b063e53e
Make the suggested playlist filename for special
entries such as "[Random]" or "[All Tracks]" a
bit more descriptive, by mentioning the current
table as well, e.g.:
"The Beatles [All Tracks].m3u8", instead of just
"[All Tracks].m3u8"
Change-Id: I43d9386c06081540cdcae715afc0b0351857633d
moves shutoff and disk safe to end of file
add warning
comment out shutoff and disksafe level as further protection
Change-Id: I1723b2ae6b2bd7fd359dc7dfcc8f1958d97673fc
lua has some include scripts for interfacing with rockbox
locally these appear to be generated properly by the lua make file
However the buildserver appears to not copy them over
add a copy loop for lua_include in then buildzip script to ensure they get copied
Change-Id: I8d2a4447a1496a53a16cec6e51d453cb60c2d6e5
the YPR1 apparently can do voltage or percent measure
I'm pretty sure its missing logic for disksafe and shutdown,
perhaps the device takes care of it for you?
hopefully someone with the device notices the issue
(perhaps due to a older battery needing capacity tweaked)
Change-Id: I79d3927fa8b154ba231aa6894de7920a4e4dd4c7
when battery_bench is run
exports a file in the rockbox directory called 'battery_levels.default'
if the user wants their own levels they can rename the file battery_levels.cfg
and it will be loaded at boot
some minimal error checking is performed prior to using the values
added manual entry
Change-Id: Ia0126faced0c7229fcf8385a1bcb584b5a9dc378
The default status bar is sized for SYSFONT, so this made the status bar
slightly taller.
Unfortunately this broke a bunch of themes that didn't include a custom
status bar and had hardcoded assumptions about the height of the default.
While those themes should not be making those assumptions, we don't
yet have a straightforward way to deal with it. So while we try to figure
out a better path forward, revert this.
Change-Id: I2cd6f64be5f405906a097ee0a33391e03bf1804d
