I think with the recent refactoring we should be able to put mp3entry
on the stack
it should be moved up a level anyway
Change-Id: Idd2af598c48545e3dbc774279b5d2b264012805e
rather than a function call for each qs item along with the data
for those calls in the switch for get_token_value()
it makes more sense to just have the qs_token function
handle all of the logic
Change-Id: I3b3072496611fc2c536eec33c7cdf9fb2ec67ee0
clean-up the switch a bit by putting rtc code in its own function
move the id3 tags to the default branch and only read id3
if its actually needed
Change-Id: I0a6fe9aea646defcfdda731c4c963977173c4133
%ss did not check for the size of the resulting string before
copying it to the buffer
%ft has a search text mode
Change-Id: I1321681c249251aafe0e39bcc510b9e81f0cd0d3
%ft(filename,search_text)
finds a line beginning with search_text strips search_text and returns
the remainder of the line
Change-Id: I06fe029b89aa60e4dbf34c039d180c75213519a4
in testing this slightly speeds up any of the draw routines using fg or bg
and slightly slows down the ones that don't
being that these are already faster it serves to bring them closer in
ops per second
.. and slightly speeds up the most general case DRMODE_SOLID
Change-Id: I4ea4898354e8bc9dfa7e96f188108ca77ea0aca9
if no params are given these three supply a default
it wasn't being applied since it was guarded by the else{}
Change-Id: I2966fd7d8daa695d8b214461749c93b3e7883e51
we calculate the size of the scrolling line every scroll update
the line data doesn't ever change without a call to update
instead calculate the string size when the line is updated
re-use this value while scrolling the line
in theory the current font could change but in practice
I can't find a case when the string size needs to be updated
that the scroll engine isn't already updating the line
if this is later an issue we can recalculate the stringsize each time
the line is finished scrolling which still saves quite a few calculations
Other:
I don't think we have any targets with pixel counts exceeding 65535 pixels
where unsigned short stringsize will be an issue
Change-Id: I83d6374377ed648d9a320d4fd69f9d6a17095b0c
On MacOS, gcc is a symlink for clang.
Patch gets rid of the warnings produced by clang,
when it is set as HOSTCC, and fixes voicetools
compilation on MacOS when calling make voicetools
from the simulator directory.
lua rb_defines_helper:
format specifies type 'int' but the argument has
type 'long'
codecs: opus / speex (LOGF):
format '%ld' expects argument of type 'long int',
but argument 7 has type 'off_t'
gigabeat:
variable 'size' set but not used
rdf2binary:
a function declaration without a prototype is
deprecated in all versions of C
rbspeexdec:
passing 'unsigned char *' to parameter of type
'char *' converts between pointers to integer
types where one is of the unique plain 'char'
type and the other is not
hmac-sha1.c
defining a type within 'offsetof' is a Clang
extension
Change-Id: I90539906698868f9589650585d865aee9f7e8539
configure:
Ensure Werror option doesn't get lost when simcc resets GCCOPTS
uisimulator.make:
Remove ignored duplicate SIMLIB on Darwin
codecs.make:
Eliminate some redundancy
Change-Id: Ieee6f677fd22666cb58aa6fe53eabdc0b0f8c190
this is fallout from allowing a scroll item redisplay timeouts
prior to eb3e5eb '[Feature] skinengine subline timeout hide line for n seconds'
the behavior could be seen sparingly
after we now have an alternator front and center with the next track scroll
unfortunately this results in strings never scrolling to completion
fix:
if the current line hasn't changed and we are not doing a
full screen refresh, don't invalidate the scroll viewport
(the scroll engine will still handle the user data changing
if that actually occurred)
Change-Id: I10d4b8a05caa28de617dc6454520ce5426d69532
rather than reset the scrolling lines in list_draw()
when scroll_all = true
allow the scroller to take care of stopping lines
after the offset is known
this pretty much entirely the debug menus
Change-Id: I7069e0634d32b5ad8f92c294c5caf85373a7d480
This makes it possible to reuse the SysCfg reading logic in other places.
Tested on ipod6g (normal + bootloader).
Change-Id: Iae6de2ee671bce4edb0153d26c57579ad47d0335
Tested on ipod6g. No changes besides a text string.
This is a part of the large iPod Nano 3G and iPod Nano 4G support patch.
Change-Id: I3e527f3e36ab12682a54fc34c40d1ae0c2a7c797
A new flag S5L87XX_DEVELOPMENT_BOOTLOADER is introduced, to replace some of the bootloader functionality with debug/development menu. Not intended for end users, so it's not enabled unless explicitly specified when building
No changes to the binary if the new flag is not enabled.
Bootloader with the flag enabled boots on ipod6g.
This is a part of the large iPod Nano 3G and iPod Nano 4G support patch.
Change-Id: I3f28c94b4c1e29f3635285c7f0fd24a622a80c54
unless lcd_update() is called the sim doesn't update scrolling
you CANNOT call it from the scroll thread its simply ignored
I suspect this has something to do with where the call to render
originates as thi is the only thing I can think of besides
a call to disable the render
see demos/rb_info > paths -- observe the lack of scrolling
see any menu in a plugin that exceeds screen width
Change-Id: Ic14dee4a34de29479d739e6a280d6cf1cc283719
Extend functionality for displaying info in fullscreen
to folders or files that aren't audio tracks (e.g., to
display the full length of a file name)
Change-Id: I73617e2fd7c291a3c49ddd1b108e418cf069d179
Comments are converted to UTF-8.
Strings which are part of executable code are converted using C-string hex literals. A comment with the intended UTF-8 character is appended to such lines.
The "c"-looking character in mpa.c was actually a small cyrillic "s" (i.e. "с").
Change-Id: If3a889080ef60b8bf756ad9ada38baede93ce35b
Comments and notes are converted to UTF-8. Already broken multibyte characters are fixed using common sense.
This patch contains no code changes.
Change-Id: Ia511ab84936cb2495ac17309493a9b98727a7902
Playlist Viewer falls back to splashf if there is not
enough plugin buffer space left for running the
view_text plugin .
Change-Id: I418731018b03f396270b68e5e2d2e69635df1af0
Mostly useful for reading comments
WIP as it currently works only from WPS. Doesn't work from file browser(see https://gerrit.rockbox.org/r/c/rockbox/+/5999). Also breaks playlist viewer if called from there. Not sure how to handle it properly in all cases and not currently planning to work on it
Change-Id: I441eb9c6b3fe50f58436111d83bc98a25841d656
...On non-multidrive targets it will always evaluate to true because
it effectively ignores the argument passed in.
Instead use 'x < NUM_VOLUMES'
Fixes regression introduced with a41a001258 on non-multivolume devices
Change-Id: I1a620af113c87cf3227ef8b40d0b51b2600cd816
This driver decouples the LCD interface from the target-specific LCD parameters. It makes it possible to reuse most of the ipod6g driver code on ipodnano3g and ipodnano4g.
No difference in the produced binaries for ipodnano2g (normal and bootloader).
Tested on ipod6g (normal and bootloader).
This is a part of the large iPod Nano 3G and iPod Nano 4G support patch.
Change-Id: I7ce198ed3d5a8b58759951e2d67788cbf9781dc8
(L1033 + L1170)
As of commit f3e5ced, tags will be parsed
unconditionally, regardless of whether
they've been filled already.
Change-Id: I7edd4b7131b33dba34f06ebe829ebdc00a138525
No difference in the produced binaries for ipod6g (normal and bootloader)
This is a part of the large iPod Nano 3G and iPod Nano 4G support patch.
Change-Id: Ib79c5539a317aae350d661ab23c181471ee38abb
No difference in the produced binaries for ipod6g (normal and bootloader)
This is a part of the large iPod Nano 3G and iPod Nano 4G support patch.
Change-Id: I82943e91ba7e6764428f853f84799f0d54b700a6
Tested on ipod6g (normal + bootloader).
No functional change, no binary size change, the only difference is using r3 instead of r1 for the WDT_BASE address value.
Change-Id: I2ce2b7d987671cb4fcbbcdde574437b21a534da0
calculating inside a function makes it work
adding FORCE_INLINE makes warning reappear
anything else in bounds of the array asounds ok but has digital
distortion so pretty confident the code is right
Change-Id: Ibb2babe20b1d8a980f3e3fd19b4cddaaff9213a6
