1
0
Fork 0
forked from len0rd/rockbox
Commit graph

37224 commits

Author SHA1 Message Date
Solomon Peachy
01ec79663d ATA: Rework ata_isssd() slightly:
* If CF Timing mode is specified, treat it as SSD
   (some SD adapters don't report CFA supported but but report this,
    and _all_ microdrives seen do not report this)
 * If CFA compliant and CF power level 0, treat as SSD

Change-Id: Ia8c88b4636af9bae75fbd1c253d8b2b01bca6584
2024-07-16 17:35:53 -04:00
Solomon Peachy
942e013eac pp5020: Cache the result of the is_ssd check.
...So we don't look it up on every write.

Change-Id: I85b0abe5032a60588535b401cc719661601807ee
2024-07-16 17:35:53 -04:00
Solomon Peachy
27a0cda6ac PP5020: Unconditionally use stock PIO timings
The SSD detection heuristic is flawed, and when it fails
(due to very crappy CF->SD adapters) we end up corrupting things.

So let's give up a slight amount of performance on the original hard
drives (which are aging out anyway) in favor of guaranteeing safety.

Change-Id: Id92583a6b9ae6ec543b91b3e0f8f28b57ac38cb0
2024-07-16 17:35:53 -04:00
Solomon Peachy
9c53fa1b0a pp5020: It's okay to use DMA reads on non-SSDs
Fixes a regression introduced in 4b423e21f6

Change-Id: Ief4a4a562840524b98ad5988999bac87586dec41
2024-07-16 13:37:14 -04:00
Solomon Peachy
a6f0044d40 Revert "ata: Use PIO0 when ATA_SET_PIO_TIMING is not defined"
This reverts commit 95d6c74627.
2024-07-16 13:26:49 -04:00
Solomon Peachy
95d6c74627 ata: Use PIO0 when ATA_SET_PIO_TIMING is not defined
If we have no way to tell the controller what timing to use, go with
the slowest possible speed.

Change-Id: I1ed3474d8bfecc08cfe4a9e7667f57775fef4d43
2024-07-16 11:47:43 -04:00
Solomon Peachy
9049d30da9 Add Evan Kenny to CREDITS
Change-Id: Ia349c73da59dff6f4da7f727d9bfcf298ed25fce
2024-07-13 19:08:22 -04:00
Evan Kenny
96f42a5646 skin engine: Add tags to display Quickscreen Items
A set of new tags for themes that allow them to display a quickscreen item's name or value like what is displayed on the default quickscreen.

There are 8 tags in total, 2 for each direction or "item".
One type of tag displays the setting name, while the other displays the setting's value.

All tags output an "ERR" string if no valid setting is found for that item.

Quickscreen Item name tags: %QT, %QR, %QB and %QL.
Quickscreen Item value tags: %Qt, %Qr, %Qb and %Ql.

Change-Id: Ia08ba5940e38065e051a0aefa2cff142c9e58684
2024-07-13 19:07:06 -04:00
William Wilgus
3891bcf3b9 [Revert] id3 title display playlist_viewer.c
reading the disk works fine for on disk playlist but
trying to read from the disk with the current playlist
becomes unbearably slow

removes the static playlist_track_info prefering the unused one
already on the stack from search_playlist()

Change-Id: I01b836b4fe46bb51ef6a28d5db6b3f9cdc7d1e51
2024-07-13 01:39:50 -04:00
Solomon Peachy
8753c41b2e tools: Fix the tools/release/manuals.pl script
It was looking for the versioned pdf filename, which it
then renamed immediately anyway.

Change-Id: I3173fde3cdde56b4bf0b95f9d08b2b8468381972
2024-07-12 12:08:37 -04:00
Solomon Peachy
6a6fa0702a manual: Just call the PDF build artifact rockbox-manual.pdf
...Instead of renaming it to include the player name and version.  This
was the _only_ build artifact treated that way, and I can't find an
explanation of why.

Change-Id: I13f1a43ddc1f2ac3183f57892cf068e8ed16f37d
2024-07-12 11:57:14 -04:00
William Wilgus
da8d6152ad playlist_viewer reduce bss usage
the extra title pointer and alignment adds around 1k to the bss area
since we already have a pointer to track->name we can just save an offset
for the title data

Change-Id: I3a19857631d70276134bcc97940824a3e2f80e4a
2024-07-12 10:55:24 -04:00
Solomon Peachy
8801ed0824 manual: Fix html manual build on MPIOHD300
Change-Id: I7c2e9c741a9dc65c5576db370808cc4b92fab46d
2024-07-12 08:52:24 -04:00
Solomon Peachy
81c8be1568 manual: Fix html manual build on MPIO HD200
Change-Id: I815ab064b2175cb5cb54ebf534746f288d7269f5
2024-07-12 08:52:24 -04:00
Solomon Peachy
fec9f69ac8 agptekrocker: Fix manual build due to missing Quickscreen enter/exit
(Required adding a std quickscreen context keymap!)

Change-Id: Icd6bd656d826ea3be73b025242d2405f489e3eeb
2024-07-12 08:52:24 -04:00
Solomon Peachy
f8e602ecfd manual: Fix iHP-H10 HTML build
Change-Id: I824eb8254339d50eb9a99897f70a871e8d51b134
2024-07-12 08:52:24 -04:00
William Wilgus
a2747a1bd1 Playlist_viewer.c clean-up and a bit of optimization
Change-Id: I049020ab5da0b3b3c6495a4be1bc8f296d472e01
2024-07-12 00:35:32 -04:00
William Wilgus
bdb5bf1511 [Bugfix] playlist_viewer.c
had the conditional backwards

changing display settings now reloads list

Change-Id: Iea8f6bb1c7323b316a386135a6ccb192b214f6db
2024-07-10 17:07:03 -04:00
Solomon Peachy
43dfa7d084 opus: Re-add IRAM hints to some constant tables
Was accidently disabled in 14c6bb798d
(in January 2019)

See 8e8671a73e for the benchmarks.

Change-Id: I3d558f8cfc041a14d0a1e55da3b042c7d01089e8
2024-07-10 09:23:33 -04:00
Solomon Peachy
67b5fa06d5 opus: Re-enable Coldfire ASM optimizations
Was accidently disabled in 14c6bb798d
(in January 2019)

(Had to make a minor change due argument differences)

Change-Id: If7c128cdeaa9ed82b2b33de1b75ca7cc4a95abdd
2024-07-10 09:23:33 -04:00
William Wilgus
fdbaf7df59 [Feature] playlist_viewer id3 title display
Not sure this is a great idea from disk and battery standpoint
but there is no reason you can't..

using the name buffer to fill title data
prevent hitting the disk for each screen scroll

add get_metadata_ex to allow flags
 METADATA_EXCLUDE_ID3_PATH
  prevent copying the filename to the ID3 struct
 METADATA_CLOSE_FD_ON_EXIT
  instead of seeking to the beginning the file is closed before
  get_metadata returns

add logic to allow a invalid fd to signal that get_metadata
should open and close the file within its call

bugfix per Chris_s don't use the tagcache for the trackinfo

Change-Id: Ic7a595b39a8d7a57f975312bc9c8bb4111f22a88
2024-07-09 01:40:02 -04:00
Solomon Peachy
07cf874191 simulator: Fix one set of errors, a new set crops up.
Change-Id: I86d6cbee8eec52f04e760b45ab849249ae7162c4
2024-07-07 16:45:48 -04:00
Solomon Peachy
c51a9821e7 rk27xx: Fix simulator errors brought upon by HAVE_MULTIDRIVE but not HAVE_HOTSWAP
Change-Id: I0171d01dfffbb936e8041c0e2fc5207c620ddce3
2024-07-07 16:02:38 -04:00
Solomon Peachy
60c3fdbc11 More red fixes:
* hostfs_removeable()/present() needed IF_MDVOID() in their prototypes
 * SIM_EXT_INSERTED/EXTRACTED are gated by HAVE_HOTSWAP

Change-Id: Id8c688f3538db99586a4f5062c83466374451883
2024-07-07 15:40:27 -04:00
Solomon Peachy
5a2bd580cd Hopefully fix the last of the stragglers.
* xDuoo X3 fix some warnings due to an incorrect #ifdef
 * stub storage_removeable() and storage_present() for non-HOTSWAP builds
 * sim_trigger_external() is gated by HOTSWAP, not MULTIDRIVE

Change-Id: I38f14fdfeba13957899c378051d49afc2e8245e5
2024-07-07 15:13:53 -04:00
Solomon Peachy
1528b44349 More red fixes
Change-Id: If22cdb286edac47b08b158bee6910ba7a539b041
2024-07-07 14:47:07 -04:00
Solomon Peachy
520875ff00 simulator: Fix numerous latent issues
Interactions between HAVE_MULTIVOLUME, HAVE_MULTIDRIVE, and HAVE_HOTSWAP

Change-Id: Ia93792d6a778bf1e5b9bfbc46d982bbba7544651
2024-07-07 13:18:17 -04:00
Solomon Peachy
dc364e44ef Disable HAVE_MULTIVOLUME for bootloaders
Multivolume support is only necessary if mounting multiple volumes
simultaneously, which the bootloader won't do.

Change-Id: I725061dd2aa47abe7652b0d27258dd3af821c913
2024-07-07 12:43:10 -04:00
Solomon Peachy
f37b5a8349 Fix the remaining red in red from ea80d1cc9ca
Notably:

  * double-paste in ihifi760 config.h
  * jz4740 ATA & SD drivers used MULTIVOLUME instead of MULTIDRIVE
  * Simulators implicitly rely on HAVE_HOTSWAP

Change-Id: I44fc7f98f0f6df366f016567c330f87e9f3ca6a6
2024-07-07 12:29:19 -04:00
Solomon Peachy
181fe7530a Fix most of the (extensive) red in ea80d1cc9ca
Change-Id: Ie494df80caa222423a52977031920d54bd058c3c
2024-07-07 12:05:18 -04:00
Solomon Peachy
ea80d1cc9c config: Change default HAVE_MULTIVOLUME settings
* HAVE_MULTIDRIVE implies HAVE_MULTIVOLUME as the latter is always
   removeable storage
 * SD storage implies MULTIVOLUME
 * ATA storage (with HAVE_LBA48) implies MULTIVOLUME
 * Replace HAVE_MULTIDRIVE && NUM_DRIVES == 1 with HAVE_MULTIVOLUME

Since SD and ATA can exceed 2TB, we need multiple volumes to fully
utilize available storage with FAT32.

In practice I believe this only affects the ipod devices.

Change-Id: Ia597770948b0e2b47630f7264ad34f225a33a640
2024-07-07 11:35:04 -04:00
Solomon Peachy
af1eddb6e9 release/voices: Update script to check for global POOL
...If it's already defined, don't override it.

And don't wipe its contents!

Change-Id: I83ca2ffbd443c1d9766f4a5662a5da5fccbaf3c5
2024-07-07 09:02:27 -04:00
Solomon Peachy
7ea7112220 MAINTAINERS update
Largely consists of adding myself in a bunch more places, though
I did "volunteer" a few folks in some places due to their existing
and ongoing work.

The other noteworthy change is adding Alessio Lenzi as the Italian
translation maintainer.

Change-Id: Ia754ff6ff1174622b2e17c3e7449a9c55b3039b4
2024-07-07 08:12:42 -04:00
William Wilgus
e4ee8c8879 [Fix Yellow] file_op.c Bad DEBUGF statement
Change-Id: I22fa470599b0c22fae0bc5492eda38fd1e0c0b55
2024-07-04 13:01:36 -04:00
William Wilgus
b0dfcde2f5 [Cleanup] onplay.c fileop.c
clean-up a bit more
add/correct some comments

fix some error passing
guard delete path on PATH_TOO_LONG

add some cpu_boost

Change-Id: Icf179dd727271bdc61ab78400e10847222b9f858
2024-07-04 12:44:04 -04:00
Solomon Peachy
3e9ca6ec8e configure: Stray unquoted space in a sed expression
Should fix SDL builds where --static-libs are not present

Change-Id: I96056f3e4d9a4ae971ad2d9e792ba542478f331b
2024-07-04 10:38:49 -04:00
Solomon Peachy
5e13a1bb05 FS#13439: Fully updated Italian translation (Alessio Lenzi)
Change-Id: I2efba438f4c915af6b249776d663d4f5b41df17b
2024-07-04 09:56:50 -04:00
Solomon Peachy
30ef953393 configure: Fix 'make reconf' when win64 sim builds are enabled
Change-Id: I9d3c23dee58cb3b4edce7bfcc0429500ffe23e58
2024-07-04 09:48:02 -04:00
Solomon Peachy
961f8a0f56 configure: if we can't link SDL statically, drop -static from the cmdline
Fixes building windows simulator builds on Fedora systems

Change-Id: I1e17e8f2f395a0298fc9d3d7e03c621d23208221
2024-07-04 09:48:02 -04:00
Solomon Peachy
e2fb4ecd5c xduoox3: Completely strip USB support out of the bootloader.
Change-Id: I7167e051a56a3be3c285c209b1c8fca7de251b09
2024-07-03 16:51:58 -04:00
Solomon Peachy
80b9127727 Revert "jx47xx: Rename crt0 'init' sections to 'startup'"
This reverts commit 83bb89d0b8.

...It breaks the jz47xx bootloaders.
2024-07-03 16:51:58 -04:00
Solomon Peachy
d0e47affa9 xduoox3: Script to patch a firmware image with a new bootloader binary
Change-Id: Ie4cfc34ea1d40ca660b8f23e7782d617b31d7ff4
2024-07-03 16:51:58 -04:00
Solomon Peachy
e55618d07a hosted: Minor corrections to the linux framebuffer driver.
* Query variable info _before_ mmaping the framebuffer
 * Sanity-check the resolution/bitdepth, and if it doens't match
   try to set it to what we want.

This is functionally a no-op.

Change-Id: I087ff81775d8f63bf7846b7fef19f6fc36c1cc84
2024-07-01 09:51:50 -04:00
Solomon Peachy
5f26f21ab2 samsungypr0/1: Minor improvements to framebuffer driver.
* Distinct error codes for all failures
 * Corrected some comments and error messages

The ypr0/r1 target should be switched over to the generic lcd-linuxfb
driver, but that will come later.

Change-Id: Idc3867a96db7e431847473708712f88dd2725a96
2024-07-01 09:50:33 -04:00
Solomon Peachy
311f27606c xrick: Fix build on RGB888 targets
Didn't realise they needed the same hand-holding as XRGB8888

Change-Id: I28274b7326747093ef94427b1ddbcb948c907a2b
2024-06-30 20:57:34 -04:00
Solomon Peachy
9b8cfd1bb3 FS#10959: Fix multiple bugs in brickmania (Matteo Italia)
- offscreen ball check;
 - "suicide button", with its documentation in the help (defaults to Down+Fire+Quit on targets that have DOWN defined, Fire+Quit held for some time for the others) ;
 - help screen made a little more clear (IMO) by underlining the key names;
 - help screen *code* made a little easier to handle, adding the last element number in the words array (this eases the formatting specified in the other array);
 - now the game does not delete the savefile after it loads it, but only by request (to do it a new menu entry was added); so, now "Quit without saving" will actually leave you to the state of the last savefile instead of resetting the game;

Change-Id: If3eeabada1566dcd4a9473d3d1e361d4921e4005
2024-06-30 20:32:38 -04:00
Solomon Peachy
eacb4daa2d More xrick-related cleanups
* Correct broken CREDITS file causing HTML manual build failures
 * Fix warning on iAudio M3 and MPIO HD200
 * Fix XRGB888 pixelformat builds, hopefully correctly.

This should bring the board back to green.

Change-Id: Ia7d54641d37db19d4cee3b5d9f5d8ab1567ac30b
2024-06-30 20:30:49 -04:00
Solomon Peachy
423350ec4d xrick: Fix various errors/warnings
* Piles of warnings in miniz when built with modern toolchain
  * Pointer arithematic error in PRNG
  * Casting between int and void * for file descriptors
  * Warning on non-color targets

Remaining:

  * Failure on XRGB888 LCDs due to issue with core LCD macros
  * Failure on interleaved greyscale LCDs (?)
  * HTML manual build failure

Change-Id: Ibf6d2c001ec8daf583731d5da15b86b5352773e7
2024-06-30 18:45:07 -04:00
Sebastian Leonhardt
102c374248 added xrick game
original xrick code by 'BigOrno' at:
http://www.bigorno.net/xrick/

Rockbox port, plus bugfixes at:
https://github.com/pierluigi-vicinanza/xrick

Further changes:

 * Additonal fixes from g#3026
 * Port to modern plugin API
 * Add Pluginlib keymap fallback
 * Support all >1bpp screens
 * Fix build warnings in miniz
 * Better error message when resources are missing

Change-Id: Id83928bc2539901b0221692f65cbca41389c58e7
2024-06-30 17:24:16 -04:00
Solomon Peachy
6f1e67e5e3 builds: Add an explicit 'simbuilds' list
It includes all targets that have a working simulator build.

 * All stable targets except those that are flagged as bad
 * All unstable targets that are flagged as good

Change-Id: Id0e20a10af72236c819077f919ee5cc168ebf14e
2024-06-30 16:25:58 -04:00