mirror of
https://github.com/Rockbox/rockbox.git
synced 2026-07-10 13:29:52 -04:00
Fix FS#13832 If the remote is already plugged in when Rockbox boots, it stays dead until you replug it. These remotes only send their identify packet once at power-up, so we never see it and then throw away all button events because lingo 0x02 was never negotiated. The OF doesn't care, so accept ContextButtonStatus from unidentified devices too. Stray bytes received before iap_setup() also made iap_getc() return false, which the serial driver takes as "sync found" and locks autobaud onto the wrong bitrate. The ghost clicks come from the repeatbtn handshake. A held button resends its down event every 30-100ms and each one re-armed iap_repeatbtn, which stalls handling of the following packet. So during a long press packets pile up, the event queue overflows, and the leftovers replay as keypresses after you let go. Skipping fires on button release which is why next/prev showed it the worst. Now repeatbtn is only re-armed when the button state actually changes, and iap_handlepkt() drains whatever complete packets are in the RX buffer rather than relying on one queued event per packet. While at it, fix two more things found along the way: the button state is now written in one go (the temporary BUTTON_NONE could be picked up by the button tick mid-update), and iap_rxlen is decremented when a frame is received so the overflow check actually does something. Tested on ipodmini2g with an A1018 remote. Change-Id: Ie18512e47d642fe6957fc010eaf79b6d2af4c070 |
||
|---|---|---|
| android | ||
| apps | ||
| backdrops | ||
| bootloader | ||
| docs | ||
| firmware | ||
| fonts | ||
| icons | ||
| lib | ||
| manual | ||
| packaging | ||
| tools | ||
| uisimulator | ||
| utils | ||
| wps | ||
| .gitattributes | ||
| .gitignore | ||
| .gitreview | ||
__________ __ ___.
Open \______ \ ____ ____ | | _\_ |__ _______ ___
Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < <
Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
\/ \/ \/ \/ \/
Build Your Own Rockbox
1. Clone 'rockbox' from git (or extract a downloaded archive).
$ git clone git://git.rockbox.org/rockbox
or
$ tar xJf rockbox.tar.xz
2. Create a build directory, preferably in the same directory as the firmware/
and apps/ directories. This is where all generated files will be written.
$ cd rockbox
$ mkdir build
$ cd build
3. Make sure you have mips/m68k/arm-elf-gcc and siblings in the PATH. Make sure
that you have 'perl' in your PATH too. Your gcc cross compiler needs to be
a particular version depending on what player you are compiling for. These
can be generated using the rockboxdev.sh script in the /tools/ folder of the
source.
$ which arm-elf-eabi-gcc
$ which perl
4. In your build directory, run the 'tools/configure' script and enter what
target you want to build for and if you want a debug version or not (and a
few more questions). It'll prompt you. The debug version is for making a
gdb version out of it. It is only useful if you run gdb towards your target
Archos.
$ ../tools/configure
5. *ploink*. Now you have got a Makefile generated for you.
6. Run 'make' and soon the necessary pieces from the firmware and the apps
directories have been compiled, linked and scrambled for you.
$ make
$ make zip
7. unzip the rockbox.zip on your music player, reboot it and
*smile*.
If you want to build for more than one target, just create several build
directories and create a setup for each target:
$ mkdir build-fuzeplus
$ cd build-fuzeplus
$ ../tools/configure
$ mkdir build-xduoox3
$ cd build-xduoox3
$ ../tools/configure
Questions anyone? Ask on the mailing list or on IRC. We'll be happy to help you!