mirror of
https://github.com/Rockbox/rockbox.git
synced 2025-11-09 13:12:37 -05:00
58462184d1
| with some code refactoring we can eliminate the static char buffer in get_full_path() I'm guessing making the functions recursive prompted the static buffer I don't see any reason we can't just pass the same buffer | During tested I noted failure after buffer was full -- splash added for buffer full notification added some logic to not add partial entries and try to find a | selected item that will fit in the remaing buffer ------------------------------------------------------------------------ While looking through the source I noticed a few potential pitfalls with the current code. Namely the stack allocated temporary buffer sized to setting_len. I also noted the rigid vect[32] with the timeless -- /* 32 separate folders should be Enough For Everybody(TM) */ and decided to make it a bit more robust The saved items are hashed with crc32 on all the paths and a hashed_len is kept to aid in the buffer full message before the user actually goes to save the changes (assuming they even get the message) In the old code, buffer might be the same since it ran out of space and didn't get their later selections the hashed_len could easily be turned into a way to get a needed buffer size as well for someone in the future just pass a really large maxlen I made get_full_path non recursive since it liked to blow the stack while embedded in all the other recursive calls making it a pain to debug (the real reason the buffer was static?) traverse first from the current folder to root mutating the parent pointers to point at the previous child next traverse back to the folder unmutating & taking names on the way Folder depth is now uint16 65535 levels is probably excessive children_count is also uint16 as well I made the first folders below root '/' stay below root instead of shifting since the horizontal real estate is limited slightly smaller than it began but hopefully faster & more reliable Change-Id: I348f61baf865cccdeacddfd9d50641a882e890fc |
||
|---|---|---|
| .. | ||
| bitmap | ||
| skin_engine | ||
| backdrop.c | ||
| backdrop.h | ||
| color_picker.c | ||
| color_picker.h | ||
| folder_select.c | ||
| folder_select.h | ||
| icon.c | ||
| icon.h | ||
| line.c | ||
| line.h | ||
| list.c | ||
| list.h | ||
| mask_select.c | ||
| mask_select.h | ||
| option_select.c | ||
| option_select.h | ||
| pitchscreen.c | ||
| pitchscreen.h | ||
| quickscreen.c | ||
| quickscreen.h | ||
| scrollbar.c | ||
| scrollbar.h | ||
| splash.c | ||
| splash.h | ||
| statusbar-skinned.c | ||
| statusbar-skinned.h | ||
| statusbar.c | ||
| statusbar.h | ||
| usb_screen.c | ||
| usb_screen.h | ||
| viewport.c | ||
| viewport.h | ||
| wps.c | ||
| wps.h | ||
| yesno.c | ||
| yesno.h | ||