mirror of
https://github.com/Rockbox/rockbox.git
synced 2025-12-09 13:15:18 -05:00
027c035a4e
This was spotted while playing with qemu-jz: 1) rockbox reads TECR and TESR which are described as write-only registers. Datasheet doesn't mention what happens if they are readed. Apparently this doesn't have fatal side effects. It comes down to two defines from jz4740.h __tcu_stop_counter(n) and __tcu_start_counter(n) which use read-modify-write sequence. 2) rockbox accesses out of bound offset 0xd4 in DMA memspace. It comes from dis_irq() in system-jz4740.c. NUM_DMA is 6 but DMA channels are 0-5 so (irq <= IRQ_DMA_0 + NUM_DMA)) bound check is wrong. This are *NOT* tested on device. Change-Id: I29dff6a4f828030877b7d50fbcc98866478b9e3d Reviewed-on: http://gerrit.rockbox.org/338 Reviewed-by: Bertrik Sikken <bertrik@sikken.nl> Tested-by: Purling Nayuki <cyq.yzfl@gmail.com> Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com> |
||
|---|---|---|
| .. | ||
| onda_vx747 | ||
| onda_vx767 | ||
| app.lds | ||
| ata-nand-jz4740.c | ||
| ata-sd-jz4740.c | ||
| backlight-target.h | ||
| boot.lds | ||
| codec-jz4740.c | ||
| crt0.S | ||
| debug-jz4740.c | ||
| dma_acc-jz4740.c | ||
| fmradio-i2c-jz4740.c | ||
| i2c-jz4740.c | ||
| kernel-jz4740.c | ||
| lcd-jz4740.c | ||
| lcd-target.h | ||
| pcm-jz4740.c | ||
| system-jz4740.c | ||
| system-target.h | ||
| timer-jz4740.c | ||
| usb-jz4740.c | ||