mirror of
https://github.com/Rockbox/rockbox.git
synced 2026-07-10 13:29:52 -04:00
d00a53a1f0
Fix FS#13832 If the remote is already plugged in when Rockbox boots, it stays dead until you replug it. These remotes only send their identify packet once at power-up, so we never see it and then throw away all button events because lingo 0x02 was never negotiated. The OF doesn't care, so accept ContextButtonStatus from unidentified devices too. Stray bytes received before iap_setup() also made iap_getc() return false, which the serial driver takes as "sync found" and locks autobaud onto the wrong bitrate. The ghost clicks come from the repeatbtn handshake. A held button resends its down event every 30-100ms and each one re-armed iap_repeatbtn, which stalls handling of the following packet. So during a long press packets pile up, the event queue overflows, and the leftovers replay as keypresses after you let go. Skipping fires on button release which is why next/prev showed it the worst. Now repeatbtn is only re-armed when the button state actually changes, and iap_handlepkt() drains whatever complete packets are in the RX buffer rather than relying on one queued event per packet. While at it, fix two more things found along the way: the button state is now written in one go (the temporary BUTTON_NONE could be picked up by the button tick mid-update), and iap_rxlen is decremented when a frame is received so the overflow check actually does something. Tested on ipodmini2g with an A1018 remote. Change-Id: Ie18512e47d642fe6957fc010eaf79b6d2af4c070 |
||
|---|---|---|
| .. | ||
| iap-core.c | ||
| iap-core.h | ||
| iap-lingo.h | ||
| iap-lingo0.c | ||
| iap-lingo1.c | ||
| iap-lingo2.c | ||
| iap-lingo3.c | ||
| iap-lingo4.c | ||
| iap-lingo7.c | ||