rockbox

mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00

Author SHA1 Message Date

Author	SHA1	Message	Date
Solomon Peachy	af7f45bac0	Revert "genlang: Explicitly decompose all display strings" This reverts commit `4bc336b8be`. Reason for revert: Font coverage for decomposed diacritics is actually worse than using fully composed characters. Change-Id: Ide37dadd5e9883c1c764ffa35f7e64a7ba91d705	2025-10-22 09:28:35 -04:00
Solomon Peachy	4bc336b8be	genlang: Explicitly decompose all display strings We already have pretty solid support for glyph combining, so this will allow us to utilize that to fill in gaps of our font coverage. This is most notable for Vietnamese, Turkish, and numerous other latin-based writing systems that have unique glyphs that are essentially just a "standard" ascii letter plus a diacritic mark. This leaves voice strings fully composed/normalized. It also has no effect on user-supplied strings (eg filenames or file metadata) When we eventually utf8proc merged, this can be removed in favor of always doing the [de]composition in-system. We will also need to revisit our diacritic tables to ensure there's nothing missing. Change-Id: I7012d27010bb33fb0b565ac7dfd57a16bdcad34f	2025-10-22 08:00:18 -04:00

Solomon Peachy

af7f45bac0

Revert "genlang: Explicitly decompose all display strings"

This reverts commit 4bc336b8be.

Reason for revert:  Font coverage for decomposed diacritics is actually *worse* than using fully composed characters.

Change-Id: Ide37dadd5e9883c1c764ffa35f7e64a7ba91d705

2025-10-22 09:28:35 -04:00

Solomon Peachy

4bc336b8be

genlang: Explicitly decompose all display strings

We already have pretty solid support for glyph combining, so this will
allow us to utilize that to fill in gaps of our font coverage.  This is
most notable for Vietnamese, Turkish, and numerous other latin-based
writing systems that have unique glyphs that are essentially just a
"standard" ascii letter plus a diacritic mark.

This leaves *voice* strings fully composed/normalized.

It also has no effect on user-supplied strings (eg filenames or file
metadata)

When we eventually utf8proc merged, this can be removed in favor
of always doing the [de]composition in-system.  We will also need
to revisit our diacritic tables to ensure there's nothing missing.

Change-Id: I7012d27010bb33fb0b565ac7dfd57a16bdcad34f

2025-10-22 08:00:18 -04:00

Compare commits

2 commits

cd54b4e046 ... af7f45bac0

Diff content is not available

Compare commits

2 commits cd54b4e046 ... af7f45bac0

Diff content is not available

2 commits

cd54b4e046 ... af7f45bac0