* Converted over all previously-translated strings
* Lots of comments added to mark the next phase
* Voice filename of the file being loaded if possible
Change-Id: Ia3219bbfa4505ad29a25bcf1d6eacc94c59a2a83
The strings in the struct configdata[] are only used in the settings
file, and not displayed. Therefore there is no need to translate them.
Change-Id: Id9e03c4b0454412b319ad678e6f57a46e1da0f6e
max I could get was 5 with the default tagnav cfg
but we allow user code too so might be possible to exceed the depth
Change-Id: Icf37916400b464be4f75a723d64a71cd6c4be1fb
technically this isn't currently causing any issue but
coverity correctly identified the potential for buffer ovfl
Change-Id: I4af462c9860c44f22d05b5b2b4c685364823d395
it appears this is false positive but its compliaining
about the uninitialized pointer,
not a bad idea to initialize pointers to NULL anyway
Change-Id: I5832a19ab13971c7d55580694eef70591a3a9acb
BYTES2INT16() uses [i + 0] and [i + 1] therefore 30 is the max element
available in the raw byte array of size 32
(((uint32_t)array[pos+0] << 0) | \
((uint32_t)array[pos+1] << 8))
struct /* raw byte array */
{
uint8_t data[32];
};
basisname is only uninitialized in the . and .. dir entries
both are likely false positives but cheap enough to guard against
Change-Id: Iab3d186fed6050d2d61185071765a2c0feb9515f
mode only goes 0-4 the original commit mixed up the index and mode
bad stuff must happen but its been here for 16 years
Change-Id: I7e69f4e2574029a6bc3cea76e8803d2d0357d9e2
the logic here is a bit fuzzy to me maybe one of the copies to the cuepath
buffer adds a dot but I don't see anything explicit
Change-Id: Idcc469b5d04e4d9125b36df53d6aaa32a10f3bfd
format_track_path() uses path_append_ex() which might use strlen on the
existing buffer likely a false positive but cheap enough to guard against
Change-Id: I7061a434460f235fc58016f9dcf2dfe4633b9f59
the math
size_t endpos = filename - path;
if (filename && endpos < MAX_PATH - 1)
should handle it just fine coverity doesn't think so
Change-Id: Ifa0494e56b40c8ab0081ebc771024a45cb24eb76
26c612f breaks file selections if you have filename extensions disabled
and filenames spelled out, because it modified the filename in place
breaking the caller.
Instead of using a lot of space to make a private copy, the simplest
approach is, if we strip the extension off, simply restore it
afterwards.
Change-Id: Iaf560e813053b8030c620bbed6d061a2423338d5
"Create Directory" option not applicable
in browse filter modes, since directories
do not get displayed
Change-Id: I68944264b03115f7f94254d9df766e5584d30e5a
Track Info can now be displayed for the set of
all tracks contained in a playlist. This lets
you calculate a playlist's length, for example,
even if it is not currently playing.
This functionality can be accessed from the
existing "Properties" screen for a selected
playlist file. A line has been added at the
very bottom to show Track Info.
Change-Id: I311532b7cfa9e29d46c0cd5623ba4c06c1dd5b5f
Instead of hiding this option when the current playlist
is unsaved, we can offer to save the playlist, if
necessary, before attempting to create a bookmark.
This simplifies the workflow by getting rid of steps 1
and 2 that a user currently needs to perform:
1) Open context menu, check if "Create Bookmark" option
is available
2) If not: Re-open context menu. Select Current Playlist
-> Save Current Playlist
3) Re-open context menu. Select Bookmarks
-> Create Bookmark
Change-Id: Ia9fb5f9db95e2fcbde03470a3c3745824424a339
This adds a "Legal Notices" entry under the System menu that will
launch the text viewer plugin to display:
1) COPYING.txt (containing the GPLv2 overall license for Rockbox)
2) LICENSES.txt (containing all other relevant licenses and notices)
Change-Id: Id41ae491b6f9a6ec5663090246d0f6b661cddea5
...Unless it's the very first character (and will get stripped).
So detect and complain about this!
Change-Id: I5e333e8ee134160f64a67783b0d5aa564716d44e
