Miika Pekkarinen
3b2f049ec6
Another oops.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10363 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:50:44 +00:00
Miika Pekkarinen
2fa682535b
Oops, committed some extra stuff not necessary.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10362 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:39:55 +00:00
Miika Pekkarinen
d43bff987a
Define MAX_TRACK_MAX and use it to keep the ring track structure
...
inside boundaries. Cleaned identation also.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10361 a1c6a512-1295-4272-9138-f99709370657
2006-07-29 17:25:31 +00:00
Miika Pekkarinen
6128ff3453
Fixed one of the many pending bugs in the playback engine and restored
...
the instant wps skip feature.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10348 a1c6a512-1295-4272-9138-f99709370657
2006-07-28 09:32:52 +00:00
Magnus Holmgren
0d8c50d7af
Add resume support for AC3 files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10332 a1c6a512-1295-4272-9138-f99709370657
2006-07-26 19:08:16 +00:00
Mark Arigo
50f7e4e083
Additional fix for seeking beyond the current buffered data
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10243 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 21:10:13 +00:00
Dave Chapman
752faa4351
Patch #5157 by Rainer Sinsch - SID codec
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10237 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 18:33:12 +00:00
Miika Pekkarinen
45dfe2a36f
Initial runtimedb support for tagcache. Only for developers,
...
statistical data will be lost in future until changelogs has been
implemented.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10217 a1c6a512-1295-4272-9138-f99709370657
2006-07-15 17:36:25 +00:00
Dave Chapman
b1a272eee2
Patch by Mark Arigo to close bug report #5305 - fixes crashes when attempting to seek beyond the currently buffered data.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10181 a1c6a512-1295-4272-9138-f99709370657
2006-07-03 21:23:14 +00:00
Hardeep Sidhu
75117cc993
Wait for voice to complete before stopping playback. Fixes hang when stopping from filetree while voice is playing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10141 a1c6a512-1295-4272-9138-f99709370657
2006-06-21 04:16:18 +00:00
Hardeep Sidhu
a02fd1ad7d
Only swap_codec() in voice thread when something is playing. Fixes B#5486.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10132 a1c6a512-1295-4272-9138-f99709370657
2006-06-17 11:21:22 +00:00
Jens Arnold
630e9586b6
Fix resume for MP1. Thanks go to Dave Chapman for the hint.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10096 a1c6a512-1295-4272-9138-f99709370657
2006-06-10 11:22:21 +00:00
Hardeep Sidhu
1e0b1d58d6
Stop playback if playlist_next() returns -1 (e.g. if auto directory change fails)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10091 a1c6a512-1295-4272-9138-f99709370657
2006-06-07 20:43:34 +00:00
Magnus Holmgren
f95dd56a2c
Fix bug 5341: Resume in Wav and Flac doesn't start from the position where it was left off. Mark Arigo helped with the Flac fix.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10051 a1c6a512-1295-4272-9138-f99709370657
2006-06-04 15:04:03 +00:00
Hardeep Sidhu
5483da667b
Previous automatic skip fix had a problem if audio_fill_file_buffer() was called after setting playlist_end but before audio_check_new_track(). To fix this, playlist_end is now reset in audio_check_new_track().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10039 a1c6a512-1295-4272-9138-f99709370657
2006-06-03 17:23:20 +00:00
Dave Chapman
db1cda87a6
Replace "#if (ROCKBOX_HAS_LOGF == 1)" with "#ifdef ROCKBOX_HAS_LOGF" - this is consistent with the rest of Rockbox and Mark Arigo reported that it caused an error in his gcc when trying to compile a logf-enabled sim
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9991 a1c6a512-1295-4272-9138-f99709370657
2006-05-25 21:08:38 +00:00
Hardeep Sidhu
a8928804e1
Reset playlist_end when automatically skipping. Fixes B#5319.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9929 a1c6a512-1295-4272-9138-f99709370657
2006-05-15 02:37:06 +00:00
Hardeep Sidhu
c9a11cd3c8
Reset id3 info in all cases where we need to rebuffer tracks
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9928 a1c6a512-1295-4272-9138-f99709370657
2006-05-15 01:45:35 +00:00
Hardeep Sidhu
c8e280c1ed
Reset id3 info when skipping directories. Fixes B#5323.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9892 a1c6a512-1295-4272-9138-f99709370657
2006-05-09 00:14:51 +00:00
Hardeep Sidhu
6a267a8be7
Don't initiate track change if at end of playlist
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9868 a1c6a512-1295-4272-9138-f99709370657
2006-05-03 16:33:23 +00:00
Hardeep Sidhu
7033baea5e
Only reset resume settings when we're really at the end of the playlist
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9867 a1c6a512-1295-4272-9138-f99709370657
2006-05-03 15:54:08 +00:00
Hardeep Sidhu
982d995ae9
Stop playing current track before starting a new playlist with an offset (eg. bookmarks).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9861 a1c6a512-1295-4272-9138-f99709370657
2006-05-02 16:18:21 +00:00
Hardeep Sidhu
b8d1a55fbd
Properly set audio_is_initialized flag for swcodec devices ad use it when initializing crossfade. This should fix the problems with resuming playback at startup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9853 a1c6a512-1295-4272-9138-f99709370657
2006-05-01 18:18:54 +00:00
Magnus Holmgren
e187e01e36
Fix one seeking bug: when seeking back to before a resume point, audio from another track could be played.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9837 a1c6a512-1295-4272-9138-f99709370657
2006-04-30 08:39:24 +00:00
Brandon Low
4564f5c56a
Don't magically skip tracks without user interraction
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9813 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 12:19:16 +00:00
Brandon Low
69cf4f57ac
This seems to fix a few bugs in that
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9811 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 04:31:06 +00:00
Brandon Low
da1cddfcbb
This seems to make selecting a new track from the file browser work very close to right.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9810 a1c6a512-1295-4272-9138-f99709370657
2006-04-26 04:01:35 +00:00
Brandon Low
522ec278ef
Switch inserts back from do while to while loops, because mpc likes to insert zero byte chunks at the end of files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9802 a1c6a512-1295-4272-9138-f99709370657
2006-04-25 18:21:05 +00:00
Brandon Low
3ac7bd7204
Fix the most likely cause of ipod nano startup race, and also seems to fix crossfade buffer reinitialization during playback for me
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9790 a1c6a512-1295-4272-9138-f99709370657
2006-04-24 12:57:41 +00:00
Brandon Low
e0f7ecbfd8
Make track info update in a smarter way
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9782 a1c6a512-1295-4272-9138-f99709370657
2006-04-24 00:48:00 +00:00
Brandon Low
d461a3ef65
Fix some todos, and prevent the position from jumping around badly on seek
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9781 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 23:27:11 +00:00
Brandon Low
6a6c322a19
Improve stop behavior
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9779 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:54:01 +00:00
Brandon Low
5cdee94b40
Fix a warning, and prepare for handling end-of-track seeking
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9778 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:30:52 +00:00
Brandon Low
2e8b933c0d
Should fix some track ending early problems
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9777 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 22:21:12 +00:00
Brandon Low
8ecb8582a1
Make some adjustments to when the WPS will be updated, giving faster next track and cleaner track change updates
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9776 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 20:37:43 +00:00
Brandon Low
83ce56846a
Remove an unneeded define, add a todo
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9765 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 21:31:07 +00:00
Brandon Low
c71ad7ea7f
Fix warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9760 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 14:53:00 +00:00
Brandon Low
f3bc1efc49
First commit of reworking voice to be mroe stable on swcodec
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9758 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 14:40:13 +00:00
Hardeep Sidhu
f635f4a824
Set playing to true immediately when audio_play() is called. Fixes a bug when selecting tracks from playlist viewer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9737 a1c6a512-1295-4272-9138-f99709370657
2006-04-20 05:33:53 +00:00
Brandon Low
4b36096b93
Have the codec thread stop the pcm if we need to spin up the disk
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9727 a1c6a512-1295-4272-9138-f99709370657
2006-04-19 00:23:08 +00:00
Brandon Low
56d6f3ecfc
Fix playback if the user does a very fast seek->skip press
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9726 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 23:43:54 +00:00
Brandon Low
2c9b1717e6
Fix end of playlist handling. I think.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9725 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:52:10 +00:00
Brandon Low
1344ccd3c1
Revert previous, it is broken
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9724 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:51:37 +00:00
Brandon Low
426dc212c6
Make seeking synchronous. It's better this way
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9722 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 19:08:15 +00:00
Brandon Low
2b18727a8a
Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9720 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 18:33:09 +00:00
Brandon Low
ed44e19c3f
Should fix a bug with track skipping backwards following track skip forward, play, seek backward
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9718 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:53:24 +00:00
Brandon Low
7df187f20e
Save empty resume information if the playlist has ended
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9717 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:45:44 +00:00
Brandon Low
095ae809eb
Reduce code size when logf is off. Add a todo. Undo a previous fix that broke crossfade on manual track changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9708 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 19:59:16 +00:00
Brandon Low
98097d23ec
Misc. minor fixes: Guarantee aligned buffer. Enable load-codec-from-disk if a new track requires a different codec than the playing track, but does not already have it on the buffer. Stop playback immediately on a manual track skip. Handle seeking a distance greater than the size of the audio buffer. Enforce the 'no malloc for voice codec'.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9704 a1c6a512-1295-4272-9138-f99709370657
2006-04-17 17:05:05 +00:00
Brandon Low
bf397b5635
Remove an unneeded WPS update signal. Make the codec thread more polite about requesting buffering. Prevent more Codec failure pops when the codec was _asked_ to stop.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9674 a1c6a512-1295-4272-9138-f99709370657
2006-04-15 09:19:49 +00:00