We currently force a skin refresh when setting the
list title. This causes very noticeable flickering
of the list, if the SBS draws over the UI viewport,
when there is no displayable list content yet
(For an example, check out the Adwaitapod theme).
Instead, only mark the title as dirty. Later, when
drawing the list, register for a UI update callback
and ask the skin engine to render, so that we can
draw the list at the same time.
Note: Flickering related to display updates when
switching activities or when toggling the theme is
unrelated to this, and will still need to be addressed
in separate commits.
Change-Id: Icce899905aa311deccb0cc498aacce2866aaae8a
Also adjust scrollbar margins and height so it matches
the look of normal lists, and hide scrollbars when set
to SCROLLBAR_OFF.
Change-Id: I27f6de7b16cf5ec72e12c7d6377a8772d84947ac
1. Lock buttons
2. Lock indicator turns on
3. Plug USB
4. Lock indicator still turned on
5. Unplug USB
6. Lock indicator turns off but buttons still locked and if you
press lock button you see "Buttons locked" splash
pretty sure this is an issue with the touchpad on this device
probably applies to other touchscreen targets too
Change-Id: Ia0afee7d737f3a5a2755f53d176bd53dd57d87c5
FS#13878 - 292x216 images cause panic
alpha channel causes overflow
FS#13862 - In rlimg example "flip image" cause error
missing local variable
save random and rainbow images
fix ball bounce direction
Change-Id: I717eb029f30bf63d2eef0b7997eb04036ffeda15
settings_load_config() only reads up to 128 characters
while openplugin entries could be upwards of 600
instead use the open_plugins plugin to restore entries
add import from .cfg file
add save to .cfg file
better dupe checking
Change-Id: Iec2506aad14a3eb89dcc558b0fbc1f014aad98b5
Regression introduced in 7a281ec.
Fixes crash with the "remember last folder" setting, when the
saved dir has since been removed:
exit_to_new_screen in dirbrowse calls gui_synclist_scroll_stop
when update_dir returns ≤0 for the number of dir entries.
But synclist has not been initialized by update_dir when it
returns early with -1 due to either tagtree_load or ft_load failing.
Move gui_synclist init further up in update_dir, so that when it
returns, the list is guaranteed to be initialized.
Change-Id: I62aa742a3d0121d5034440ff134992034e13fd90
The graphical EQ was configured to use SYSFONT, which is limited to
ASCII despite the EQ being translateable. Change this to use
the current UI font instead.
As the UI font can vary in size quite drastically, alter the EQ slider
from a fixed 6px height (intended for use with an 8px SYSFONT) to 3/4 of
the height of the selected font.
Change-Id: I05e7e77be37e9b8cf633b31c12bc4ef02cbaa90a
Reading the WAV length seems to have been accidentally
commented out in commit e28d1fe916. The WAV length is
not used here but disabling the read broke WAV header
parsing completely.
Change-Id: Ia6d0b1a168b2b029bd1cbec9bdc482caf6fa0487
Affects submenus "Toggle Slideshow Mode"
and "Slideshow Time" that were left un-themed.
Also prevents theme from being re-toggled
when entering "Display Options" submenu.
Change-Id: I3995d5eb12bbc8fb868c179db8043576eb675dbc
Fixes regression where you may not have heard
any audio from some of the plugins modified by
commit 017dd72, due to the playback channel not
being unmuted.
Change-Id: Iaa184161c79d353dff6ef9bf3e0b39778c8b1bcd
This was a latent bug exposed by commit a3f2b64a46
("Enable float formatting in printf"). The version
number is passed as 1.09f, but somehow ends up printing
a string that is so huge it overruns the destination
buffer and corrupts the return address on the stack.
Using snprintf prevents the buffer overrun and gets
quake working again, though this doesn't address the
underlying bug with printf.
Change-Id: I37e4426bc6ebca42d83b5a3b659da497b652d1ae
-fstack-protector only needs a small amount of runtime
support to work on native builds. It increases code size
by ~1.5% on ARM/MIPS; -fstack-protector-strong adds 3-4%.
This is disabled by default and must be enabled by passing
'--with-stack-protector' to configure.
Change-Id: If952e711d3673c9b469895f08c7bff70b3d95df6
-New countdown timer plugin with pause, overtime support
-Add full name to credits and manual entry
-Make status strings translatable
Change-Id: I1437b2e5ac5ede292bdab8d36e58b81326ea2ba3
Quickly reveal a database item in the File Browser.
In case of entire tables, the first entry will be revealed.
Change-Id: I4191f27ea2ab7cacbe375719314d7eb23301fd07
Limit these (less commonly used) "file handling" operations
to the File Browser while making it quicker to reveal the
file that is currently playing from the WPS.
"Open With" and "Delete" remain available as WPS shortcuts.
Change-Id: I91e582a45998160f07a3f7e16d475d770e8c5212
Addresses issue where it became difficult to find the
currently playing track once you scrolled away from it,
either with icons disabled in the Playlist Viewer, or if
the theme's icon set used whitespace for the Music icon.
An example scenario would be when you're moving some track
and are trying to put it next to the currently playing one.
Change-Id: I073a7e55fb723eeff755e32a78f88dcc7db1c245
Looks nicer, especially when the "View Album Art"
option is used.
Add delay to progress bar, so it only appears when
250ms have passed.
Change-Id: I183c839f1ab206385cd01327922933b544c4b78b
ipod:
- To be more consistent with other plugins and
(Settings) menus, press Long Select, instead of Menu,
to reset, and press Menu, or Select, to exit screen
fiiom3k:
- Press Back, or Select, to exit screen
- Press Menu, instead of Select, to switch between modes
- Use repeat button events and adjust values by 1%, instead of
by 0.1%, when scrolling, to speed up setting changes
- Get rid of surprising actions for Back/Menu/Volume buttons
Change-Id: Ifd16958bf56c7e20fb182aa157b4cb4dd19ac9b9
TODO:
* Dynamically hide the sample rates that aren't supported
by the current sink
* Better "default" selection based on hardware type/speed
Change-Id: I261544fc3ba78429eaaa81c89aebd2e68106caa3
The SYSTEM_STATUS macro for these variables has an
F_T_INT flag, which may result in an unexpected value
being written to the resume file for PLM and PVS.
Change-Id: Iea18efbdc68604e1297721d132a9a5b7d056ffad
Every menu heading except the top-level "MPEG Player" (ie the name of
the plugin) now uses pre-existing translated strings.
Change-Id: I65ee64ddc537be4947872da4757bc2f6a27d0bae
Prevents the most recent File Browser directory from
being overwritten when ft_load is called from places other
than the Files menu, such as when browsing the Plugins
menu or the Playlist Catalogue (coming from the main menu,
or from the "Add to Playlist" context menu).
Change-Id: Idbdb2d92c6abcc5cca022d3025b48e0cd4b32f17
Removes `#ifdef`s in many places to just have `HAVE_TOUCHSCREEN` be the
input fall back, as is already tentatively the case in the code.
Solitaire was the only app excluded since there aren’t enough buttons
for it mapped in the SDL layer.
Change-Id: I62450b7110b86c8037a121e96cd2e46754be79a3
get_more() can disable audio when there's nothing more to genreate
but that can get called (and "fail") _before_ we set the flag
that audio is turned on. If this occurs, we will incorrecly
set the "audio on" flag after the failure which will prevent
the mixer from being re-started.
(We're at the mercy of thread scheduling)
Change-Id: I4f6c50a71c7ad685ff45f775e7e4b1c61b8b7777
