It's intended to build all of the Windows Simulator builds in one fell
swoop but has bitrotten a bit. Correct some of the glaring
problems.
Change-Id: I6073af629d2698624036ccf303a5d18398cefdc0
This problem only happened with GCC7 (and older?) simulator builds, and
was introduced by an incorrect test that always stripped our default
optimization (-Os) in simulator builds.
The fix is to correct the test to only strip -Os if the user explicitly
enables a debug build.
Also, use -Og instead of (implicit) -O0, as per GCC recommendations.
Change-Id: I61091b3cdf5323504961c0bb2d80aa65049eb8fb
If disk_mount_all() fails at startup, the device should enter USB mode,
so the storage can be repartitioned/reformatted. After
unmounting/ejecting, the device is rebooted. Unfortunately if the
storage is a RAM disk, the data won't persist after a reboot, so this
patch tries to mount the storage again, instead of just rebooting.
Change-Id: I421a9fd8ae536bee07d292f27d1da0615456df62
If no split tokens are found the string just goes off into space
instead shoten the string till it fits and continue on with the
remaining string
Change-Id: I7fa3619fe8c75ec6c849996d4c3518409938152b
* Only codecs and plugins are enabled
* Only native builds (so far)
* Only tested on xDuoo X3 (MIPS, monochrome)
* opus & speex generate some warnings
* Significant compile time impact
Change-Id: I519b0d179631a54b2103cd67225bd5ec6ad3bd2f
This should actually be strip_extra_leading_separators() but
its not used anywhere else yet and I don't see enough callers
in core to make it worth the extra overhead
Change-Id: Icdd292869b4198bed7725c51820f6b2111ad739d
Some CF cards claim to support Advanced Power Management, but error
out when the command is issued. There is a special case in the
code that ignored errors when issuing the APM command, but was referenced
against a specific index in the feature table.
When the tagle was reorganized, the index was wrong depending
on if ATA_DMA was enabled or not.
The fix is to test against the specific subcommand ID instead of the
table index.
Change-Id: I2ef7a05b2d70675c38e41d70b5189b394056cb74
path_append throws away the basepath if currdir starts with a slash
I thought I had this fixed but it was just getting covered up
instead step past all the slashes and use that for our append dir
Change-Id: I170a2af99455cea09e6e695dfb89fdd42733bd4b
(This is a different implementation of the fix in g#5726, by Vencislav Atanasov)
The core problem is that the user is prompted to insert a USB cable
to fix the partitioning etc but the code that monitors for USB insertion
hasn't been started yet. Correct this.
If no USB support is present, reboot after 5 seconds if it's not a debug
build.
If USB support is present, want for insertion first, then do the
reboot-if-not-debug behavior.
Change-Id: I87827e7fe2fe9a02298918c6ebc4d8a9fb33d624
* Converted over all previously-translated strings
* Lots of comments added to mark the next phase
* Voice filename of the file being loaded if possible
Change-Id: Ia3219bbfa4505ad29a25bcf1d6eacc94c59a2a83
The strings in the struct configdata[] are only used in the settings
file, and not displayed. Therefore there is no need to translate them.
Change-Id: Id9e03c4b0454412b319ad678e6f57a46e1da0f6e
max I could get was 5 with the default tagnav cfg
but we allow user code too so might be possible to exceed the depth
Change-Id: Icf37916400b464be4f75a723d64a71cd6c4be1fb
technically this isn't currently causing any issue but
coverity correctly identified the potential for buffer ovfl
Change-Id: I4af462c9860c44f22d05b5b2b4c685364823d395
it appears this is false positive but its compliaining
about the uninitialized pointer,
not a bad idea to initialize pointers to NULL anyway
Change-Id: I5832a19ab13971c7d55580694eef70591a3a9acb
BYTES2INT16() uses [i + 0] and [i + 1] therefore 30 is the max element
available in the raw byte array of size 32
(((uint32_t)array[pos+0] << 0) | \
((uint32_t)array[pos+1] << 8))
struct /* raw byte array */
{
uint8_t data[32];
};
basisname is only uninitialized in the . and .. dir entries
both are likely false positives but cheap enough to guard against
Change-Id: Iab3d186fed6050d2d61185071765a2c0feb9515f
mode only goes 0-4 the original commit mixed up the index and mode
bad stuff must happen but its been here for 16 years
Change-Id: I7e69f4e2574029a6bc3cea76e8803d2d0357d9e2
the logic here is a bit fuzzy to me maybe one of the copies to the cuepath
buffer adds a dot but I don't see anything explicit
Change-Id: Idcc469b5d04e4d9125b36df53d6aaa32a10f3bfd
format_track_path() uses path_append_ex() which might use strlen on the
existing buffer likely a false positive but cheap enough to guard against
Change-Id: I7061a434460f235fc58016f9dcf2dfe4633b9f59
