Displaying the fonts as you select them is nice but IMO pretty wasteful
I think a few static bitmaps would probably suffice
I however don't feel like addressing this so lets just disable it, for now?
Change-Id: I882cc0c4129e99d8b2f4ac135301dc3906340bb7
When Waveform mode was active, frequency changes during playback
(if set to "auto", or with USB audio active) weren't picked
up
Change-Id: Iebec7db951312b7dacff850e9554e1d06762ab3a
Also show current mixer frequency in title of VU meter,
and adjust the menu title from "VU Meter Menu" to just
"VU Meter"
Change-Id: I5bf8f55a3c9874618cac939fe32a611ac96f52ff
FiiO M3K - you have to hold up or down before the pieces will rotate
AFAICT the scrollpad on the m3k is being presented as a scrollwheel
and it waits for 3 events before enabling rotation.
This behavior is blocking the user presses till you get a repeat event
Fix:
Enable the scrollwheel at start for the m3k (and m3k linux)
Change-Id: Ic36048dae6f691e9085ab37ffbf67be07c2035ac
This bug was found and located by a forum user, see
https://forums.rockbox.org/index.php/topic,54776.0.html
The old code used the FB_SCALARPACK macro which doesn't
respect swapped byte order.
Using FB_RGBPACK fixes it and furthermore makes the
fb.cc[] array superfluous.
I added a small optimization for 16 bit targets, since
the gameboy colors almost fit perfectly (5 bit per color).
Change-Id: If96b3943cb4ab902b880ff3d471add25e138fe8e
Does not seem to affect UI usability, but allowable DSP loads will vary
based on device and playback sample rate.
To-Do (someday):
- Add dedicated DSP channel
- How to apply DSP settings to above new channel? (UI)
- How to lock out timestretch from being enabled?
Change-Id: Ia24d1055340354e2c32e6008e7e2b03a8e88867d
Using pf_idx.album_untagged_idx initialized as to -1 instead of 0,
we can get rid of buggy duplicate untagged albums while keeping "usable"
untagged albums and properly displaying all albums for the first artist
when there are no untagged ablums at all.
Change-Id: I067ce0bba4ece5e2d9466ffd075af8bf653633b4
Instead of calling sound_set_volume() and then manually
setting global_status.volume to match, update the global
volume state directly in sound_set_volume(). This makes
things a bit simpler and less error-prone.
Change-Id: I4db4d60ae1a72bd051ef49c90b1ae7f5ba59e535
Notably, this enables "Group".
This also includes some changes to the Rockbox frontend:
- Removes extraneous underline from Extensive Help text.
- Implements a workaround for an upstream breaking change that removes
the BLITTER_FROMSAVED flag. We depend on this for mouse mode. This
is apparently the only place this flag was ever used. Note that I've
hardcoded an arbitrary negative value for BLITTER_FROMSAVED instead
of -1, for the reason Ben Harris mentioned in his commit removing it
from the upstream source tree.
- Adds an implicit clip() to the game region when drawing a
puzzle. This fixes a bug in Untangle where dragging a point off
screen leads to ugly lines outside the play area.
- Implements "Quick Help" for unfinished plugins (but not "Extensive
Help").
- Documents the need to disable unfinished plugins in resync.sh (weak
symbols on win32).
Change-Id: Ic318a5db4b15acb437a3f951fbc9b7919c6fa652
Dropping this after some failed attempts to work around musl dlclose implementation, fortunately there's a native port.
Change-Id: I17550df81494c6e67ddab21d44fe1287ccfa6156
We used 16-bit variables to store the 'character code' everywhere but
this won't let us represent anything beyond U+FFFF.
This patch changes those variables to a custom type that can be 32 or 16
bits depending on the build, and adjusts numerous internal APIs and
datastructures to match. This includes:
* utf8decode() and friends
* font manipulation, caching, rendering, and generation
* on-screen keyboard
* FAT filesystem (parsing and generating utf16 LFNs)
* WIN32 simulator platform code
Note that this patch doesn't _enable_ >16bit unicode support; a followup
patch will turn that on for appropriate targets.
Appears to work on:
* hosted linux, native, linux simulator in both 16/32-bit modes.
Needs testing on:
* windows and macos simulator (16bit+32bit)
Change-Id: Iba111b27d2433019b6bff937cf1ebd2c4353a0e8
All toolchain dependencies are circa the GCC 10.5.0 release:
GCC 10.5.0, binutils 2.40, gmp 6.2.1, mpfr 4.1.1, mpc 1.3.1, isl 0.24
Native:
* arm - mini2g, nano2g works
- ipod6g hangs at logo display
* mips - xduoox3 works
* m68k - binaries untested
Hosted:
* arm - samsungypr0 works
* mips - xduoox3ii works
* Android NDK - unchanged at GCC 4.9.4
Change-Id: Ic157255d76030e66325719e64331f553cb7c4363
Clarifies presumably intentional fall-through for
PF_TRACKLIST and fixes unwanted behavior of
PF_TRACKLIST while scrolling, which may have
started playback instead of showing the track list.
(affected keymaps at the moment are only SANSA_FUZE_PAD,
SAMSUNG_YH820_PAD, SAMSUNG_YH92X_PAD, and FIIO_M3K_PAD)
Change-Id: I335dd1b4a2152caed966b73aaa189bcfddc79734
When you're using a "large" screen device, and the message doesn't need
to scroll, parts of the previous mesage are left behind.
Work around this by explicitly clearing the messgage with a loooong
blank string.
Change-Id: I02f7789eb6567e92ecca174c40dabc4b580ac045
musl doesn't unload shared objects when we dlclose() the handle. This means
it also never re-initializes them if we try to re-launch.
This means that global state is persisted across invocations instead of
being wiped. Until we come up with a proper workaround we can apply
globally, have the textviewer clean up the important global state when
it exits.
Change-Id: I43bf38e6e9f0e7d824931740daff6c060537235a
We used 16-bit variables to store the 'character code' everywhere but
this won't let us represent anything beyond U+FFFF.
This patch changes those variables to a custom type that can be 32 or 16
bits depending on the build, and adjusts numerous internal APIs and
datastructures to match. This includes:
* utf8decode() and friends
* on-screen keyboard
* font manipulation, caching, rendering, and generation
* VFAT code parses and generates utf16 dirents
* WIN32 simulator reads and writes utf16 filenames
Note that this patch doesn't _enable_ >16bit unicode support; a followup
patch will turn that on for appropriate targets.
Known bugs:
* Native players in 32-bit unicode mode generate mangled filename
entries if they include UTF16 surrogate codepoints. Root cause
is unclear, and may reside in core dircache code.
Needs testing on:
* windows simulator (16bit+32bit)
Change-Id: I193a00fe2a11a4181ddc82df2d71be52bf00b6e6
All toolchain dependencies are circa the GCC 10.5.0 release:
GCC 10.5.0, binutils 2.40, gmp 6.2.1, mpfr 4.1.1, mpc 1.3.1, isl 0.24
Native:
* arm - mini2g, nano2g works
- ipod6g hangs at logo display
* mips - xduoox3 works
* m68k - binaries untested
Hosted:
* arm - samsungypr0 works
* mips - xduoox3ii works
* Android NDK - unchanged at GCC 4.9.4
Change-Id: Ic9c4ad487927d2ad4247c140f1a7db2740e5f316
Affected a bunch of resolutions, tested with every resolution that had the game and ui simulator support.
Change-Id: I6abe9626f323d1f87f94589299ea6c847682e88b
According to screen driver this device screen is actually 16 bit RGB565 (https://github.com/DrUm78/linux/blob/FunKey_S/drivers/staging/fbtft/fb_st7789v.c#L137).
This also fixes the color banding issues we had before and boomshine doesn't segfault anymore. Also building rockpaint now that's possible.
Change-Id: Icee49c347fbfabc79e0040314ec148cb77ca6325
A bit of context, this device is a clone of the FunKey-S with a different form factor, hardware is mostly identical, the relevant difference is it has audio out (via usb-c, adapter to 3.5mm is included), this is the reason why the FunKey-SDK is needed for bulding.
This port is based on the old SDL 1.2 code because the device doesn't have SDL2 support. Alongside what was supported in the SDL 1.2 builds this port supports battery level, charging status and backlight control.
Change-Id: I7fcb85be62748644b667c0efebabf59d6e9c5ade
In direct mode, the statically allocated Rockbox LCD framebuffer is used and should never be freed. Otherwise, ROCKBOX_VideoQuit takes care of freeing the dynamically allocated hidden buffer, used for scaling.
This fixed hanging of Rockbox when quitting an SDL app.
Change-Id: Ib9cd8c04cc0d2d6ccedaa582a5a85ef211d0273c
- Default to round border in analog mode
- Default to segmented LCD style in digital and binary mode
- Default to date format most fitting for current language
(instead of D-M-Y)
- Don't forcibly set a light background before menu is
displayed or when quitting
- Update manual
Change-Id: Ifb6a41bb99701ae8f8cbf5fa0db2a3a332085f43
- Use system time format and remove separate setting
- Hide timer until started & eliminate setting for it
- Simplify menu, reorder settings, keep theme enabled
- Make dialog for resetting settings more consistent
with other reset dialogs
Change-Id: I0fd38612b0592cd5a650c8985f377acc70a48eb7
- When loading or saving clock settings,
only show message if an error occurred
- Eliminate error message that was displayed
when clock settings file didn't exist (yet).
Change-Id: I6d9c646d3895dba1f18ef3c2f9e73fa15fbc2c1c
