IpodVT reported odd word wrapping in the case of a perfectly fitting line on a space
which carried over to the next line
in the process I got a ASAN overflow on the line buffer due to
the possibility that lines_per_page - 1 might be -1 and then
reading off in space for an offset into the file
not sure that this would really cause an issue since it would presumably
be bounded within the boundries of the file anyway
Change-Id: Ib5b2c5a30b58faf8bda653f9b9d8d7f76cfb8069
Lists with a selection size of >1 aren't skinned, so we
we have to manually take care of calling scroll_stop on
the un-skinned bookmark list before displaying the
(skinned) context menu.
Change-Id: Ie7ce627b5ea073be03304b7c676403cdfb4d3243
posix month field is called mon not month
mon goes from 0-11 so strfrtime needs to add 1 to the number for %m
day of week goes 0-6 where 0 = sunday
day of year goes 0-365 (365 on a leap year)
according to lua everything starts at 1
so month is 1-12
day of week goes 1-7 1 = sunday
day of year is 1-365 (366 on a leap year)
added some fields in the time_date example
Change-Id: Icd502b172285d23133488aa3456786d756667bfa
Reduces GNU Complexity score from 33 to 2.
Additionally:
- Allocate MAX_PATH, instead of MAX_PATH+1,
for formatted id3 info (NULL terminator is
already included)
- Ensure minimum name buffer size of 2*MAX_PATH,
instead of MAX_PATH+1, so that there is space for
both the formatted track name and, if enabled, the
id3 info of a single track
Change-Id: Ie60590f6c0da4fe3a515b5643494a29cfc56de50
- Eliminate separate display update for USB screen UI vp;
wait for skin_render instead
- Eliminate outer loop around handle_usb_events
- Use handle_usb_events in Simulator as well.
Fixes USB screen being dismissed by any button presses,
or by system events.
- When USB keypad mode is changed, only redraw the title viewport
- Delete unused MODE_NAME_LEN #define
- Hide "USB keypad mode:" prefix. Only display current mode setting,
which requires less scrolling and ensures that the new setting
is always visible immediately after it has been changed
- Change comment from:
/* Don't return until we get SYS_USB_DISCONNECTED or SYS_TIMEOUT */
to: /* Don't return until we get SYS_USB_DISCONNECTED */
which reflects existing behavior (comment may have been
copy-pasted from usb_wait_for_disconnect_w_tmo)
- Don't scroll USB keypad mode unless UI vp's width is > 1, since
some themes try to hide the USB viewport and display a custom UI
instead
Change-Id: I9b9703025b00ad807920ee60a843f269f414f6f9
Load stts (time to sample) table on demand if it doesn't fit in RAM.
Fixes FS#13889 (in most cases I've seen files with single element in this table and problematic one has 111200 elements)
Change-Id: I719f92a4512a45472739587e81861b9bc545f349
When using a theme with custom skinned lists
(e.g. Themify 2), a line in Text Editor will
continue to scroll after opening the context
menu, because you're switching from an un-
skinned list to a skinned list, which means
that list-skinned.c/list_draw isn't calling
scroll_stop_viewport for the list_text_vp,
as would be the case for un-skinned lists.
Change-Id: I952937166d8f17c9d57f4d93e715de970c49e5e8
small bug, /t as the last character should left justify without
adding spaces to the end of string
/t also added too many spaces to the end of tabbed lines
adds info comment for new usage
ifdef removes some functionality for the bootloader
Change-Id: Ia4ba80f631f8bac3a13441912a8560616fa2c784
For some reason this resolves an apparently-unrelated warning about a const
violation inside playlist_viewer_init().
Change-Id: Ifd4eb008335876707abe64da04a3afd0d1c46633
GCC16 is stricter about reporting these, and while we can rely on
the compiler to optimize away dead stores, we're better off eliminating
them from the source code.
Change-Id: I14570a986811a77ca656c60d792593ff8c458571
The compiler is smart enough to optimize away dead stores but let's
just get rid of them in the first place
Change-Id: I5c85d7c05ef03b084205356a21248f7b049296b0
chris_s reported that a vp width of 1 wpuld cause the trxt reflow to go into an endless loop
check for this and skip displaying the splash
add a warning to the sim for catching unintentional cases of this
Change-Id: I9e1c561f745b5bcf113d0a6cdff57a00cd190fd4
only split a long word across lines if it is larger than screen width
also consider \0 as a valid place to split so we still run through the space finding loop
make /t left justify the splash window (in RTL langs it right justifies)
Change-Id: Id2955878a178c66cb0a1c644e62f943247666d8b
The imx233 bootloader reserves the first 1MB of DRAM for loading the
main firmware, but the recent utf8proc changes means we now exceed that
size on most imx233 targets. Bump this up to 1.5MB to give us more headroom
Change-Id: I1b8bede85d06d40338ea6e3d9abb4e5da34423be
Fixes issues with multiple spaces
adds support for \n and multiple \n
adds support for \t (only at start of line)
adds utf8 aware string splitting
locks to max width/height
adds \f to reset min width / height
larger buffer for units with ram > 8mb
make splash buffer static
Needs testing
Change-Id: I46915043719dce0d696c5ab0da3ed92e4755829c
This reverts commit e13befb925.
Reason for revert: Significant performance regressions, especially with respect to UI interactivity when the database is in use; see https://forums.rockbox.org/index.php/topic,55703.0.html
Change-Id: I0428711871480b74f7faeecb0536f7ed63f631cc
maxbytes counted final characters not actual bytes
font_measurestring() returns the number of bytes of a string that will
fit in a given width
Change-Id: Id73b763267e399bd558f87872b5e715076f9b7f7
Metadata for formatting the trackname can
be read from the database instead of from
disk. I think this was changed by mistake,
when a single function was added for both
Show Track Info and track name formatting.
Change-Id: I903d36bb513898242505f01562340924bf642a12
Regression introduced in commit 7aca1d4.
Quickscreen kept redrawing itself over the USB screen,
because remove_event_ex was only called after returning
from it.
Change-Id: I8a187809781cef46d13ed45392efecb28435a9df
Accidentally made the vp flash in previous commit.
Dir scanning doesn't display a progress bar
and already handles its own drawing
Change-Id: Id0e67d62081dfe4b22e91c775cd80af2e55a4b69
Otherwise, with themes that adjust the viewport
for the current activity, the background behind
the progress bar may look glitchy while
scanning items, until the list is displayed
Change-Id: I27a207b37c3209eae9bc61e1fd0862fb5872be57
Slight optimization of c145d19. Not supposed to result in
any visible difference.
- if UI viewport is drawn for GUI_EVENT_NEED_UI_UPDATE,
it doesn't need to do a viewport update; skin_render
already updates the display
- skin_render_deferred shouldn't need to request that
the skin perform an immediate update
Change-Id: Id03cf89357eaf0d61af1e928c94942d8c4882dba
