gui: Remove gui_synclist_limit_scroll()

Since gui_synclist_do_button() overrides the setting at runtime
there is no reason to have a public API call to set it. Really
it should be a local variable, but it will be simpler to do that
after refactoring how list wraparound behavior is handled.

Change-Id: Id09d42197814102693752a9f64db8325118ca796

apps/plugins/chessbox/chessbox_pgn.c

@@ -678,7 +678,6 @@ struct pgn_game_node* pgn_show_game_list(struct pgn_game_node* first_game){
     if (rb->global_settings->talk_menu)
         rb->gui_synclist_set_voice_callback(&games_list, speak_game_selection);
     rb->gui_synclist_set_nb_items(&games_list, i);
-    rb->gui_synclist_limit_scroll(&games_list, true);
     rb->gui_synclist_select_item(&games_list, 0);
 
     rb->gui_synclist_draw(&games_list);

apps/plugins/keybox.c

@@ -659,7 +659,6 @@ enum plugin_status plugin_start(const void *parameter)
     rb->gui_synclist_set_title(&kb_list, "Keybox", NOICON);
     rb->gui_synclist_set_icon_callback(&kb_list, NULL);
     rb->gui_synclist_set_nb_items(&kb_list, 0);
-    rb->gui_synclist_limit_scroll(&kb_list, false);
     rb->gui_synclist_select_item(&kb_list, 0);
 
     init_ll();

apps/plugins/keyremap.c

@@ -1950,7 +1950,6 @@ static void synclist_set(int id, int selected_item, int items, int sel_size)
     rb->gui_synclist_set_icon_callback(&lists,NULL);
     rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
     rb->gui_synclist_set_nb_items(&lists,items);
-    rb->gui_synclist_limit_scroll(&lists,true);
     rb->gui_synclist_select_item(&lists, selected_item);
     printcell_enable(&lists, false, false);
 

apps/plugins/open_plugins.c

@@ -623,7 +623,6 @@ static void synclist_set(char* menu_id, int selection, int items, int sel_size)
     rb->gui_synclist_set_icon_callback(&lists,NULL);
     rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
     rb->gui_synclist_set_nb_items(&lists,items);
-    rb->gui_synclist_limit_scroll(&lists,true);
     rb->gui_synclist_select_item(&lists, selection);
     list_voice_cb(selection, menu_id);
 }

apps/plugins/properties.c

@@ -389,7 +389,6 @@ enum plugin_status plugin_start(const void* parameter)
         rb->gui_synclist_set_nb_items(&properties_lists,
                                       2 * (props_type == PROPS_FILE ? NUM_FILE_PROPERTIES :
                                                                       NUM_DIR_PROPERTIES));
-        rb->gui_synclist_limit_scroll(&properties_lists, true);
         rb->gui_synclist_select_item(&properties_lists, 0);
         rb->gui_synclist_draw(&properties_lists);
         rb->gui_synclist_speak_item(&properties_lists);

apps/plugins/puzzles/rockbox.c

@@ -2450,7 +2450,6 @@ static int list_choose(const char *list_str, const char *title, int sel)
     rb->gui_synclist_init(&list, &config_choices_formatter, (void*)list_str, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(&list, NULL);
     rb->gui_synclist_set_nb_items(&list, n);
-    rb->gui_synclist_limit_scroll(&list, false);
 
     rb->gui_synclist_select_item(&list, sel);
 
@@ -2664,7 +2663,6 @@ static bool config_menu(void)
     rb->gui_synclist_init(&list, &config_formatter, config, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(&list, NULL);
     rb->gui_synclist_set_nb_items(&list, n);
-    rb->gui_synclist_limit_scroll(&list, false);
 
     rb->gui_synclist_select_item(&list, 0);
 
@@ -2750,7 +2748,6 @@ static int do_preset_menu(struct preset_menu *menu, char *title, int selected)
     rb->gui_synclist_init(&list, &preset_formatter, menu, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(&list, NULL);
     rb->gui_synclist_set_nb_items(&list, menu->n_entries);
-    rb->gui_synclist_limit_scroll(&list, false);
 
     rb->gui_synclist_select_item(&list, selected);
 

apps/plugins/random_folder_advance_config.c

@@ -311,7 +311,6 @@ static int edit_list(void)
     rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(&lists,NULL);
     rb->gui_synclist_set_nb_items(&lists,list->count);
-    rb->gui_synclist_limit_scroll(&lists,true);
     rb->gui_synclist_select_item(&lists, 0);
 
     while (!exit)

apps/plugins/rb_info.c

@@ -514,7 +514,6 @@ static void synclist_set(char* menu_id, int selected_item, int items, int sel_si
     rb->gui_synclist_set_icon_callback(&lists,NULL);
     rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
     rb->gui_synclist_set_nb_items(&lists,items);
-    rb->gui_synclist_limit_scroll(&lists,true);
     rb->gui_synclist_select_item(&lists, selected_item);
 
 }

apps/plugins/shopper.c

@@ -304,7 +304,6 @@ enum plugin_status plugin_start(const void* parameter)
     /* now dump it in the list */
     rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(&lists, list_get_icon_cb);
-    rb->gui_synclist_limit_scroll(&lists,true);
     create_view(&lists);
     rb->gui_synclist_set_nb_items(&lists,view_item_count);
     rb->gui_synclist_select_item(&lists, 0);

apps/plugins/shortcuts/shortcuts_view.c

@@ -115,7 +115,6 @@ int list_sc(void)
     rb->gui_synclist_set_title(&gui_sc,
         (user_file?"Shortcuts (sealed)":"Shortcuts (editable)"), NOICON);
     rb->gui_synclist_set_nb_items(&gui_sc, sc_file.entry_cnt);
-    rb->gui_synclist_limit_scroll(&gui_sc, false);
     rb->gui_synclist_select_item(&gui_sc, 0);
 
     /* Draw the prepared widget to the LCD now */

apps/plugins/text_editor.c

@@ -214,7 +214,6 @@ static void setup_lists(struct gui_synclist *lists, int sel)
     rb->gui_synclist_init(lists,list_get_name_cb,0, false, 1, NULL);
     rb->gui_synclist_set_icon_callback(lists,NULL);
     rb->gui_synclist_set_nb_items(lists,line_count);
-    rb->gui_synclist_limit_scroll(lists,true);
     rb->gui_synclist_select_item(lists, sel);
     rb->gui_synclist_draw(lists);
 }