len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

misc: shutdown: fix backdrop glitches

Browse source 
Clearing the display makes the backdrop come to the foreground.
which can look odd or glitchy, particularly for themes that do
custom drawing on the backdrop buffer (2c71aa9). It also causes
issues if the shutdown has to be canceled.

Instead, enable theme, then clear the UI vp.

Change-Id: Ia96d1e766a9b86ec133522f7cd259e8b88f64216
This commit is contained in:
Christian Soffke 2026-05-30 02:12:03 +02:00
parent 2b96380641
commit f123dbc04a
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
apps/misc.c
View file

@ -373,10 +373,13 @@ static bool clean_shutdown(enum shutdown_type sd_type,
int audio_stat = audio_status();
#endif
FOR_NB_SCREENS(i)
viewportmanager_theme_enable(i, true, NULL);
clear_screen_buffer(false);
FOR_NB_SCREENS(i)
{
screens[i].clear_display();
screens[i].update();
screens[i].scroll_stop();
}
if (batt_safe)
@ -387,6 +390,8 @@ static bool clean_shutdown(enum shutdown_type sd_type,
{
cancel_shutdown();
splash(HZ, ID2P(LANG_TAGCACHE_BUSY));
FOR_NB_SCREENS(i)
viewportmanager_theme_undo(i, false);
return false;
}
#endif