len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 02:27:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

show track info: skip Comment and codec string copies

Browse source 
Comment copy was added in c647e62c as workaround for FS#11033 and no longer needed (I tested really long lines and scroll no longer throw any errors on my Sansa e200v2)

Change-Id: I96a5b26096829034692dffc2abc730ff2bdd5d9c
This commit is contained in:
Roman Artiukhin 2024-11-05 12:11:15 +02:00 • committed by Solomon Peachy
parent da478aaa32
commit ee365f21c4
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
apps/screens.c
View file

@ -582,9 +582,8 @@ static const char * id3_get_or_speak_info(int selected_item, void* data,
if (!id3->comment) if (!id3->comment)
return NULL; return NULL;
strmemccpy(buffer, id3->comment, buffer_len);
val=buffer; val = id3->comment;
if(say_it && val) if(say_it && val)
talk_spell(val, true); talk_spell(val, true);
break; break;
@ -659,9 +658,7 @@ static const char * id3_get_or_speak_info(int selected_item, void* data,
if (id3->codectype == AFMT_UNKNOWN && info->track_ct > 1) if (id3->codectype == AFMT_UNKNOWN && info->track_ct > 1)
return NULL; return NULL;
strmemccpy(buffer, get_codec_string(id3->codectype), buffer_len); val = (char*) get_codec_string(id3->codectype);
val=buffer;
if(say_it) if(say_it)
talk_spell(val, true); talk_spell(val, true);
break; break;