len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-10-10 08:03:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

FS#14005 - Use a 44.1KHz floor when guessing playback frequency

Browse source 
Regression introduced in f87ff3a9b, which made it possible for audio
playback to request a freq under 44.1KHz, instead of treating 44.1 as
a floor (and upsampling)

However, there is a report of 22KHz files playing back distorted on an
imx233 target.

IMO a 44KHz floor is reasonable, but this bug is a symptom of something
deeper.  Perhaps the mp3 codec isn't doing the right thing, or there's
an issue in the pcm mixer somewhere, or the imx233 codec doesn't properly
handle 22KHz?  Further investigation is warranted.

Change-Id: I751ce05f8605de7f90d3eb7b3c98873487df438b
This commit is contained in:
Solomon Peachy 2026-09-27 19:48:51 -04:00
parent 50d8c4a58e
commit ecdeb02dda
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
apps/playback.c
View file

@ -1258,7 +1258,7 @@ void allocate_playback_log(void)
playback_log_handle = core_alloc(PLAYBACK_LOG_BUFSZ);
if (playback_log_handle > 0)
{
DEBUGF("%s Allocated %d bytes\n", __func__, PLAYBACK_LOG_BUFSZ);
DEBUGF("%s Allocated %d bytes\n", __func__, PLAYBACK_LOG_BUFSZ);
char *buf = core_get_data(playback_log_handle);
buf[0] = '\0';
}
@ -2995,7 +2995,7 @@ static void audio_on_track_changed(void)
static void audio_start_playback(const struct audio_resume_info *resume_info,
unsigned int flags)
{
/*
/*
* Refuse to start playback if usb audio is active. See gui_wps_show() for
* a splash message to the user.
* NOTE: if USBAudio ever gets its own DSP channel, this block can go away!
@ -4270,7 +4270,8 @@ static unsigned long audio_guess_frequency(struct mp3entry *id3)
have_44 = true;
if (caps->samprs[i] == SAMPR_48)
have_48 = true;
if (id3->frequency == caps->samprs[i])
/* Always upscale to 44.1 or better */
if (id3->frequency >= SAMPR_44 && id3->frequency == caps->samprs[i])
return id3->frequency;
}
unsigned long fallback = (id3->frequency % 4000) ? SAMPR_44 : SAMPR_48;