Replace "Reload After Saving" with option to remove queued tracks

The "Reload After Saving" setting was added in
g3347 (4f83e66) to solve FS#13287, by allowing
you to bookmark a modified playlist after saving,
without having to manually reload it first.

Since the rewrite of playlist_save in g5192
(90e3571), a modified playlist doesn't have to be
reloaded anymore in order to be bookmarked after
it's been saved, unless it contains queued tracks.

To cover the remaining use cases of the previously
available option, Rockbox will now offer to remove
any queued tracks from a playlist when saving it.

Change-Id: I2d6f12bcce14d8ff41a4d921ce84d628774103ac

manual/configure_rockbox/bookmarking.tex

@@ -18,7 +18,10 @@
         and does not work for tracks launched via the
         database. In addition, they do not work with dynamic (i.e. modified but not saved)
         playlists. If making a bookmark is not available, saving the playlist
-        is sufficient to allow a bookmark to be made.}
+        is sufficient to allow a bookmark to be made. Queued tracks, which are automatically
+        removed after playback, do not get stored to the playlist file and must
+        not be part of the current playlist. You need to confirm the removal of such tracks
+        when saving, or bookmarking will not be possible.}
 
   \begin{description}
 

manual/configure_rockbox/playlist_options.tex

@@ -47,13 +47,6 @@ related to playlists.
   If set to \setting{In Submenu}, Rockbox will move the options into a
   separate submenu.
 
-  \item[Reload After Saving.]
-  If set to \setting{Yes}, saving the current playlist from the While Playing Screen's
-  Context Menu will cause Rockbox to load the newly saved playlist and resume it to the
-  current position. This is useful for creating bookmarks after modifying or customizing
-  a playlist. Saving playlists outside of the While Playing Screen's Context Menu will
-  not be affected by this setting.
-
   \end{description}
 
 \end{description}

manual/main_menu/main.tex

@@ -178,8 +178,10 @@ will be saved in the Playlist Catalogue directory.
 
 \item[Save Current Playlist:]
   Saves the current dynamic playlist, excluding queued tracks, to the
-specified file. If no path is provided then playlist is saved to the current
-directory.
+specified file. Asks for confirmation whether to remove queued tracks
+from the current playlist, so that bookmarks can be created
+(see \reference{ref:createbookmark}).
+If no path is provided then playlist is saved to the current directory.
 
 \item[Reset Playlist Catalogue Directory:]
   Will reset the default location for playlists to the \fname{/Playlists}

manual/rockbox_interface/wps.tex

@@ -223,8 +223,13 @@ enabled. It allows the assignment of a personal rating value (0 -- 10)
 to a track which can be displayed in the WPS and used in the Database
 browser. The value wraps at 10.
 
-\subsubsection{Bookmarks}
-This allows you to create a bookmark in the currently-playing track.
+\subsubsection{\label{ref:createbookmark}Bookmarks}
+This allows you to create a bookmark in the currently-playing track. Note that bookmarks
+can only be created for directories, or for playlists stored on disk. Unsaved or modified
+lists must be saved first. Queued tracks, which are automatically removed after playback,
+do not get stored to the playlist file. When saving, Rockbox will offer to purge the
+current playlist of such tracks, so that you'll be able to create bookmarks afterwards.
+See \reference{ref:Bookmarkconfigactual} for more information on bookmarks.
 
 \subsubsection{\label{ref:trackinfoviewer}Show Track Info}
 \screenshot{rockbox_interface/images/ss-id3-viewer}{The track info viewer}{}

manual/working_with_playlists/main.tex

@@ -173,7 +173,9 @@ select \setting{Save Current Playlist} or enter the context menu for the
 \setting{Save Current Playlist}.
 Either method will bring you to the \setting{Virtual Keyboard} (see
 \reference{sec:virtual_keyboard}), enter a filename for your playlist and
-accept it and you are done.
+accept it. If the current playlist contains any queued tracks, you will be
+asked whether to remove them, as a prerequisiste for creating bookmarks
+(see \reference{ref:createbookmark}).
 
 \subsection{Loading saved playlists}
 \subsubsection{Through the \setting{File Browser}}