mirror of
https://github.com/Rockbox/rockbox.git
synced 2025-11-18 09:32:40 -05:00
Do some minor cleanup.
- Move a GUI-only implementation class around. - Make some strings non-translatable which don't make sense translating. - Rename internal state in installation class. There is no current build anymore. Change-Id: I7384c5601de36bc48f858fe5c7b009653d439d94
This commit is contained in:
parent
b7931594f9
commit
e7fdf80c17
8 changed files with 14 additions and 14 deletions
|
|
@ -11,7 +11,7 @@
|
||||||
</rect>
|
</rect>
|
||||||
</property>
|
</property>
|
||||||
<property name="windowTitle">
|
<property name="windowTitle">
|
||||||
<string>Form</string>
|
<string>Info</string>
|
||||||
</property>
|
</property>
|
||||||
<layout class="QGridLayout" name="gridLayout">
|
<layout class="QGridLayout" name="gridLayout">
|
||||||
<item row="0" column="0">
|
<item row="0" column="0">
|
||||||
|
|
@ -31,7 +31,7 @@
|
||||||
<widget class="QTreeWidget" name="treeInfo">
|
<widget class="QTreeWidget" name="treeInfo">
|
||||||
<column>
|
<column>
|
||||||
<property name="text">
|
<property name="text">
|
||||||
<string>1</string>
|
<string>Package</string>
|
||||||
</property>
|
</property>
|
||||||
</column>
|
</column>
|
||||||
</widget>
|
</widget>
|
||||||
|
|
|
||||||
|
|
@ -11,7 +11,7 @@
|
||||||
</rect>
|
</rect>
|
||||||
</property>
|
</property>
|
||||||
<property name="windowTitle">
|
<property name="windowTitle">
|
||||||
<string>Form</string>
|
<string>Manual</string>
|
||||||
</property>
|
</property>
|
||||||
<layout class="QGridLayout" name="gridLayout">
|
<layout class="QGridLayout" name="gridLayout">
|
||||||
<item row="0" column="0">
|
<item row="0" column="0">
|
||||||
|
|
|
||||||
|
|
@ -63,7 +63,7 @@ void SelectiveInstallWidget::selectedVersionChanged(int index)
|
||||||
if(current == "release")
|
if(current == "release")
|
||||||
ui.selectedDescription->setText(tr("This is the latest stable "
|
ui.selectedDescription->setText(tr("This is the latest stable "
|
||||||
"release available."));
|
"release available."));
|
||||||
if(current == "current")
|
if(current == "development")
|
||||||
ui.selectedDescription->setText(tr("The development version is "
|
ui.selectedDescription->setText(tr("The development version is "
|
||||||
"updated on every code change. Last update was on %1").arg(
|
"updated on every code change. Last update was on %1").arg(
|
||||||
ServerInfo::value(ServerInfo::BleedingDate).toString()));
|
ServerInfo::value(ServerInfo::BleedingDate).toString()));
|
||||||
|
|
@ -89,7 +89,7 @@ void SelectiveInstallWidget::updateVersion(void)
|
||||||
// re-populate all version items
|
// re-populate all version items
|
||||||
m_versions.clear();
|
m_versions.clear();
|
||||||
m_versions.insert("release", ServerInfo::value(ServerInfo::CurReleaseVersion).toString());
|
m_versions.insert("release", ServerInfo::value(ServerInfo::CurReleaseVersion).toString());
|
||||||
m_versions.insert("current", ServerInfo::value(ServerInfo::BleedingRevision).toString());
|
m_versions.insert("development", ServerInfo::value(ServerInfo::BleedingRevision).toString());
|
||||||
m_versions.insert("rc", ServerInfo::value(ServerInfo::RelCandidateVersion).toString());
|
m_versions.insert("rc", ServerInfo::value(ServerInfo::RelCandidateVersion).toString());
|
||||||
|
|
||||||
ui.selectedVersion->clear();
|
ui.selectedVersion->clear();
|
||||||
|
|
@ -97,9 +97,9 @@ void SelectiveInstallWidget::updateVersion(void)
|
||||||
ui.selectedVersion->addItem(tr("Stable Release (Version %1)").arg(
|
ui.selectedVersion->addItem(tr("Stable Release (Version %1)").arg(
|
||||||
m_versions["release"]), "release");
|
m_versions["release"]), "release");
|
||||||
}
|
}
|
||||||
if(!m_versions["current"].isEmpty()) {
|
if(!m_versions["development"].isEmpty()) {
|
||||||
ui.selectedVersion->addItem(tr("Development Version (Revison %1)").arg(
|
ui.selectedVersion->addItem(tr("Development Version (Revison %1)").arg(
|
||||||
m_versions["current"]), "current");
|
m_versions["development"]), "development");
|
||||||
}
|
}
|
||||||
if(!m_versions["rc"].isEmpty()) {
|
if(!m_versions["rc"].isEmpty()) {
|
||||||
ui.selectedVersion->addItem(tr("Release Candidate (Revison %1)").arg(
|
ui.selectedVersion->addItem(tr("Release Candidate (Revison %1)").arg(
|
||||||
|
|
@ -116,7 +116,7 @@ void SelectiveInstallWidget::updateVersion(void)
|
||||||
ui.selectedVersion->setCurrentIndex(index);
|
ui.selectedVersion->setCurrentIndex(index);
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
index = ui.selectedVersion->findData("current");
|
index = ui.selectedVersion->findData("development");
|
||||||
ui.selectedVersion->setCurrentIndex(index);
|
ui.selectedVersion->setCurrentIndex(index);
|
||||||
}
|
}
|
||||||
// check if Rockbox is installed. If it is untick the bootloader option, as
|
// check if Rockbox is installed. If it is untick the bootloader option, as
|
||||||
|
|
@ -377,7 +377,7 @@ void SelectiveInstallWidget::installRockbox(void)
|
||||||
|
|
||||||
if(selected == "release") url = ServerInfo::platformValue(m_target,
|
if(selected == "release") url = ServerInfo::platformValue(m_target,
|
||||||
ServerInfo::CurReleaseUrl).toString();
|
ServerInfo::CurReleaseUrl).toString();
|
||||||
else if(selected == "current") url = ServerInfo::platformValue(m_target,
|
else if(selected == "development") url = ServerInfo::platformValue(m_target,
|
||||||
ServerInfo::CurDevelUrl).toString();
|
ServerInfo::CurDevelUrl).toString();
|
||||||
else if(selected == "rc") url = ServerInfo::platformValue(m_target,
|
else if(selected == "rc") url = ServerInfo::platformValue(m_target,
|
||||||
ServerInfo::RelCandidateUrl).toString();
|
ServerInfo::RelCandidateUrl).toString();
|
||||||
|
|
|
||||||
|
|
@ -17,7 +17,7 @@
|
||||||
</sizepolicy>
|
</sizepolicy>
|
||||||
</property>
|
</property>
|
||||||
<property name="windowTitle">
|
<property name="windowTitle">
|
||||||
<string>Form</string>
|
<string>Selective Installation</string>
|
||||||
</property>
|
</property>
|
||||||
<layout class="QGridLayout" name="gridLayout_3">
|
<layout class="QGridLayout" name="gridLayout_3">
|
||||||
<item row="0" column="0">
|
<item row="0" column="0">
|
||||||
|
|
|
||||||
|
|
@ -353,14 +353,14 @@ void RbUtilQt::updateDevice()
|
||||||
QString name
|
QString name
|
||||||
= QString("%1 (%2)").arg(SystemInfo::value(SystemInfo::CurName).toString(),
|
= QString("%1 (%2)").arg(SystemInfo::value(SystemInfo::CurName).toString(),
|
||||||
ServerInfo::value(ServerInfo::CurStatus).toString());
|
ServerInfo::value(ServerInfo::CurStatus).toString());
|
||||||
ui.labelDevice->setText(tr("<b>%1 %2</b>").arg(brand, name));
|
ui.labelDevice->setText(QString("<b>%1 %2</b>").arg(brand, name));
|
||||||
|
|
||||||
QString mountpoint = RbSettings::value(RbSettings::Mountpoint).toString();
|
QString mountpoint = RbSettings::value(RbSettings::Mountpoint).toString();
|
||||||
QString mountdisplay = QDir::toNativeSeparators(mountpoint);
|
QString mountdisplay = QDir::toNativeSeparators(mountpoint);
|
||||||
if(!mountdisplay.isEmpty()) {
|
if(!mountdisplay.isEmpty()) {
|
||||||
QString label = Utils::filesystemName(mountpoint);
|
QString label = Utils::filesystemName(mountpoint);
|
||||||
if(!label.isEmpty()) mountdisplay += QString(" (%1)").arg(label);
|
if(!label.isEmpty()) mountdisplay += QString(" (%1)").arg(label);
|
||||||
ui.labelMountpoint->setText(tr("<b>%1</b>").arg(mountdisplay));
|
ui.labelMountpoint->setText(QString("<b>%1</b>").arg(mountdisplay));
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
mountdisplay = "(unknown)";
|
mountdisplay = "(unknown)";
|
||||||
|
|
|
||||||
|
|
@ -76,7 +76,7 @@ SOURCES += \
|
||||||
quazip/zip.c \
|
quazip/zip.c \
|
||||||
quazip/ioapi.c \
|
quazip/ioapi.c \
|
||||||
base/ziputil.cpp \
|
base/ziputil.cpp \
|
||||||
comboboxviewdelegate.cpp \
|
gui/comboboxviewdelegate.cpp \
|
||||||
gui/selectiveinstallwidget.cpp \
|
gui/selectiveinstallwidget.cpp \
|
||||||
gui/backupdialog.cpp \
|
gui/backupdialog.cpp \
|
||||||
|
|
||||||
|
|
@ -148,7 +148,7 @@ HEADERS += \
|
||||||
quazip/zip.h \
|
quazip/zip.h \
|
||||||
base/ziputil.h \
|
base/ziputil.h \
|
||||||
lame/lame.h \
|
lame/lame.h \
|
||||||
comboboxviewdelegate.h \
|
gui/comboboxviewdelegate.h \
|
||||||
gui/selectiveinstallwidget.h \
|
gui/selectiveinstallwidget.h \
|
||||||
gui/backupdialog.h \
|
gui/backupdialog.h \
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue