Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657

firmware/bidi.c

@@ -27,6 +27,7 @@
 #include "rbunicode.h"
 #include "arabjoin.h"
 #include "scroll_engine.h"
+#include "bidi.h"
 
 /* #define _HEB_BUFFER_LENGTH (MAX_PATH + LCD_WIDTH/2 + 3 + 2 + 2) * 2 */
 #define _HEB_BLOCK_TYPE_ENG 1
@@ -40,7 +41,7 @@
 #define _isnewline(c) ((c=='\n' || c=='\r') ? 1 : 0)
 #define XOR(a,b) ((a||b) && !(a&&b))
 
-const arab_t * arab_lookup(unsigned short uchar)
+static const arab_t * arab_lookup(unsigned short uchar)
 {
     if (uchar >= 0x621 && uchar <= 0x63a)
         return &(jointable[uchar - 0x621]);
@@ -53,8 +54,8 @@ const arab_t * arab_lookup(unsigned short uchar)
     return 0;
 }
 
-void arabjoin(unsigned short * stringprt, int length){
-
+static void arabjoin(unsigned short * stringprt, int length)
+{
     bool connected = false;
     unsigned short * writeprt = stringprt;
 

firmware/common/crc32-mi4.c

@@ -37,7 +37,7 @@
 
 /* based on implementation by Finn Yannick Jacobs */
 
-
+#include "crc32-mi4.h"
 
 /* crc_tab[] -- this crcTable is being build by chksum_crc32GenTab().
  *      so make sure, you call it before using the other

firmware/common/crc32.c

@@ -19,6 +19,8 @@
 
 /* Code copied from firmware_flash plugin. */
 
+#include "crc32.h"
+
 /* Tool function to calculate a CRC32 across some buffer */
 /* third argument is either 0xFFFFFFFF to start or value from last piece */
 unsigned crc_32(const void *src, unsigned len, unsigned crc32)

firmware/common/structec.c

@@ -109,7 +109,7 @@ void structec_convert(void *structure, const char *ecinst,
  * @param ecinst endianess correction string.
  * @return length of the struct in bytes.
  */
-size_t structec_size(const char *ecinst)
+static size_t structec_size(const char *ecinst)
 {
     size_t size = 0;
     

firmware/debug.c

@@ -36,6 +36,7 @@ static char debugbuf[400];
 #ifndef SIMULATOR /* allow non archos platforms to display output */
 #include "kernel.h"
 #include "system.h"
+#include "debug.h"
 
 #ifdef DEBUG
 #if CONFIG_CPU == SH7034 /* these are still very SH-oriented */

firmware/drivers/audio/as3514.c

@@ -23,6 +23,7 @@
 #include "debug.h"
 #include "system.h"
 #include "audio.h"
+#include "sound.h"
 
 #include "audiohw.h"
 #include "i2s.h"

firmware/export/bidi.h

@@ -17,5 +17,8 @@
  *
  ****************************************************************************/
 #ifndef BIDI_H
+#define BIDI_H
+
 extern unsigned short *bidi_l2v(const unsigned char *str, int orientation);
-#endif
+
+#endif /* BIDI_H */

firmware/mp3data.c

@@ -307,8 +307,8 @@ static void buf_init(void)
     fnf_read_index = 0;
 }
 
-unsigned long buf_find_next_frame(int fd, long *offset, long max_offset,
-                                  unsigned long last_header)
+static unsigned long buf_find_next_frame(int fd, long *offset, long max_offset,
+                                         unsigned long last_header)
 {
     return __find_next_frame(fd, offset, max_offset, last_header, buf_getbyte);
 }

firmware/replaygain.c

@@ -27,6 +27,7 @@
 #include <system.h>
 #include "id3.h"
 #include "debug.h"
+#include "replaygain.h"
 
 /* The fixed point math routines (with the exception of fp_atof) are based
  * on oMathFP by Dan Carter (http://orbisstudios.com).

firmware/target/arm/sandisk/ata-c200_e200.c

@@ -787,7 +787,7 @@ static void sd_select_device(int card_no)
 
 /* API Functions */
 
-void ata_led(bool onoff)
+static void ata_led(bool onoff)
 {
     led(onoff);
 }

firmware/target/arm/sandisk/power-c200_e200.c

@@ -23,6 +23,7 @@
 #include "i2c-pp.h"
 #include "tuner.h"
 #include "as3514.h"
+#include "power.h"
 
 void power_init(void)
 {

firmware/thread.c

@@ -1657,7 +1657,7 @@ struct thread_entry *
  * catch something.
  *---------------------------------------------------------------------------
  */
-void check_for_obj_waiters(const char *function, struct thread_entry *thread)
+static void check_for_obj_waiters(const char *function, struct thread_entry *thread)
 {
     /* Only one bit in the mask should be set with a frequency on 1 which
      * represents the thread's own base priority */