len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Get rid of useless playlist probing and fix up some data types.

Browse source 
Playback checked the files' presence before attempting to buffer
the track. Just get rid of that and save an extra open/close call.
It will find out if the path is bad when the metadata fails.

Fix some size_t/off_t conflation. No need to update plugin version
because no plugin actually uses bufopen().

Change-Id: I3db112449dc0b2eeb91c546f308880ac82494fc7
This commit is contained in:
Michael Sevakis 2017-12-17 16:12:10 -05:00
parent d14e3f45a8
commit dfff938dff
4 changed files with 66 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

16
apps/buffering.h
View file

@ -75,7 +75,7 @@ bool buffering_reset(char *buf, size_t buflen);
* NOTE: Tail operations are only legal when the end of the file is buffered.
****************************************************************************/
int bufopen(const char *file, size_t offset, enum data_type type,
int bufopen(const char *file, off_t offset, enum data_type type,
void *user_data);
int bufalloc(const void *src, size_t size, enum data_type type);
bool bufclose(int handle_id);
@ -101,17 +101,19 @@ ssize_t bufcuttail(int handle_id, size_t size);
* buf_back_off_storage: tell buffering thread to take it easy
****************************************************************************/
enum data_type buf_handle_data_type(int handle_id);
ssize_t buf_handle_remaining(int handle_id);
bool buf_is_handle(int handle_id);
ssize_t buf_handle_offset(int handle_id);
void buf_set_base_handle(int handle_id);
size_t buf_length(void);
size_t buf_used(void);
int buf_handle_data_type(int handle_id);
off_t buf_filesize(int handle_id);
off_t buf_handle_offset(int handle_id);
off_t buf_handle_remaining(int handle_id);
bool buf_pin_handle(int handle_id, bool pin);
bool buf_signal_handle(int handle_id, bool signal);
size_t buf_length(void);
size_t buf_used(void);
/* Settings */
void buf_set_base_handle(int handle_id);
void buf_set_watermark(size_t bytes);
size_t buf_get_watermark(void);