len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

tagtree.c get_tag() increase performance

Browse source 
while its not a particularly hot path it still gets called upwards
of 1000x on startup

with a little pre processing we can make it faster than even the
prior version

check first letter before calling function
move strlen check to after the case match

Change-Id: I0108aaf9828501b57b0950fbc24cd478a9eeacc1
This commit is contained in:
William Wilgus 2025-02-10 12:55:26 -05:00 • committed by William Wilgus
parent 39285d06d5
commit d893da1929
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/tagtree.c
View file

@ -358,6 +358,7 @@ static int get_token_str(char *buf, int size)
static int get_tag(int *tag)
{
/* case insensitive matching ahead - these should all be lower case */
#define TAG_TABLE \
TAG_MATCH("lm", tag_virt_length_min) \
TAG_MATCH("ls", tag_virt_length_sec) \
@ -433,12 +434,16 @@ static int get_tag(int *tag)
}
tagstr_len = strp - tagstr;
char first = tolower(*tagstr++); /* get the first letter elide cmp fn call */
for (size_t i = 0; i < ARRAYLEN(get_tag_match); i++)
{
const char *match = get_tag_match[i];
if ((ptrdiff_t)strlen(match) == tagstr_len)
if (first == match[0] && strncasecmp(tagstr, match + 1, tagstr_len - 1) == 0)
{
if (strncasecmp(tagstr, match, tagstr_len) == 0)
/* check for full match */
if ((ptrdiff_t)strlen(match) == tagstr_len)
{
*tag = get_tag_symbol[i];
return 1;