len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-14 10:37:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bugfixes in eq_menu.c

Browse source 
Change-Id: Ibf754554f685d13ac00a49694fcecee459ff838f
This commit is contained in:
Aidan MacDonald 2021-08-06 19:12:20 +01:00
parent 1a9a5fc279
commit d541a72a0e
1 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
apps/menus/eq_menu.c
View file

@ -239,14 +239,12 @@ static void selection_to_banditem(int selection, int expanded_band, int *band, i
static char *advancedmenu_item_get_name(int selected_item, void *data, char *buffer, size_t len) static char *advancedmenu_item_get_name(int selected_item, void *data, char *buffer, size_t len)
{ {
(void)len;
int band; int band;
int item; int item;
char *lang = NULL; int lang = -1;
selection_to_banditem(selected_item, *(intptr_t*)data, &band, &item); selection_to_banditem(selected_item, *(intptr_t*)data, &band, &item);
strcpy(buffer, "\t");
switch (item) switch (item)
{ {
case 0: /* Band title */ case 0: /* Band title */
@ -256,27 +254,34 @@ static char *advancedmenu_item_get_name(int selected_item, void *data, char *buf
return str(LANG_EQUALIZER_BAND_HIGH_SHELF); return str(LANG_EQUALIZER_BAND_HIGH_SHELF);
else else
{ {
snprintf(buffer, MAX_PATH, str(LANG_EQUALIZER_BAND_PEAK), band); snprintf(buffer, len, str(LANG_EQUALIZER_BAND_PEAK), band);
return buffer; return buffer;
} }
break; break;
case 1: /* cutoff */ case 1: /* cutoff */
if (band == 0) if (band == 0)
lang = str(LANG_EQUALIZER_BAND_CUTOFF); lang = LANG_EQUALIZER_BAND_CUTOFF;
else if (band == EQ_NUM_BANDS - 1) else if (band == EQ_NUM_BANDS - 1)
lang = str(LANG_EQUALIZER_BAND_CUTOFF); lang = LANG_EQUALIZER_BAND_CUTOFF;
else else
lang = str(LANG_EQUALIZER_BAND_CENTER); lang = LANG_EQUALIZER_BAND_CENTER;
break; break;
case 2: /* Q */ case 2: /* Q */
lang = str(LANG_EQUALIZER_BAND_Q); lang = LANG_EQUALIZER_BAND_Q;
break; break;
case 3: /* Gain */ case 3: /* Gain */
lang = str(LANG_GAIN); lang = LANG_GAIN;
break; break;
} }
return strcat(buffer, lang);; if(lang < 0)
buffer[0] = 0;
else {
buffer[0] = '\t';
strlcpy(&buffer[1], str(lang), len - 1);
}
return buffer;
} }
static int advancedmenu_speak_item(int selected_item, void *data) static int advancedmenu_speak_item(int selected_item, void *data)