From d1abd788d0b22de1d8165b01b8c69eb6cb1ccd2d Mon Sep 17 00:00:00 2001 From: Christian Soffke Date: Thu, 23 Apr 2026 14:15:46 +0200 Subject: [PATCH] pcm_mixer: fix missing NULL check for play_cbs Fixes Metronome plugin crashing (regression introduced in cb04b81) Does *not* fix missing Metronome sound (regression introduced in 017dd72) Change-Id: I1da9aa2c937b267a3d5b122c431eaa9f7e748440 --- firmware/pcm_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firmware/pcm_mixer.c b/firmware/pcm_mixer.c index fb12e53373..607db70839 100644 --- a/firmware/pcm_mixer.c +++ b/firmware/pcm_mixer.c @@ -163,7 +163,7 @@ fill_frame: if (chan->size == 0) { - if (chan->play_cbs->get_more) + if (chan->play_cbs && chan->play_cbs->get_more) { chan->play_cbs->get_more(&chan->start, &chan->size); ALIGN_AUDIOBUF(chan->start, chan->size);