len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-26 23:36:37 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

internals: Support characters beyond the first unicode plane (WIP)

Browse source 
We used 16-bit variables to store the 'character code' everywhere but
this won't let us represent anything beyond U+FFFF.

This patch changes those variables to a custom type that can be 32 or 16
bits depending on the build, and adjusts numerous internal APIs and
datastructures to match.  This includes:

 * utf8decode() and friends
 * on-screen keyboard
 * font manipulation, caching, rendering, and generation
 * VFAT code parses and generates utf16 dirents
 * WIN32 simulator reads and writes utf16 filenames

Note that this patch doesn't _enable_ >16bit unicode support; a followup
patch will turn that on for appropriate targets.

Known bugs:

  * Native players in 32-bit unicode mode generate mangled filename
    entries if they include UTF16 surrogate codepoints.  Root cause
    is unclear, and may reside in core dircache code.

Needs testing on:

 * windows simulator (16bit+32bit)

Change-Id: I193a00fe2a11a4181ddc82df2d71be52bf00b6e6
This commit is contained in:
Solomon Peachy 2024-12-17 08:55:21 -05:00
parent 94712b34d4
commit d05c59f35b
44 changed files with 480 additions and 335 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/hosted/android/keyboard.c
View file

@ -82,7 +82,7 @@ static void kdb_init(void)
sleep(HZ/10);
}
int kbd_input(char* text, int buflen, unsigned short *kbd)
int kbd_input(char* text, int buflen, ucschar_t *kbd)
{
(void)kbd;
JNIEnv e = *env_ptr;
@ -107,7 +107,7 @@ int kbd_input(char* text, int buflen, unsigned short *kbd)
e->DeleteLocalRef(env_ptr, str);
e->DeleteLocalRef(env_ptr, ok_text);
e->DeleteLocalRef(env_ptr, cancel_text);
return !accepted; /* return 0 on success */
}