len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-07 13:45:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Proposed fix for FS#12878: Zero-length embedded album art prevents mp3 playback

Browse source 
see http://www.rockbox.org/tracker/task/12878

Change-Id: Ib4233c06e18d1d193dfb9e73e745ca5d174e40b2
Reviewed-on: http://gerrit.rockbox.org/507
Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
This commit is contained in:
Jack Whitham 2013-07-11 21:09:58 +01:00 • committed by Thomas Martitz
parent 10d71bb910
commit ca423ed0e3
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/rbcodec/metadata/id3tags.c
View file

@ -355,7 +355,8 @@ static int parsealbumart( struct mp3entry* entry, char* tag, int bufferpos )
/* fixup offset&size for image data */ /* fixup offset&size for image data */
entry->albumart.pos += tag - start; entry->albumart.pos += tag - start;
entry->albumart.size -= tag - start; entry->albumart.size -= tag - start;
entry->has_embedded_albumart = true; /* check for malformed tag with no picture data */
entry->has_embedded_albumart = (entry->albumart.size != 0);
} }
/* return bufferpos as we didn't store anything in id3v2buf */ /* return bufferpos as we didn't store anything in id3v2buf */
return bufferpos; return bufferpos;