len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-07-10 13:29:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

mkimxboot: Fix potentially unaligned pointer access of a packed structure

Browse source 
Co-authored-by: ChatGPT (GPT-5.3 Mini) <chatgpt@openai.com>
Change-Id: I437ae173a8f1304a33082e62b86110c9bc4488ba
This commit is contained in:
Vencislav Atanasov 2026-06-29 21:40:30 +03:00
parent f4e9ba7f17
commit c7d5603c63
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
utils/mkimxboot/mkimxboot.c
View file

@ -454,12 +454,16 @@ static enum imx_error_t parse_version(const char *s, struct sb_version_t *ver)
printf("[ERR] Bad version override '%s' (missing second dot)\n", s);
return IMX_ERROR;
}
enum imx_error_t ret = parse_subversion(s, dot1, &ver->major);
uint16_t major, minor, revision;
enum imx_error_t ret = parse_subversion(s, dot1, &major);
if(ret != IMX_SUCCESS) return ret;
ret = parse_subversion(dot1 + 1, dot2, &ver->minor);
ret = parse_subversion(dot1 + 1, dot2, &minor);
if(ret != IMX_SUCCESS) return ret;
ret = parse_subversion(dot2 + 1, NULL, &ver->revision);
ret = parse_subversion(dot2 + 1, NULL, &revision);
if(ret != IMX_SUCCESS) return ret;
memcpy(&ver->major, &major, sizeof(ver->major));
memcpy(&ver->minor, &minor, sizeof(ver->minor));
memcpy(&ver->revision, &revision, sizeof(ver->revision));
return IMX_SUCCESS;
}