Redo my previous segfault fix in a better way.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16205 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Dominik Riebeling 2008-02-03 11:49:29 +00:00
parent 5a38f3e9de
commit c5b8a7b45d
2 changed files with 5 additions and 10 deletions

View file

@ -88,10 +88,8 @@ void CreateVoiceWindow::setSettings(RbSettings* sett)
QString encoder = settings->curEncoder();
// only proceed if encoder setting is set
if(!encoder.isEmpty()) {
// FIXME: getEncoder CAN return a NULL pointer. Additional error
// checking is required or getEncoder should use the default engine
EncBase* enc = getEncoder(encoder);
EncBase* enc = getEncoder(encoder);
if(enc != NULL) {
enc->setCfg(settings);
if(enc->configOk())
ui.labelEncProfile->setText(tr("Selected Encoder: <b>%1</b>").arg(encoder));

View file

@ -119,11 +119,8 @@ void InstallTalkWindow::setSettings(RbSettings* sett)
ui.labelTtsProfile->setText(tr("Selected TTS Engine: <b>%1</b>").arg("Invalid TTS configuration!"));
QString encoder = settings->curEncoder();
// only proceed if encoder setting is set
if(!encoder.isEmpty()) {
// FIXME: getEncoder CAN return a NULL pointer. Additional error
// checking is required or getEncoder should use the default engine
EncBase* enc = getEncoder(encoder);
EncBase* enc = getEncoder(encoder);
if(enc != NULL) {
enc->setCfg(settings);
if(enc->configOk())
ui.labelEncProfile->setText(tr("Selected Encoder: <b>%1</b>").arg(encoder));