len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

lastfm_scrobbler check for back to back repeat entries

Browse source 
if you skip a track after the halfway point the scrobbler may double post
with slightly different timestamps but the same track info

take a crc of the non-unique part and check against the previously
written track

Change-Id: I676342c4cd76f632131d9cb6d9f7d2f59df357e6
This commit is contained in:
William Wilgus 2022-04-02 08:00:31 -04:00
parent 43abe2d820
commit bf3e67204c
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
apps/plugins/lastfm_scrobbler.c
View file

@ -27,6 +27,10 @@ http://www.audioscrobbler.net/wiki/Portable_Player_Logging
#include "plugin.h" #include "plugin.h"
#ifndef UNTAGGED
#define UNTAGGED "<UNTAGGED>"
#endif
#ifdef ROCKBOX_HAS_LOGF #ifdef ROCKBOX_HAS_LOGF
#define logf rb->logf #define logf rb->logf
#else #else
@ -324,6 +328,9 @@ static inline char* str_chk_valid(char *s, char *alt)
static void scrobbler_add_to_cache(const struct mp3entry *id) static void scrobbler_add_to_cache(const struct mp3entry *id)
{ {
static uint32_t last_crc = 0;
int trk_info_len = 0;
if ( gCache.pos >= SCROBBLER_MAX_CACHE ) if ( gCache.pos >= SCROBBLER_MAX_CACHE )
scrobbler_write_cache(); scrobbler_write_cache();
@ -344,13 +351,14 @@ static void scrobbler_add_to_cache(const struct mp3entry *id)
int ret = rb->snprintf(&scrobbler_buf[(SCROBBLER_CACHE_LEN*gCache.pos)], int ret = rb->snprintf(&scrobbler_buf[(SCROBBLER_CACHE_LEN*gCache.pos)],
SCROBBLER_CACHE_LEN, SCROBBLER_CACHE_LEN,
"%s\t%s\t%s\t%s\t%d\t%c\t%ld\t%s\n", "%s\t%s\t%s\t%s\t%d\t%c%n\t%ld\t%s\n",
str_chk_valid(artist, UNTAGGED), str_chk_valid(artist, UNTAGGED),
str_chk_valid(id->album, ""), str_chk_valid(id->album, ""),
str_chk_valid(id->title, ""), str_chk_valid(id->title, ""),
tracknum, tracknum,
(int)(id->length / 1000), (int)(id->length / 1000),
rating, rating,
&trk_info_len,
get_timestamp(), get_timestamp(),
str_chk_valid(id->mb_track_id, "")); str_chk_valid(id->mb_track_id, ""));
@ -361,11 +369,19 @@ static void scrobbler_add_to_cache(const struct mp3entry *id)
} }
else else
{ {
logf("Added %s", scrobbler_buf); uint32_t crc = rb->crc_32(&scrobbler_buf[(SCROBBLER_CACHE_LEN*gCache.pos)],
gCache.pos++; trk_info_len, 0xFFFFFFFF);
if (crc != last_crc)
{
last_crc = crc;
logf("Added %s", scrobbler_buf);
gCache.pos++;
#if USING_STORAGE_CALLBACK #if USING_STORAGE_CALLBACK
rb->register_storage_idle_func(scrobbler_flush_callback); rb->register_storage_idle_func(scrobbler_flush_callback);
#endif #endif
}
else
logf("SCROBBLER: skipping repeat entry: %s", id->path);
} }
} }