len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 13:12:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

playlist: Get rid of plugin buffer use in playlist_save().

Browse source 
The plugin buffer was used only to avoid reparsing the playlist, so non-essential.
But when it was used it conflicted with the playlist viewer which already uses
the plugin buffer for playlist purposes simultaneously. It only works by
accident.

Since the reparse avoidance is non-essential don't do it for now. A temp buffer
can be passed to playlist_save() to enable it but the only caller (as of now)
does not do that.

Change-Id: I3f75f89d8551e1ec38800268b273105faba0efbf
This commit is contained in:
Thomas Martitz 2014-04-08 22:52:37 +02:00
parent 466441dc14
commit bebf71a08b
3 changed files with 48 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

3
apps/menus/playlist_menu.c
View file

@ -61,7 +61,7 @@ int save_playlist_screen(struct playlist_info* playlist)
if (!kbd_input(temp, sizeof(temp)))
{
playlist_save(playlist, temp);
playlist_save(playlist, temp, NULL, 0);
/* reload in case playlist was saved to cwd */
reload_directory();
@ -113,4 +113,3 @@ MAKE_MENU(playlist_options, ID2P(LANG_PLAYLISTS), NULL,
Icon_Playlist,
&create_playlist_item, &view_cur_playlist,
&save_playlist, &clear_catalog_directory_item);