len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 21:22:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Bugfix] playlist_viewer.c

Browse source 
had the conditional backwards

changing display settings now reloads list

Change-Id: Iea8f6bb1c7323b316a386135a6ccb192b214f6db
This commit is contained in:
William Wilgus 2024-07-10 17:07:03 -04:00
parent 43dfa7d084
commit bdb5bf1511
1 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

17
apps/playlist_viewer.c
View file

@ -231,7 +231,7 @@ static bool retrieve_track_metadata(struct mp3entry *id3, const char *filename,
#if defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE) #if defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE)
/* try to get the id3 data from the database */ /* try to get the id3 data from the database */
/* the database, doesn't store frequency, file size or codec (g4470) ChrisS*/ /* the database, doesn't store frequency, file size or codec (g4470) ChrisS*/
if ((flags & METADATA_EXCLUDE_ID3_PATH) || !tagcache_fill_tags(id3, filename)) if (!(flags & METADATA_EXCLUDE_ID3_PATH) || !tagcache_fill_tags(id3, filename))
#endif #endif
/* fall back to reading the file from disk */ /* fall back to reading the file from disk */
{ {
@ -718,10 +718,23 @@ static enum pv_onplay_result onplay_menu(int index)
ret = viewer.playlist ? PV_ONPLAY_UNCHANGED : PV_ONPLAY_SAVED; ret = viewer.playlist ? PV_ONPLAY_UNCHANGED : PV_ONPLAY_SAVED;
break; break;
case 7: case 7:
{
int last_display = global_settings.playlist_viewer_track_display;
/* playlist viewer settings */ /* playlist viewer settings */
result = do_menu(&viewer_settings_menu, NULL, NULL, false); result = do_menu(&viewer_settings_menu, NULL, NULL, false);
ret = (result == MENU_ATTACHED_USB) ? PV_ONPLAY_USB : PV_ONPLAY_UNCHANGED;
if (result == MENU_ATTACHED_USB)
ret = PV_ONPLAY_USB;
else
{
if (last_display != global_settings.playlist_viewer_track_display)
update_playlist(true);/* reload buffer */
ret = PV_ONPLAY_UNCHANGED;
}
break; break;
}
#ifdef HAVE_TAGCACHE #ifdef HAVE_TAGCACHE
case 8: case 8:
ret = open_pictureflow(current_track); ret = open_pictureflow(current_track);