From bce2c4e069a27b94ce6ae838d53e2c2d83aaf3b9 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Thu, 5 Feb 2026 10:04:27 +0000 Subject: [PATCH] Convert users of SHAREDDATA_ATTR to SHAREDBSS_ATTR The handful of uses are only doing zero initialization so don't need to go in the data section, they can go in bss instead. Change-Id: I7108ac60867aa20b4429ac0747d00109563bb3bf --- apps/plugins/fft/fft.c | 2 +- apps/voice_thread.c | 2 +- firmware/backlight.c | 2 +- firmware/kernel/tick.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/plugins/fft/fft.c b/apps/plugins/fft/fft.c index deb5a115bc..fb719ab9aa 100644 --- a/apps/plugins/fft/fft.c +++ b/apps/plugins/fft/fft.c @@ -799,7 +799,7 @@ static inline bool fft_get_fft(void) #if NUM_CORES > 1 /* use a worker thread if there is another processor core */ -static volatile bool fft_thread_run SHAREDDATA_ATTR = false; +static volatile bool fft_thread_run SHAREDBSS_ATTR; static unsigned long fft_thread = 0; static long fft_thread_stack[CACHEALIGN_UP(DEFAULT_STACK_SIZE*4/sizeof(long))] diff --git a/apps/voice_thread.c b/apps/voice_thread.c index 0f0d89c24e..b31bc5bc76 100644 --- a/apps/voice_thread.c +++ b/apps/voice_thread.c @@ -97,7 +97,7 @@ static const char voice_thread_name[] = "voice"; /* Voice thread synchronization objects */ static struct event_queue voice_queue SHAREDBSS_ATTR; static struct queue_sender_list voice_queue_sender_list SHAREDBSS_ATTR; -static int quiet_counter SHAREDDATA_ATTR = 0; +static int quiet_counter SHAREDBSS_ATTR; static bool voice_playing = false; #define VOICE_PCM_FRAME_COUNT ((PLAY_SAMPR_MAX*VOICE_FRAME_COUNT + \ diff --git a/firmware/backlight.c b/firmware/backlight.c index e28793253b..a00483c070 100644 --- a/firmware/backlight.c +++ b/firmware/backlight.c @@ -199,7 +199,7 @@ static int lcd_sleep_timeout = 10*HZ; #define lcd_sleep_timeout LCD_SLEEP_TIMEOUT #endif -static int lcd_sleep_timer SHAREDDATA_ATTR = 0; +static int lcd_sleep_timer SHAREDBSS_ATTR; static void backlight_lcd_sleep_countdown(bool start) { diff --git a/firmware/kernel/tick.c b/firmware/kernel/tick.c index c524560687..6fe2bf4305 100644 --- a/firmware/kernel/tick.c +++ b/firmware/kernel/tick.c @@ -34,7 +34,7 @@ void (*tick_funcs[MAX_NUM_TICK_TASKS+1])(void); #if !defined(CPU_PP) || !defined(BOOTLOADER) || \ defined(HAVE_BOOTLOADER_USB_MODE) -volatile long current_tick SHAREDDATA_ATTR = 0; +volatile long current_tick SHAREDBSS_ATTR; #endif /* - Timer initialization and interrupt handler is defined at