len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-05-12 11:43:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

plugins: properties: don't clear UI viewport for dirs

Browse source 
Accidentally made the vp flash in previous commit.

Dir scanning doesn't display a progress bar
and already handles its own drawing

Change-Id: Id0e67d62081dfe4b22e91c775cd80af2e55a4b69
This commit is contained in:
Christian Soffke 2026-05-09 07:03:58 +02:00
parent 325a028af4
commit bc528c4079
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
apps/plugins/properties.c
View file

@ -331,13 +331,6 @@ enum plugin_status plugin_start(const void* parameter)
const char *file = parameter; const char *file = parameter;
static struct viewport ui_vp; static struct viewport ui_vp;
/* clear UI vp */
struct screen* display = rb->screens[SCREEN_MAIN];
rb->viewport_set_defaults(&ui_vp, SCREEN_MAIN);
struct viewport *last_vp = display->set_viewport(&ui_vp);
display->clear_viewport();
display->set_viewport(last_vp);
#ifdef HAVE_TOUCHSCREEN #ifdef HAVE_TOUCHSCREEN
rb->touchscreen_set_mode(rb->global_settings->touch_mode); rb->touchscreen_set_mode(rb->global_settings->touch_mode);
#endif #endif
@ -349,6 +342,17 @@ enum plugin_status plugin_start(const void* parameter)
return PLUGIN_OK; return PLUGIN_OK;
} }
/* erase background behind progress bar to prevent glitches
for themes adjusting viewport for context menu activity */
if (props_type != PROPS_DIR)
{
struct screen* display = rb->screens[SCREEN_MAIN];
rb->viewport_set_defaults(&ui_vp, SCREEN_MAIN);
struct viewport *last_vp = display->set_viewport(&ui_vp);
display->clear_viewport();
display->set_viewport(last_vp);
}
if (props_type == PROPS_MUL_ID3) if (props_type == PROPS_MUL_ID3)
ret = assemble_track_info(NULL, NULL); ret = assemble_track_info(NULL, NULL);
else if (props_type != PROPS_ID3) else if (props_type != PROPS_ID3)