len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 18:17:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[COV] cuesheet.c var line could be uninitialized

Browse source 
Change-Id: Id753ecc28f4029e05032be0c0ac6ecd27e9e370f
This commit is contained in:
William Wilgus 2022-03-18 18:57:55 -04:00
parent 99f8457279
commit b31444261e
1 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

31
apps/cuesheet.c
View file

@ -222,22 +222,25 @@ bool parse_cuesheet(struct cuesheet_file *cue_file, struct cuesheet *cue)
/* Look for a Unicode BOM */ /* Look for a Unicode BOM */
unsigned char bom_read = 0; unsigned char bom_read = 0;
read(fd, line, BOM_UTF_8_SIZE); if (read(fd, line, BOM_UTF_8_SIZE) > 0)
if(!memcmp(line, BOM_UTF_8, BOM_UTF_8_SIZE))
{ {
char_enc = CHAR_ENC_UTF_8; if(!memcmp(line, BOM_UTF_8, BOM_UTF_8_SIZE))
bom_read = BOM_UTF_8_SIZE; {
} char_enc = CHAR_ENC_UTF_8;
else if(!memcmp(line, BOM_UTF_16_LE, BOM_UTF_16_SIZE)) bom_read = BOM_UTF_8_SIZE;
{ }
char_enc = CHAR_ENC_UTF_16_LE; else if(!memcmp(line, BOM_UTF_16_LE, BOM_UTF_16_SIZE))
bom_read = BOM_UTF_16_SIZE; {
} char_enc = CHAR_ENC_UTF_16_LE;
else if(!memcmp(line, BOM_UTF_16_BE, BOM_UTF_16_SIZE)) bom_read = BOM_UTF_16_SIZE;
{ }
char_enc = CHAR_ENC_UTF_16_BE; else if(!memcmp(line, BOM_UTF_16_BE, BOM_UTF_16_SIZE))
bom_read = BOM_UTF_16_SIZE; {
char_enc = CHAR_ENC_UTF_16_BE;
bom_read = BOM_UTF_16_SIZE;
}
} }
if (bom_read < BOM_UTF_8_SIZE) if (bom_read < BOM_UTF_8_SIZE)
lseek(fd, cue_file->pos + bom_read, SEEK_SET); lseek(fd, cue_file->pos + bom_read, SEEK_SET);
if (is_embedded) if (is_embedded)