len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-11-09 21:22:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

sound: update global volume state in sound_set_volume()

Browse source 
Instead of calling sound_set_volume() and then manually
setting global_status.volume to match, update the global
volume state directly in sound_set_volume(). This makes
things a bit simpler and less error-prone.

Change-Id: I4db4d60ae1a72bd051ef49c90b1ae7f5ba59e535
This commit is contained in:
Aidan MacDonald 2025-10-01 18:01:35 +01:00 • committed by Solomon Peachy
parent ae001cb60c
commit b19b95c00f
10 changed files with 7 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/plugins/mpegplayer/mpegplayer.c
View file

@ -1897,10 +1897,8 @@ static void osd_set_volume(int delta)
}
/* Sync the global settings */
if (vol != rb->global_status->volume) {
if (vol != rb->global_status->volume)
rb->sound_set(SOUND_VOLUME, vol);
rb->global_status->volume = vol;
}
/* Update the volume display */
osd_refresh(OSD_REFRESH_VOLUME);