len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-09 21:25:19 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

FS#10148 by Dustin Skoracki, removes a redundant check for != BUTTON_NONE in the scrollwheel drivers.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20744 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Thomas Martitz 2009-04-19 17:05:36 +00:00
parent 19fde6c0c0
commit aef5731d71
2 changed files with 41 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c
View file

@ -100,8 +100,6 @@ static void scrollwheel(short dbop_din)
old_btn = btn; old_btn = btn;
repeat = counter = 0; repeat = counter = 0;
} }
if (btn != BUTTON_NONE)
{
/* wheel_delta will cause lists to jump over items, /* wheel_delta will cause lists to jump over items,
* we want this for fast scrolling, but we must keep it accurate * we want this for fast scrolling, but we must keep it accurate
* for slow scrolling */ * for slow scrolling */
@ -114,7 +112,6 @@ static void scrollwheel(short dbop_din)
} }
repeat += 2; repeat += 2;
/* the wheel is more reliable if we don't send ever change, /* the wheel is more reliable if we don't send ever change,
* every 2th is basically one "physical click" is * every 2th is basically one "physical click" is
* 1 item in the rockbox menus */ * 1 item in the rockbox menus */
@ -128,7 +125,6 @@ static void scrollwheel(short dbop_din)
last_wheel_post = current_tick; last_wheel_post = current_tick;
} }
} }
}
if (repeat > 0) if (repeat > 0)
repeat--; repeat--;

3
firmware/target/arm/as3525/sansa-fuze/button-fuze.c
View file

@ -99,8 +99,6 @@ static void scrollwheel(short dbop_din)
old_btn = btn; old_btn = btn;
repeat = counter = 0; repeat = counter = 0;
} }
if (btn != BUTTON_NONE)
{
/* wheel_delta will cause lists to jump over items, /* wheel_delta will cause lists to jump over items,
* we want this for fast scrolling, but we must keep it accurate * we want this for fast scrolling, but we must keep it accurate
* for slow scrolling */ * for slow scrolling */
@ -126,7 +124,6 @@ static void scrollwheel(short dbop_din)
counter = 0; counter = 0;
} }
} }
}
if (repeat > 0) if (repeat > 0)
repeat--; repeat--;
else else