len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-12-10 13:45:10 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix FS#10215 - peakmeter updates breaks scrolling lines in conditionally enalbed viewports... fix is to not disable conditional viewports during these updates which are *only* touching the pm token anyway

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24090 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jonathan Gordon 2009-12-21 06:35:31 +00:00
parent 6643a3bc74
commit ae08a21b42
1 changed files with 20 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

34
apps/gui/skin_engine/skin_display.c
View file

@ -920,22 +920,28 @@ static bool skin_redraw(struct gui_wps *gwps, unsigned refresh_mode)
}
#endif
/* disable any viewports which are conditionally displayed */
for (viewport_list = data->viewports;
viewport_list; viewport_list = viewport_list->next)
/* disable any viewports which are conditionally displayed.
* If we are only refreshing the peak meter then don't change the viewport
* enabled flags as this will stop scrolling. viewports cant be
* toggled in this refresh mode anyway (FS#10215)*/
if (refresh_mode != WPS_REFRESH_PEAK_METER)
{
struct skin_viewport *skin_viewport =
(struct skin_viewport *)viewport_list->token->value.data;
if (skin_viewport->hidden_flags&VP_NEVER_VISIBLE)
for (viewport_list = data->viewports;
viewport_list; viewport_list = viewport_list->next)
{
continue;
}
if (skin_viewport->hidden_flags&VP_DRAW_HIDEABLE)
{
if (skin_viewport->hidden_flags&VP_DRAW_HIDDEN)
skin_viewport->hidden_flags |= VP_DRAW_WASHIDDEN;
else
skin_viewport->hidden_flags |= VP_DRAW_HIDDEN;
struct skin_viewport *skin_viewport =
(struct skin_viewport *)viewport_list->token->value.data;
if (skin_viewport->hidden_flags&VP_NEVER_VISIBLE)
{
continue;
}
if (skin_viewport->hidden_flags&VP_DRAW_HIDEABLE)
{
if (skin_viewport->hidden_flags&VP_DRAW_HIDDEN)
skin_viewport->hidden_flags |= VP_DRAW_WASHIDDEN;
else
skin_viewport->hidden_flags |= VP_DRAW_HIDDEN;
}
}
}
int viewport_count = 0;