len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2025-10-13 10:07:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tools: Switch CFLAGS to -Os -Wall -Wextra

Browse source 
(From -Og -W -Wall -pendantic)

Change-Id: If094a22e7c7cd4fb175909fd12b9d8de514f1f38
This commit is contained in:
Solomon Peachy 2025-05-23 08:41:44 -04:00
parent 83a8fc4c7e
commit adaae1731f
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tools/Makefile
View file

@ -5,8 +5,8 @@
# Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \ # Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
# \/ \/ \/ \/ \/ # \/ \/ \/ \/ \/
# #
CFLAGS := -O -g -W -Wall -Wshadow -pedantic CFLAGS := -Os -Wall -Wextra
LDFLAGS := -g LDFLAGS :=
.PHONY: rbspeexenc uclpack .PHONY: rbspeexenc uclpack

7
tools/mkzenboot.c
View file

@ -885,13 +885,12 @@ int mkboot(const char* infile, const char* bootfile, const char* outfile, struct
return -3; return -3;
} }
fclose(infd);
/* Rudimentary Win32 PE reading */ /* Rudimentary Win32 PE reading */
if(memcmp(&buffer[0], "MZ", 2) != 0 && if(memcmp(&buffer[0], "MZ", 2) != 0 &&
memcmp(&buffer[0x118], "PE", 2) != 0) memcmp(&buffer[0x118], "PE", 2) != 0)
{ {
log_message("[ERR] Input file isn't an executable\n"); log_message("[ERR] Input file isn't an executable\n");
fclose(infd);
free(buffer); free(buffer);
return -4; return -4;
} }
@ -910,6 +909,7 @@ int mkboot(const char* infile, const char* bootfile, const char* outfile, struct
if(data_ptr == 0 || data_size == 0) if(data_ptr == 0 || data_size == 0)
{ {
log_message("[ERR] Couldn't find .data section\n"); log_message("[ERR] Couldn't find .data section\n");
fclose(infd);
free(buffer); free(buffer);
return -5; return -5;
} }
@ -920,6 +920,7 @@ int mkboot(const char* infile, const char* bootfile, const char* outfile, struct
if(fw_offset == 0) if(fw_offset == 0)
{ {
log_message("[ERR] Couldn't find firmware offset\n"); log_message("[ERR] Couldn't find firmware offset\n");
fclose(infd);
free(buffer); free(buffer);
return -6; return -6;
} }
@ -927,6 +928,8 @@ int mkboot(const char* infile, const char* bootfile, const char* outfile, struct
log_message("[INFO] Firmware offset is at 0x%x with size 0x%x\n", data_ptr+fw_offset, fw_size); log_message("[INFO] Firmware offset is at 0x%x with size 0x%x\n", data_ptr+fw_offset, fw_size);
fw_key = find_firmware_key(&buffer[0], filesize(infd)); fw_key = find_firmware_key(&buffer[0], filesize(infd));
fclose(infd);
if(fw_key == NULL) if(fw_key == NULL)
{ {
log_message("[ERR] Couldn't find firmware key\n"); log_message("[ERR] Couldn't find firmware key\n");