len0rd/rockbox
1
0
Fork 1
mirror of https://github.com/Rockbox/rockbox.git synced 2026-10-09 23:53:28 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pcm: Fix up some compile warnings that show up under some sim builds

Browse source 
firmware/pcm_mixer.c:36:35: warning: conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
   36 | static unsigned int mixer_sampr = -1UL;
      |
firmware/pcm_mixer.c:269:21: warning: comparison is always false due to limited range of data type [-Wtype-limits]
  269 |     if (mixer_sampr == -1UL)
      |                     ^~

So drop the 'L' and everything is peachy.

Change-Id: I9440d3300931be229c6c4b01bdc1d09b55c34d88
This commit is contained in:
Solomon Peachy 2026-03-28 08:51:37 -04:00
parent daef425c59
commit a84a38dd87
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/pcm.c
View file

@ -202,7 +202,7 @@ void pcm_do_peak_calculation(struct pcm_peaks *peaks, bool active,
if (active) if (active)
{ {
struct pcm_sink* sink = sinks[cur_sink]; struct pcm_sink* sink = sinks[cur_sink];
if (sink->configured_freq == -1UL) if (sink->configured_freq == -1U)
{ {
logf("not configured yet"); logf("not configured yet");
return; return;
@ -250,7 +250,7 @@ void pcm_init(void)
for(size_t i = 0; i < ARRAYLEN(sinks); i += 1) { for(size_t i = 0; i < ARRAYLEN(sinks); i += 1) {
struct pcm_sink* sink = sinks[i]; struct pcm_sink* sink = sinks[i];
sink->pending_freq = sink->caps.default_freq; sink->pending_freq = sink->caps.default_freq;
sink->configured_freq = -1UL; sink->configured_freq = -1U;
sink->pcm_is_ready = false; sink->pcm_is_ready = false;
sink->ops.init(); sink->ops.init();
} }

4
firmware/pcm_mixer.c
View file

@ -33,7 +33,7 @@
before the last samples are sent to the codec and so things are done in before the last samples are sent to the codec and so things are done in
parallel (as much as possible) with sending-out data. */ parallel (as much as possible) with sending-out data. */
static unsigned int mixer_sampr = -1UL; static unsigned int mixer_sampr = -1U;
static unsigned int mix_frame_size = MIX_FRAME_SAMPLES*4; static unsigned int mix_frame_size = MIX_FRAME_SAMPLES*4;
/* Define this to nonzero to add a marker pulse at each frame start */ /* Define this to nonzero to add a marker pulse at each frame start */
@ -266,7 +266,7 @@ static void mixer_start_pcm(void)
#endif #endif
/* Requires a shared global sample rate for all channels */ /* Requires a shared global sample rate for all channels */
if (mixer_sampr == -1UL) if (mixer_sampr == -1U)
mixer_sampr = pcm_get_frequency(); mixer_sampr = pcm_get_frequency();
else else
pcm_set_frequency(mixer_sampr); pcm_set_frequency(mixer_sampr);